From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.28.116.6 with SMTP id p6mr897942wmc.5.1519752220334; Tue, 27 Feb 2018 09:23:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.193.69 with SMTP id r66ls438063wmf.10.gmail; Tue, 27 Feb 2018 09:23:39 -0800 (PST) X-Google-Smtp-Source: AG47ELtQD9DYEJDDejDsk1K/ZK/T9yQOIaWvI6mrAtxbc9v7a6/liOQ4K4XC6plMxx6g8BQCH2eL X-Received: by 10.28.69.76 with SMTP id s73mr1597203wma.15.1519752219721; Tue, 27 Feb 2018 09:23:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519752219; cv=none; d=google.com; s=arc-20160816; b=b1uCFtUbrHZLgpV/ZBsRRYcTd4Tn/UJ8R7L8QoCYR9GydntVPkHkBishXoWRZSc3iO x95rEZ/XCkdZgF7XYAZpEFzUHr3CkojYPzhtEixS2NFiHAGE6jdpOxB2VnpoPsny4axV w9K8R4wnJI9fSH3yoAFRsFOLSvZV/nchw+Kko0LF+fF6GE1SvOuDN+06YySXIKnyo3H8 WIqwVIc+e1gSarcs+EImHqhtyUWJSzEvmGHTcMj36oBC7XAYjsYr+wpxw27VUWyO7LG0 bNNkYAX+5VOZQSi29GwXQu7q9qI6ifiZ91rgzcTp/7FkPdlGbywOvvZ1EgGyt9PyOFbP Kg+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=O35HiB3nL1SsKwHO3ZIUIvbFEAaKP97jJbQa4bccLfc=; b=X0SaRNW9t3ciwOhOnpQ2Rm6dKehvpDpNN1dhwhW/rTTMwPQ5fB9N//BNvs4isT69/y Gx3m2gYdoIQWaQZWL77SZYWj4OcdVrIpl5ZQI6fvtXr/DwnuIZFN4dyHvvrNZ1RYeRxs b5K0HsNv63q/JG1h2dDLh+ZocP5kJWClsIcVedX3TabzKpUC5SDizds5IfPyQiBQm9wG cCXsOl49ZTHuN/DJtzoN5AHwZSG9H/3A/1tUrmtWoz7dP05pMPw5XVV2Tisclmu5Zrqj 07ah3qgvH9D5+s008Ii/jbQZNpRNqO6Lasq76sUiTVvxp/CSsKczy0GKMfNeRQW+vRKP oplA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id v8si584315wrg.2.2018.02.27.09.23.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Feb 2018 09:23:39 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w1RHNdOw029110 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 27 Feb 2018 18:23:39 +0100 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w1RHNdor003600; Tue, 27 Feb 2018 18:23:39 +0100 From: Henning Schild To: isar-users@googlegroups.com Cc: Henning Schild Subject: [PATCH] meta: image: detect broken symlinks Date: Tue, 27 Feb 2018 18:23:36 +0100 Message-Id: <20180227172336.19786-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.16.1 X-TUID: klHoICSVq+YY Switch get_image_name from os.path.lexists to os.path.exists because the latter detects broken symlinks correctly. Issue: If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook will still call "linux-update-symlinks" and create a broken symlink. After that os.path.lexists will return True and "sudo cp" in do_copy_boot_files will fail. Signed-off-by: Henning Schild --- meta/classes/image.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 2c255f4..46d3560 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -8,7 +8,7 @@ IMAGE_ROOTFS = "${WORKDIR}/rootfs" def get_image_name(d, name_link): S = d.getVar("IMAGE_ROOTFS", True) path_link = os.path.join(S, name_link) - if os.path.lexists(path_link): + if os.path.exists(path_link): return os.path.basename(os.path.realpath(path_link)) return "" -- 2.16.1