public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH 0/1] bind mount our downloads folder from buildchroot
@ 2018-03-01  9:25 Cedric Hombourger
  2018-03-01  9:25 ` [PATCH 1/1] buildchroot: bind mount our downloads folder Cedric Hombourger
  0 siblings, 1 reply; 4+ messages in thread
From: Cedric Hombourger @ 2018-03-01  9:25 UTC (permalink / raw)
  To: isar-users

The dpkg-base class would only mount our downloads folder if isar-apt is not
yet mounted. When we do a full build, the buildchroot recipe will mount isar-apt
and the mount condition found in the dpkg-base class will always be false. Bind
mount the downloads folder from the buildchroot (we could have also changed the
dpkg-base class).

Cedric Hombourger (1):
  buildchroot: bind mount our downloads folder

 meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
 1 file changed, 1 insertion(+)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] buildchroot: bind mount our downloads folder
  2018-03-01  9:25 [PATCH 0/1] bind mount our downloads folder from buildchroot Cedric Hombourger
@ 2018-03-01  9:25 ` Cedric Hombourger
  2018-03-02 12:17   ` Jan Kiszka
  2018-03-02 14:42   ` Alexander Smirnov
  0 siblings, 2 replies; 4+ messages in thread
From: Cedric Hombourger @ 2018-03-01  9:25 UTC (permalink / raw)
  To: isar-users

dpkg-base would only mount our downloads folder if isar-apt is not
yet mounted. When we do a full build, the buildchroot recipe will
mount isar-apt and the mount condition found in the dpkg-base class
will always be false. Bind mount the downloads folder from the
buildchroot (we could have also changed the dpkg-base class).

See https://groups.google.com/forum/#!topic/isar-users/wuxNStTkVtg

Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
index 520daf9..2fc5297 100644
--- a/meta/recipes-devtools/buildchroot/buildchroot.bb
+++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
@@ -68,6 +68,7 @@ do_build() {
     sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt
     sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev
     sudo mount -t proc none ${BUILDCHROOT_DIR}/proc
+    sudo mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads
 
     # Create root filesystem
     sudo -E multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf"
-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] buildchroot: bind mount our downloads folder
  2018-03-01  9:25 ` [PATCH 1/1] buildchroot: bind mount our downloads folder Cedric Hombourger
@ 2018-03-02 12:17   ` Jan Kiszka
  2018-03-02 14:42   ` Alexander Smirnov
  1 sibling, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2018-03-02 12:17 UTC (permalink / raw)
  To: Cedric Hombourger, isar-users

On 2018-03-01 10:25, Cedric Hombourger wrote:
> dpkg-base would only mount our downloads folder if isar-apt is not
> yet mounted. When we do a full build, the buildchroot recipe will
> mount isar-apt and the mount condition found in the dpkg-base class
> will always be false. Bind mount the downloads folder from the
> buildchroot (we could have also changed the dpkg-base class).
> 
> See https://groups.google.com/forum/#!topic/isar-users/wuxNStTkVtg
> 
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/recipes-devtools/buildchroot/buildchroot.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb
> index 520daf9..2fc5297 100644
> --- a/meta/recipes-devtools/buildchroot/buildchroot.bb
> +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb
> @@ -68,6 +68,7 @@ do_build() {
>      sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt
>      sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev
>      sudo mount -t proc none ${BUILDCHROOT_DIR}/proc
> +    sudo mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads
>  
>      # Create root filesystem
>      sudo -E multistrap -a ${DISTRO_ARCH} -d "${BUILDCHROOT_DIR}" -f "${WORKDIR}/multistrap.conf"
> 

Looks good!

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] buildchroot: bind mount our downloads folder
  2018-03-01  9:25 ` [PATCH 1/1] buildchroot: bind mount our downloads folder Cedric Hombourger
  2018-03-02 12:17   ` Jan Kiszka
@ 2018-03-02 14:42   ` Alexander Smirnov
  1 sibling, 0 replies; 4+ messages in thread
From: Alexander Smirnov @ 2018-03-02 14:42 UTC (permalink / raw)
  To: Cedric Hombourger, isar-users



On 03/01/2018 12:25 PM, Cedric Hombourger wrote:
> dpkg-base would only mount our downloads folder if isar-apt is not
> yet mounted. When we do a full build, the buildchroot recipe will
> mount isar-apt and the mount condition found in the dpkg-base class
> will always be false. Bind mount the downloads folder from the
> buildchroot (we could have also changed the dpkg-base class).
> 
> See https://groups.google.com/forum/#!topic/isar-users/wuxNStTkVtg

Applied, thanks.

P.S.: please use upper case after semicolon in patch name.

Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-02 14:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-01  9:25 [PATCH 0/1] bind mount our downloads folder from buildchroot Cedric Hombourger
2018-03-01  9:25 ` [PATCH 1/1] buildchroot: bind mount our downloads folder Cedric Hombourger
2018-03-02 12:17   ` Jan Kiszka
2018-03-02 14:42   ` Alexander Smirnov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox