From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.223.175.42 with SMTP id z39mr1467449wrc.21.1520275763695; Mon, 05 Mar 2018 10:49:23 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.14.148 with SMTP id 142ls6395wmo.11.gmail; Mon, 05 Mar 2018 10:49:23 -0800 (PST) X-Google-Smtp-Source: AG47ELsSDJH9aNN8f5hL93Kf6n7b9KEIGYrJLxGEqJHiTJHI4OnYwnWowtlVYoVaVfIOzysEnc5/ X-Received: by 10.28.210.85 with SMTP id j82mr1222983wmg.29.1520275763163; Mon, 05 Mar 2018 10:49:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520275763; cv=none; d=google.com; s=arc-20160816; b=u8GuoHdRIxkwz3HeDzUI9LPbjJp4SYc69IahcWTD8xmmizDg30DlT3vPg6qkUwMVum bySNj04FS9/g3WozzjkdgS/Bh+vlHOoStfHxJJL4k4GtwaLY3779XBSVWsiD3nKFypPD 7d3b6p7FhofMRS58dI0b9xcRytu1zQI81Km0GA0nmePT3ZevImI/4v5/ayRByWp7tFpx j3IURc43PH3f/2garcYLl85xWN+6OAZq+sZ2qqR2Y5yIxi3E5gSPSrQ5xiqEyzYyvwTF dKsw+Y/0OVotk3dTutC8t8ba+SynwbOa86V1t9+8VKhdanVmxJlT0PXLAoSxsBhmLZqB K2YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=KYD/A3FF1yVeYzlJyVU9M9eGiPEiRh7UYXIlBmJ9J4U=; b=1A+3c6HgToxibzKTuRxRVfDjRQkyZzAm+fGC4vRJ4Mp0fhtL9PFlvk2dmI8rUx5Qld OdYHqlsYaGPNHaMLHm9E3o21lyw09x2SrHFipQDM9/e03HzwlEIix3zzfa+szsydwbAc cfMtxaktUFYz2Wj5ajlZl3wlR3oBykLaWfPZ21pMuyyqH1aVcJSW+YaS6pE6uYcsWJV+ smiOyK8ZFkT0Z1m2wnLz3foaEet6EALUzv2UTSBq8aMqCoJab5FDfu0/Z+GLgqk80JyT 8WiqaQX8a+NmnVo+UGI6nudUmzgyEprnE8bTCAzAHNjb/9U1qnstsvRhR6Z+I/zl1b8Y FASg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id l1si312358wmc.0.2018.03.05.10.49.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Mar 2018 10:49:23 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w25InMIC029577 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Mar 2018 19:49:22 +0100 Received: from mmd1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w25InMhN021185; Mon, 5 Mar 2018 19:49:22 +0100 Date: Mon, 5 Mar 2018 19:49:20 +0100 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH] meta: image: detect broken symlinks Message-ID: <20180305194920.5d8f765f@mmd1pvb1c.ad001.siemens.net> In-Reply-To: References: <20180227172336.19786-1-henning.schild@siemens.com> <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: JYhatQCuSWGk Am Sun, 4 Mar 2018 22:28:36 +0300 schrieb Alexander Smirnov : > On 03/02/2018 07:30 PM, Alexander Smirnov wrote: > > On 02/27/2018 08:23 PM, Henning Schild wrote: > >> Switch get_image_name from os.path.lexists to os.path.exists > >> because the latter detects broken symlinks correctly. > >> > >> Issue: > >> If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst > >> hook will > >> still call "linux-update-symlinks" and create a broken symlink. > >> After that os.path.lexists will return True and "sudo cp" in > >> do_copy_boot_files will fail. > >> > > > > Applied, thanks. > > > > P.S.: fixed to upper case after semicolon in patch topic. > > Dropped from the next branch. The patch breaks 'start_vm' script, > $INITRD_IMAGE variable is no more valid with it. Ok, that is a bug in the script since it can not handle the valid case that the variable is not set. Anyways, i updated the script along with my patch and your jenkins is currently testing that. Will send an updated version of that patch soon. Henning > Alex >