[PATCH 1/1] isar-events: try unmounting all mounts before returning an error

[Cedric Hombourger <Cedric_Hombourger@mentor.com>]

Isar would loop forever if a mount cannot be unmounted because another
bind mount was done underneath it (e.g. <basedir>/sys/devices on top
of <basedir>/sys). Increase of chances of success by trying to unmount
everything before returning an error. In the <basedir>/sys/dev case,
we may try <basedir>/sys first and fail but would continue to unmount
<basedir>/sys/dev. On the following call, only <basedir>/sys will remain
and the unmount_all should now succeed. We may want to implement a
timeout: e.g. giveup after 30 tries (i.e. approximately 30 seconds)?

Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
---
 meta/classes/isar-events.bbclass | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass
index 29c7437..b3ce434 100644
--- a/meta/classes/isar-events.bbclass
+++ b/meta/classes/isar-events.bbclass
@@ -14,14 +14,15 @@ python isar_handler () {
         # '/proc/mounts' contains all the active mounts, so knowing basepath
         # we can get the list of mounts for the specific multiconfig and
         # clean them.
+        result = True
         with open('/proc/mounts', 'rU') as f:
             for line in f:
                 if basepath in line:
                     if subprocess.call('sudo umount ' + line.split()[1],
                                        stdout=devnull, stderr=devnull,
                                        shell=True) != 0:
-                        return False
-        return True
+                        result = False
+        return result
 
     devnull = open(os.devnull, 'w')
 
-- 
2.11.0