From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6524973730788016128 X-Received: by 10.28.8.21 with SMTP id 21mr1967817wmi.0.1520439403066; Wed, 07 Mar 2018 08:16:43 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.184.114 with SMTP id u47ls644165wrf.10.gmail; Wed, 07 Mar 2018 08:16:42 -0800 (PST) X-Google-Smtp-Source: AG47ELvFjriSFhAL5Q8Yo86majUJL6YJHuQRiM+0jCiUgLqLDnjTud0vGPHHtyKBSrZvGLu843pu X-Received: by 10.223.187.6 with SMTP id r6mr2173034wrg.9.1520439402576; Wed, 07 Mar 2018 08:16:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520439402; cv=none; d=google.com; s=arc-20160816; b=EZKMjs8hr0cF4MK7G0MHop1wZuwShgf6HDzFrnzkKPmUx6B0l6o+Xoj2EMIOL/yBV9 HLukG7PhCmlu2saHghbwVCJonCfvPFF29/tVrGM/hA3SNiafsqCZzRKR94E3iSuoJOJ4 aj7u9Mu5U66Rg980E3HohikSzzZ5OnEHTczTbpkJ7G+FTUFi1fk/1PMWQt8ka4pglHBu 8DihoVBpV/L1hdcgg4rlb42WBYbOLAs31vB+ZAiN3yjCf2yVPcysT2jrCDLiJR5KT9PH TfJNyX5MG/U70/ESYF0CnKe1KcOhE3F/jSuN2QZl6TzTazuOOOJsf+ZRdlKjw7zkyQB+ WZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=RdBlPCLGCUxzVji91yBiyfIJfazwnfoXbMvBrcYKq0Y=; b=kMwfJxurTj441KLqr1wEccX6pTUyb4etyKlDrEYyC8Rns+dlCXceidkAqUA9aUd2ys OQakSfQncklISgppruSWElDYhe4HfJWUoQhK7yDuZp5XSU+6A7WZQe2JT+OLRkJpEIBB 2EPdUY71k2Z1SLS3Qr3vjS/1eUQHP04iGI6wnzbRaBDnCo1pg9IhQA5lq1Nrtt7/ZrmM IASvo7M8n5X7avX/R9sXATjeQm7rci9ymVcLX26U45S6e4Mci/2vNhyLWDiiBCjliY1E 04uB4nEtf49zQOG0mzIlpB5LRhxJcnZF91JD1MkmmyTXsM0NOk//Y7exghhuW7N4skBz 5Hhw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id d4si105785wmh.2.2018.03.07.08.16.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Mar 2018 08:16:42 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w27GGfqt000754 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Mar 2018 17:16:41 +0100 Received: from ring.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w27GGfLV003137; Wed, 7 Mar 2018 17:16:41 +0100 From: claudius.heine.ext@siemens.com To: isar-users@googlegroups.com Cc: Claudius Heine Subject: [PATCH v3 4/5] meta-isar/isar-image-base: switch to using isar-bootstrap Date: Wed, 7 Mar 2018 17:16:34 +0100 Message-Id: <20180307161635.30952-5-claudius.heine.ext@siemens.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180307161635.30952-1-claudius.heine.ext@siemens.com> References: <20180307161635.30952-1-claudius.heine.ext@siemens.com> X-TUID: qmtRFbU/StUl From: Claudius Heine This patch removes the multistrap dependency of the isar-image-base recipe and changes it to use the 'isar-bootstrap' and 'isar-bootstrap-helper' instead. Signed-off-by: Claudius Heine --- .../recipes-core/images/files/download_dev-random | 24 ------- .../recipes-core/images/files/multistrap.conf.in | 38 ----------- meta-isar/recipes-core/images/files/setup.sh | 77 ---------------------- meta-isar/recipes-core/images/isar-image-base.bb | 64 ++++++------------ meta/classes/image.bbclass | 2 +- 5 files changed, 22 insertions(+), 183 deletions(-) delete mode 100644 meta-isar/recipes-core/images/files/download_dev-random delete mode 100644 meta-isar/recipes-core/images/files/multistrap.conf.in delete mode 100755 meta-isar/recipes-core/images/files/setup.sh diff --git a/meta-isar/recipes-core/images/files/download_dev-random b/meta-isar/recipes-core/images/files/download_dev-random deleted file mode 100644 index f7f5fe5..0000000 --- a/meta-isar/recipes-core/images/files/download_dev-random +++ /dev/null @@ -1,24 +0,0 @@ -#!/bin/sh -# -# This software is a part of ISAR. -# Copyright (C) 2017 ilbers GmbH - -set -e - -readonly ROOTFS="$1" - -if [ ! -c ${ROOTFS}/dev/random ]; then - rm -f ${ROOTFS}/dev/random - mknod "${ROOTFS}/dev/random" c 1 8 - chmod 666 "${ROOTFS}/dev/random" - chown 0:0 "${ROOTFS}/dev/random" -fi - -if [ ! -c ${ROOTFS}/dev/urandom ]; then - rm -f ${ROOTFS}/dev/urandom - mknod "${ROOTFS}/dev/urandom" c 1 9 - chmod 666 "${ROOTFS}/dev/urandom" - chown 0:0 "${ROOTFS}/dev/urandom" -fi - -exit 0 diff --git a/meta-isar/recipes-core/images/files/multistrap.conf.in b/meta-isar/recipes-core/images/files/multistrap.conf.in deleted file mode 100644 index 432b6af..0000000 --- a/meta-isar/recipes-core/images/files/multistrap.conf.in +++ /dev/null @@ -1,38 +0,0 @@ -# This software is a part of ISAR. -# Copyright (C) 2015-2017 ilbers GmbH - -[General] -noauth=true -unpack=true -ignorenativearch=true -bootstrap=##DISTRO_MULTICONF_BOOTSTRAP## Isar -aptsources=##DISTRO_MULTICONF_APTSOURCES## -configscript=##CONFIG_SCRIPT## -setupscript=##SETUP_SCRIPT## -hookdir=##DIR_HOOKS## - -[base] -source=##DISTRO_APT_SOURCE## -suite=##DISTRO_SUITE## -components=##DISTRO_COMPONENTS## -packages=##IMAGE_PREINSTALL## -omitdebsrc=true - -[updates] -source=##DISTRO_APT_SOURCE## -suite=##DISTRO_SUITE##-updates -components=##DISTRO_COMPONENTS## -omitdebsrc=true - -[security] -source=##DISTRO_APT_SOURCE_SEC## -suite=##DISTRO_SUITE##/updates -components=##DISTRO_COMPONENTS## -omitdebsrc=true - -[Isar] -packages=##IMAGE_INSTALL## -source=##DEPLOY_DIR_APT## -suite=##ISAR_DISTRO_SUITE## -components=main -omitdebsrc=true diff --git a/meta-isar/recipes-core/images/files/setup.sh b/meta-isar/recipes-core/images/files/setup.sh deleted file mode 100755 index 86c065c..0000000 --- a/meta-isar/recipes-core/images/files/setup.sh +++ /dev/null @@ -1,77 +0,0 @@ -#!/bin/sh -# -# This software is a part of ISAR. -# Copyright (C) 2015-2016 ilbers GmbH -# -# Based on multistrap/examples/chroot.sh - -set -e - -# The script is called with the following arguments: -# $1 = $DIR - the top directory of the bootstrapped system -# $2 = $ARCH - the specified architecture, already checked with -# dpkg-architecture. -# setup.sh needs to be executable. - -TARGET=$1 -ARCH=$2 - -# Prevent daemons from starting in postinstall during the initial "dpkg -# --configure -a" under QEMU on the build host -if [ -x "$TARGET/sbin/start-stop-daemon" ]; then - echo "initctl: Trying to prevent daemons from starting in $TARGET" - - # Disable start-stop-daemon - mv $TARGET/sbin/start-stop-daemon $TARGET/sbin/start-stop-daemon.REAL - cat > $TARGET/sbin/start-stop-daemon << EOF -#!/bin/sh -echo -echo Warning: Fake start-stop-daemon called, doing nothing -EOF - chmod 755 $TARGET/sbin/start-stop-daemon -fi - -if [ -x "$TARGET/sbin/initctl" ]; then - echo "start-stop-daemon: Trying to prevent daemons from starting in $TARGET" - - # Disable initctl - mv "$TARGET/sbin/initctl" "$TARGET/sbin/initctl.REAL" - cat > $TARGET/sbin/initctl << EOF -#!/bin/sh -echo -echo "Warning: Fake initctl called, doing nothing" -EOF - chmod 755 $TARGET/sbin/initctl -fi - -# Define sysvinit policy 101 to prevent daemons from starting in postinstall -# during the initial "dpkg --configure -a" under QEMU on the build host -if [ -x "$TARGET/sbin/init" -a ! -f "$TARGET/usr/sbin/policy-rc.d" ]; then - echo "sysvinit: Using policy-rc.d to prevent daemons from starting in $TARGET" - - cat > $TARGET/usr/sbin/policy-rc.d << EOF -#!/bin/sh -echo "sysvinit: All runlevel operations denied by policy" >&2 -exit 101 -EOF - chmod a+x $TARGET/usr/sbin/policy-rc.d -fi - -case $ARCH in - armel|armhf) - qemu_arch=arm - ;; - arm64) - qemu_arch=aarch64 - ;; -esac - -# Install QEMU emulator to execute foreign binaries -if [ ! -x /usr/bin/qemu-${qemu_arch}-static ]; then - echo "qemu-${qemu_arch}-static binary not present, unable to execute target binaries" -else - sudo cp /usr/bin/qemu-${qemu_arch}-static ${TARGET}/usr/bin -fi - -# Set hostname -echo "isar" > $TARGET/etc/hostname diff --git a/meta-isar/recipes-core/images/isar-image-base.bb b/meta-isar/recipes-core/images/isar-image-base.bb index 80cb666..c4799d3 100644 --- a/meta-isar/recipes-core/images/isar-image-base.bb +++ b/meta-isar/recipes-core/images/isar-image-base.bb @@ -9,14 +9,12 @@ LICENSE = "gpl-2.0" LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe" FILESPATH =. "${LAYERDIR_isar}/recipes-core/images/files:" -SRC_URI = "file://multistrap.conf.in \ - file://${DISTRO_CONFIG_SCRIPT} \ - file://setup.sh \ - file://download_dev-random" +SRC_URI = "file://${DISTRO_CONFIG_SCRIPT}" PV = "1.0" inherit image +inherit isar-bootstrap-helper IMAGE_INSTALL += "linux-image-${KERNEL_NAME}" @@ -28,50 +26,30 @@ IMAGE_PREINSTALL += "apt \ WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" -do_rootfs[dirs] = "${WORKDIR}/hooks_multistrap" +do_rootfs[root_cleandirs] = "${IMAGE_ROOTFS} \ + ${IMAGE_ROOTFS}/isar-apt" do_rootfs() { - E="${@ bb.utils.export_proxies(d)}" + CDIRS="${@d.expand(d.getVarFlags("do_rootfs").get("root_cleandirs", ""))}" + if [ -n "$CDIRS" ]; then + sudo rm -rf $CDIRS + mkdir -p $CDIRS + fi - sudo rm -rf ${IMAGE_ROOTFS} - - chmod +x "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" - chmod +x "${WORKDIR}/setup.sh" - install -m 755 "${WORKDIR}/download_dev-random" "${WORKDIR}/hooks_multistrap/" - - # Multistrap accepts only relative path in configuration files, so get it: - cd ${TOPDIR} - WORKDIR_REL=${@ os.path.relpath(d.getVar("WORKDIR", True))} - - # Adjust multistrap config - sed -e 's|##IMAGE_PREINSTALL##|${IMAGE_PREINSTALL}|g' \ - -e 's|##DISTRO_MULTICONF_BOOTSTRAP##|${DISTRO_MULTICONF_BOOTSTRAP}|g' \ - -e 's|##DISTRO_MULTICONF_APTSOURCES##|${DISTRO_MULTICONF_APTSOURCES}|g' \ - -e 's|##DISTRO_APT_SOURCE##|${DISTRO_APT_SOURCE}|g' \ - -e 's|##DISTRO_APT_SOURCE_SEC##|${DISTRO_APT_SOURCE_SEC}|g' \ - -e 's|##DISTRO_SUITE##|${DISTRO_SUITE}|g' \ - -e 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|g' \ - -e 's|##CONFIG_SCRIPT##|./'"$WORKDIR_REL"'/${DISTRO_CONFIG_SCRIPT}|g' \ - -e 's|##SETUP_SCRIPT##|./'"$WORKDIR_REL"'/setup.sh|g' \ - -e 's|##DIR_HOOKS##|./'"$WORKDIR_REL"'/hooks_multistrap|g' \ - -e 's|##IMAGE_INSTALL##|${IMAGE_INSTALL}|g' \ - -e 's|##DEPLOY_DIR_APT##|copy:///${DEPLOY_DIR_APT}/${DISTRO}|g' \ - -e 's|##ISAR_DISTRO_SUITE##|${DEBDISTRONAME}|g' \ - "${WORKDIR}/multistrap.conf.in" > "${WORKDIR}/multistrap.conf" - - # Do not use bitbake flag [dirs] here because this folder should have - # specific ownership. - [ ! -d ${IMAGE_ROOTFS}/proc ] && sudo install -d -o 0 -g 0 -m 555 ${IMAGE_ROOTFS}/proc - sudo mount -t proc none ${IMAGE_ROOTFS}/proc - - # Create root filesystem. We must use sudo -E here to preserve the environment - # because of proxy settings - sudo -E multistrap -a ${DISTRO_ARCH} -d "${IMAGE_ROOTFS}" -f "${WORKDIR}/multistrap.conf" + setup_root_file_system "${IMAGE_ROOTFS}" ${IMAGE_PREINSTALL} ${IMAGE_INSTALL} # Configure root filesystem + sudo install -m 755 "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" "${IMAGE_ROOTFS}" sudo chroot ${IMAGE_ROOTFS} /${DISTRO_CONFIG_SCRIPT} ${MACHINE_SERIAL} \ - ${BAUDRATE_TTY} ${ROOTFS_DEV} ${ROOTFS_TYPE} - sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}" + ${BAUDRATE_TTY} \ + ${ROOTFS_DEV} \ + ${ROOTFS_TYPE} - sudo umount ${IMAGE_ROOTFS}/proc 2>/dev/null || true + # Cleanup + sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}" + sudo rm "${IMAGE_ROOTFS}/etc/apt/sources.list.d/isar-apt.list" + sudo umount -l ${IMAGE_ROOTFS}/isar-apt + sudo rmdir ${IMAGE_ROOTFS}/isar-apt + sudo umount -l ${IMAGE_ROOTFS}/dev + sudo umount -l ${IMAGE_ROOTFS}/proc } diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 2c255f4..56038b3 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -19,7 +19,7 @@ INITRD_IMAGE ?= "${@get_image_name(d, 'initrd.img')}" inherit ${IMAGE_TYPE} do_rootfs[stamp-extra-info] = "${MACHINE}-${DISTRO}" -do_rootfs[depends] = "isar-apt:do_cache_config" +do_rootfs[depends] = "isar-apt:do_cache_config isar-bootstrap:do_deploy" do_rootfs() { die "No root filesystem function defined, please implement in your recipe" -- 2.16.1