Re: [PATCH v2 11/17] images: New class wic-img for wic intregration

[Andreas Reichel <andreas.reichel.ext@siemens.com>]

On Mon, Apr 16, 2018 at 12:17:55PM +0200, [ext] Claudius Heine wrote:
> > > +                             grub-efi-amd64-bin \
> > > +                             grub-efi-ia32-bin \
> > > +                             python3"
> > > +
> > > +python () {
> > > +    if d.getVar('IMAGE_TYPE', True) == 'wic-img':
> 
> That limits how many images types one image recipe has. With OE you could
> create multiple image types from one image recipe. Here you only have one.
> That might be fine. But just as a note. I currently don't have a usecase to
> support multiple image types for one image.
> 
> OE supports different post-processes to the wic image. For instance 'wic.xz'
> creates a compressed wic file and 'wic.bmap' creates a bmap-tool file in
> addition to the wic image.
> 
> I don't know if you currently have plans to implement such expansions, but
> maybe think about how such could be implemented with your current design.
> 

I agree. At least with swupdate we already had the necessity to also add
'ext4.gz'. So I would just test if 'wic-image' is contained in the
IMAGE_TYPE. Nobody knows what image times are needed for special use
cases and an exact match is not required here.

> regards,
> Claudius
> 
> > > +        d.appendVar('BUILDCHROOT_PREINSTALL',
> > > +                    d.getVar('BUILDCHROOT_PREINSTALL_WIC', True))
> > > +}
> > 
> > Now the wic tools become part of buildchroot if you chose that
> > IMAGE_TYPE.
> > 
> > >   WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}"
> > >   do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > > diff --git a/scripts/wic_fakeroot b/scripts/wic_fakeroot
> > > new file mode 100755
> > > index 0000000..9e01c38
> > > --- /dev/null
> > > +++ b/scripts/wic_fakeroot
> > > @@ -0,0 +1,37 @@
> > > +#!/usr/bin/env python3
> > > +#
> > > +# wic needs a FAKEROOT cmd to run, the default is pseudo. In Isar we
> > > do/can not +# use pseudo. And we call wic as root to begin with, so
> > > this script could be a +# dummy doing nothing. It is almost a
> > > dummy ... +#
> > > +# If the fsck hack ever becomes obsolete, FAKEROOTCMD ?= "true;" can
> > > be used +#
> > > +# This software is a part of Isar.
> > > +# Copyright (C) 2018 Siemens AG
> > > +#
> > > +import os
> > > +import sys
> > > +import shutil
> > > +import subprocess
> > > +
> > > +args = sys.argv
> > > +args.pop(0)
> > > +cmd = args[0]
> > > +
> > > +# expect to be running as root
> > > +# we could loosen that and execv(sudo, args) but even some early
> > > +# "du"s fail, which do not use the fakeroot-wrapper
> > > +#  i.e. in wics partition.py the "du -ks" fails on
> > > +#    var/cache/apt/archives/partial
> > > +#    rootfs/root ...
> > > +assert 'root' == os.environ["USER"]
> > > +
> > > +# e2fsck <= 1.43.5 returns 1 on non-errors (stretch and before
> > > affected) +# treat 1 as safe ... the filesystem was successfully
> > > repaired and is OK +if cmd.startswith('fsck.'):
> > > +    ret = subprocess.call(args)
> > > +    if ret == 0 or ret == 1:
> > > +        sys.exit(0)
> > > +    sys.exit(ret)
> > 
> > This is another tool workaround, now outside of wic.
> > 
I don't get this, sorry :) You have a general script to execute commands
in a fake root environment. But then you always return 0 for all
programs no matter if some programs fail with 1 or not. Also, where does
the output of the failed command go? Can't we use 'popen' and write the
output to stdout to get the error message? Just my two cents...

> > > +
> > > +os.execv(shutil.which(cmd), args)
> > 
> 
> -- 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To post to this group, send email to isar-users@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/isar-users/1f89f1a6-9472-ba91-d1f3-fa93722dc2d4%40siemens.com.
> For more options, visit https://groups.google.com/d/optout.

-- 
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant

Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082