Re: [PATCH v2 14/17] multiconfig: Switch qemuamd64-stretch to using wic by default

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 16 Apr 2018 12:25:54 +0200
schrieb Claudius Heine <claudius.heine.ext@siemens.com>:

> Hi Henning,
> 
> On 2018-04-13 16:19, [ext] Henning Schild wrote:
> > This will now create a testcase for CI and an example for users.
> > This uses the EFI WKS_FILE.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >   meta-isar/conf/multiconfig/qemuamd64-stretch.conf | 8 +++++---
> >   1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/meta-isar/conf/multiconfig/qemuamd64-stretch.conf
> > b/meta-isar/conf/multiconfig/qemuamd64-stretch.conf index
> > 64a62a1..356d59b 100644 ---
> > a/meta-isar/conf/multiconfig/qemuamd64-stretch.conf +++
> > b/meta-isar/conf/multiconfig/qemuamd64-stretch.conf @@ -10,9 +10,11
> > @@ KERNEL_NAME ?= "amd64" 
> >   IMAGE_PREINSTALL += "init"
> >   
> > -ROOTFS_DEV ?= "sda"
> > +IMAGE_TYPE ?= "wic-img"
> > +
> > +ROOTFS_DEV ?= "sda2"  
> 
> I know that is not exactly the scope of your patchset, but does it
> make sense to set the ROOTFS_DEV in a multiconf rather in the
> machine.conf or inside the image recipe?

In fact that should not be required when using wic, same for
ROOTFS_TYPE ?= "ext4" found in meta/classes/wic-img.bbclass.

Problem is one of the scripts messing with fstab will create a broken
fstab if those values are not in sync with the .wks. On the wic-path
the messing with fstab should not be done at all. For now keeping the
two in sync was what i chose.

Henning

> regards,
> Claudius
> 
> >   
> >   QEMU_ARCH ?= "x86_64"
> > -QEMU_MACHINE ?= "pc"
> > +QEMU_MACHINE ?= "q35"
> >   QEMU_CPU ?= ""
> > -QEMU_ROOTFS_DEV ?= "-hda ##ROOTFS_IMAGE##"
> > +QEMU_ROOTFS_DEV ?= "-hda ##ROOTFS_IMAGE##
> > -bios /usr/local/share/ovmf/OVMF.fd" 
>