From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543937367387930624 X-Received: by 10.223.201.13 with SMTP id m13mr601424wrh.24.1523885273533; Mon, 16 Apr 2018 06:27:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.153.88 with SMTP id b85ls1761807wme.1.canary-gmail; Mon, 16 Apr 2018 06:27:53 -0700 (PDT) X-Google-Smtp-Source: AIpwx48uRPAPq4wdHI9he2lNky1Sc+6TpyBO3R0xJV0ACtXNQ2AkgzdwNJXGFPNrjCvtKshGmuw+ X-Received: by 10.28.122.24 with SMTP id v24mr806280wmc.13.1523885273037; Mon, 16 Apr 2018 06:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523885272; cv=none; d=google.com; s=arc-20160816; b=Bl9VK+L86te+7smGsQwScrA9VBn7T2MEdu9TaVHQgOZQfe8WJ0x5uETVGQqkuQlpVq kfNB5k0nIR+HCSuWzo56LKNxYmSHhroWYmw0p6/6mQ1e3+VuAx+hvJhwbcXOFfg6l9NE gpuQw4h2333DY5osk6PuTxm1qMgdOgSprkqetNLDLSQBd2HlxzwM1bzm+3gnn/LcAU4p 68T9Sfhfcy4/CX+RrGR4OWKvn8basmglfKxU+bKcJrGRbqGXLHz1FBUO7gKs9i84JISk cIFfkOoYfxPzzmQeYNrE3CXftsBUtASo12zemcPtxx8elq1pcNGX7JLmvETkGGRTu91e SSCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date :arc-authentication-results; bh=Ni0XH8s6cfZ8HN+pqu55vOYGTUyJVsfsWVqZAogA2EQ=; b=Q4mA1UMbx7orRMEVyeIRZIi7nq0pS6Uk49Ye3bw2uMXlxguimU7h0JyxQDjii6wog6 9w8NwI026BtatXFxB9Ehh+NFxsRQ2ISaR2CslFtrrsSVeRmmwaAdQtnoUtwmLHbCoJkO treB4Y1SL0GYX0KdCNjpQvsYpenOqG5esYDiLhRwBT+FMGS78EY75dUIiJJV+hp75p9A SljkV7bCK4x8byCcAwpoTGPJ1KYaDO5Jti0g4GhADUY0t9/8D64dH+EwtsiuJqdLd+/2 k0wmApNbXHKEE0Aj95YloarZv1ZXnjQCu2K83oqFmjt9E3/Y5392HQN6KoEQbF4k0tzA GD8Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id g7si441554wrb.2.2018.04.16.06.27.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 06:27:52 -0700 (PDT) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id w3GDRqE6030641 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Apr 2018 15:27:52 +0200 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.245]) by mail2.sbs.de (8.15.2/8.15.2) with SMTP id w3GDRqHU004744; Mon, 16 Apr 2018 15:27:52 +0200 Date: Mon, 16 Apr 2018 15:24:00 +0200 From: Andreas Reichel To: Henning Schild Cc: isar-users@googlegroups.com, Cedric Hombourger Subject: Re: [PATCH v2 13/17] scripts/start_vm: Enable booting of full disk images Message-ID: <20180416132359.GA2709@iiotirae> References: <4916b6b42d3801db30346985396c4ca9fadf2c9b.1523628814.git.henning.schild@siemens.com> <20180416103357.GB8866@iiotirae> <20180416134628.6a3207f0@mmd1pvb1c.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20180416134628.6a3207f0@mmd1pvb1c.ad001.siemens.net> User-Agent: Mutt/1.9.5 (2018-04-13) X-TUID: MiTDb8fG4J8W On Mon, Apr 16, 2018 at 01:46:28PM +0200, Henning Schild wrote: > Am Mon, 16 Apr 2018 12:33:57 +0200 > schrieb Andreas Reichel : > > > On Fri, Apr 13, 2018 at 04:19:02PM +0200, Henning Schild wrote: > > > The scripts used to support booting with kernel, initrd and rootfs. > > > Enable it to support the IMAGE_TYPE 'wic-img' as well. > > > > > > Signed-off-by: Henning Schild > > > --- > > > scripts/start_vm | 35 +++++++++++++++++++++++++---------- > > > 1 file changed, 25 insertions(+), 10 deletions(-) > > > > > > diff --git a/scripts/start_vm b/scripts/start_vm > > > index 6c89ce9..cfb2bea 100755 > > > --- a/scripts/start_vm > > > +++ b/scripts/start_vm > > > @@ -27,9 +27,6 @@ start_qemu() { > > > -M $QEMU_MACHINE \ > > > $QCPU \ > > > -nographic \ > > > - -kernel $QKERNEL \ > > > - -initrd $QINITRD \ > > > - -append "console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw" > > > \ $EXTRA_ARGS \ > > > $root > > > [ $had_x -eq 0 ] && set +x > > > @@ -104,13 +101,6 @@ do > > > done > > > > > > readonly IMAGE_DIR=$BUILD_DIR/tmp/deploy/images > > > -readonly > > > ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.ext4.img - > > > -eval $(bitbake -e multiconfig:qemu$ARCH-$DISTRO:isar-image-base | > > > grep "^KERNEL_IMAGE=") -eval $(bitbake -e > > > multiconfig:qemu$ARCH-$DISTRO:isar-image-base | grep > > > "^INITRD_IMAGE=") -QKERNEL=$IMAGE_DIR/${KERNEL_IMAGE} > > > -QINITRD=/dev/null -[ -n "$INITRD_IMAGE" ] && > > > QINITRD=$IMAGE_DIR/${INITRD_IMAGE} > > > readonly ISARROOT="$(dirname "$0")"/.. > > > > > > @@ -120,6 +110,31 @@ eval "$(egrep 'MACHINE_SERIAL' $MACHINE_CONF > > > |bb2sh)" readonly > > > CONFIG_CONF=$ISARROOT/meta-isar/conf/multiconfig/qemu$ARCH-$DISTRO.conf > > > eval "$(egrep 'ROOTFS_DEV|QEMU_' $CONFIG_CONF |bb2sh)" > > > +eval $(bitbake -e multiconfig:qemu$ARCH-$DISTRO:isar-image-base | > > > grep "^IMAGE_TYPE=") +case "$IMAGE_TYPE" in > > > + ext4-img) > > > + readonly > > > ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.ext4.img + > > > + eval $(bitbake -e > > > multiconfig:qemu$ARCH-$DISTRO:isar-image-base | grep > > > "^KERNEL_IMAGE=") > > > + eval $(bitbake -e > > > multiconfig:qemu$ARCH-$DISTRO:isar-image-base | grep > > > "^INITRD_IMAGE=") > > > + QKERNEL=$IMAGE_DIR/${KERNEL_IMAGE} > > > + QINITRD=/dev/null > > > + [ -n "$INITRD_IMAGE" ] && QINITRD=$IMAGE_DIR/${INITRD_IMAGE} > > > + EXTRA_ARGS="$EXTRA_ARGS \ > > > + -kernel $QKERNEL \ > > > + -initrd $QINITRD \ > > > + -append \"console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV > > > rw\"" > > > + ;; > > > + wic-img) > > > + readonly > > > ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.wic.img > > > + EXTRA_ARGS="$EXTRA_ARGS -snapshot" > > > + ;; > > > + *) > > > + echo "IMAGE_TYPE \"$IMAGE_TYPE\" not supported" > > > + exit 1 > > > + ;; > > > +esac > > > > Here we have the same problem, that only one image type can be set. > > Yes, but as already discussed it is no array in Isar. > There never are arrays in bitbake, but space separated items in a string. But one could put a bash for loop around the case like for imagetype in $IMAGE_TYPE; do case ... ... esac done > Henning > > > > + > > > QCPU= > > > [ -n "$QEMU_CPU" ] && QCPU="-cpu $QEMU_CPU" > > > > > > -- > > > 2.16.1 > > > > > > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082