From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6546088382730076160 X-Received: by 10.28.148.81 with SMTP id w78mr73856wmd.32.1524157114792; Thu, 19 Apr 2018 09:58:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.116.3 with SMTP id p3ls133914wmc.4.canary-gmail; Thu, 19 Apr 2018 09:58:34 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+fxg7SsBCL72lu164CWCNUDOrdRyZ7sSxqIG9FyMcsa5ZKIpbon+7rngb4q/NIXSkTSWLm X-Received: by 10.28.30.144 with SMTP id e138mr673279wme.11.1524157114340; Thu, 19 Apr 2018 09:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524157114; cv=none; d=google.com; s=arc-20160816; b=U1Fnmjds0oe8ObRi409nFFEencwwptTVBqHk9q6NbZmeKW35scDJSslsW9sAOJDJhP QR2GyGHK/Sc3Z0cqVadXjfyuHo/epBYppjt3G+2aCjDlrqTuRNIUKvixItYNKvKwaWOd 5MZraTwZiGj0qAVYI3VunPOoY0czhrPWUnYIvV48x9I8B/ZqYaszsYlYuFwhYWSOVZIi B5u02LxKZhqLsAAhecz/SVcJXB4z9Sf6qErF94MScv+AQ5gmSGy4MFeWcilIQStSNHiT zu+noh4dA18Vw4f7yf3bBuXcl/aWMtfmCsE/vzVKXJilkYyhmmPnmOncU9AGDRG5500G siow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3PrQDWayvhwL56ARSVMecn66q/JlxleeICLk6i1MWTI=; b=TL4Q4EWDN2ZrpgicVV0dk/2Q7PAEFq0cLyga66CNlcVqvdhmmfhxGmyY5yrltosYO5 cqXecuX4uAW4McA5A+czmsf5BtzJt6kLxdoCbRoq5hFwZETi6/HgCAtJ/ixgMC0GcsX4 mAvtlO5S3y6OPFgKjMCzdoy6Ur6TcDFPXW+5wry35wWUuTOdO5LvRDvAwS+imMHN1HPE nndh8LGwTNXTVb1rG2c+FBI5QY2WySWBl+Crk51bDeyP+COFiHVKNj0+d/T0Q2YyCt/x sUYpMH7EKDPut2u1LXKxSzEw9se7JLX4dP0PUXxnFOBkDOO3sryaumkpq5L8K5C2s0FX UZQw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id s130si28437wms.0.2018.04.19.09.58.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 09:58:34 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w3JGwXrc008037 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 19 Apr 2018 18:58:34 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w3JGwXBe009543; Thu, 19 Apr 2018 18:58:33 +0200 From: Henning Schild To: isar-users@googlegroups.com Cc: Jan Kiszka , Henning Schild Subject: [PATCH v2] Correctly use the bitbake variable S from now on Date: Thu, 19 Apr 2018 18:58:32 +0200 Message-Id: <20180419165832.10741-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180419092602.7791-1-henning.schild@siemens.com> References: <20180419092602.7791-1-henning.schild@siemens.com> X-TUID: MZ6Ro6LErfeI S is defined as ${WORKDIR}/${P} so it already contains ${WORKDIR} by its definition. In Isar it was often concatinated with WORKDIR again. One example where this was a problem is if you specified a patch in SRC_URI but did not actually overwrite S. Align the use of the variable with OE and bitbake defaults again. Impact: layers building on top of Isar will have to adjust their recipes like the internal ones needed modification. The suggestion is to not set S and make sure to unpack to ${WORKDIR}/${P}. When setting S make sure to include ${WORKDIR}. This patch also introduces a warning and tries to preserve the old behaviour a bit. However if your recipe uses patches in SRC_URI and sets S you will get the warning and do_patch will fail. Signed-off-by: Henning Schild --- doc/user_manual.md | 2 +- meta-isar/recipes-app/example-hello/example-hello.bb | 4 +--- meta-isar/recipes-app/libhello/libhello.bb | 4 +--- meta-isar/recipes-kernel/example-module/example-module.bb | 2 +- meta-isar/recipes-kernel/linux/linux-cip_4.4.bb | 4 +--- meta-isar/recipes-kernel/linux/linux-mainline_4.14.18.bb | 4 +--- meta/classes/dpkg-base.bbclass | 13 +++++++++++-- meta/classes/dpkg.bbclass | 2 +- meta/classes/patch.bbclass | 2 +- meta/recipes-kernel/linux-module/module.inc | 8 ++++---- meta/recipes-kernel/linux/linux-custom.inc | 2 +- 11 files changed, 24 insertions(+), 23 deletions(-) diff --git a/doc/user_manual.md b/doc/user_manual.md index 2bd3793..3072bd5 100644 --- a/doc/user_manual.md +++ b/doc/user_manual.md @@ -511,7 +511,7 @@ PV = "1.0" SRC_URI = "git://github.com/ilbers/hello.git" SRCREV = "ad7065ecc4840cc436bfcdac427386dbba4ea719" -S = "git" +S = "${WORKDIR}/git" inherit dpkg ``` diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello.bb index 9788ec0..d23ee6c 100644 --- a/meta-isar/recipes-app/example-hello/example-hello.bb +++ b/meta-isar/recipes-app/example-hello/example-hello.bb @@ -15,11 +15,9 @@ PV = "0.2-86cc719" DEPENDS += "libhello" SRC_URI = " \ - git://github.com/ilbers/hello.git;protocol=https \ + git://github.com/ilbers/hello.git;protocol=https;destsuffix=${P} \ file://0001-Add-some-help.patch \ file://yet-another-change.txt;apply=yes;striplevel=0" SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3" -S = "git" - inherit dpkg diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello.bb index 1875831..4e75f98 100644 --- a/meta-isar/recipes-app/libhello/libhello.bb +++ b/meta-isar/recipes-app/libhello/libhello.bb @@ -10,9 +10,7 @@ LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260 PV = "0.1-98f2e41" -SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https" +SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}" SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93" -S = "git" - inherit dpkg diff --git a/meta-isar/recipes-kernel/example-module/example-module.bb b/meta-isar/recipes-kernel/example-module/example-module.bb index dbaf5ac..98d0aaa 100644 --- a/meta-isar/recipes-kernel/example-module/example-module.bb +++ b/meta-isar/recipes-kernel/example-module/example-module.bb @@ -9,6 +9,6 @@ include recipes-kernel/linux-module/module.inc SRC_URI += "file://src" -S = "src" +S = "${WORKDIR}/src" AUTOLOAD = "1" diff --git a/meta-isar/recipes-kernel/linux/linux-cip_4.4.bb b/meta-isar/recipes-kernel/linux/linux-cip_4.4.bb index 7502f70..e9aaa9f 100644 --- a/meta-isar/recipes-kernel/linux/linux-cip_4.4.bb +++ b/meta-isar/recipes-kernel/linux/linux-cip_4.4.bb @@ -8,12 +8,10 @@ require recipes-kernel/linux/linux-custom.inc SRC_URI += " \ - git://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git;branch=linux-4.4.y-cip \ + git://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git;branch=linux-4.4.y-cip;destsuffix=${P} \ file://x86_64_defconfig" SRCREV = "4e52cc5f668c4666e31a8485725b5f4e897b3baf" PV = "4.4.112-cip18" -S = "git" - KERNEL_DEFCONFIG_qemuamd64 = "x86_64_defconfig" diff --git a/meta-isar/recipes-kernel/linux/linux-mainline_4.14.18.bb b/meta-isar/recipes-kernel/linux/linux-mainline_4.14.18.bb index 2c93d40..751912f 100644 --- a/meta-isar/recipes-kernel/linux/linux-mainline_4.14.18.bb +++ b/meta-isar/recipes-kernel/linux/linux-mainline_4.14.18.bb @@ -8,10 +8,8 @@ require recipes-kernel/linux/linux-custom.inc SRC_URI += " \ - https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-${PV}.tar.xz \ + https://cdn.kernel.org/pub/linux/kernel/v4.x/linux-${PV}.tar.xz;subdir=${P} \ file://x86_64_defconfig" SRC_URI[sha256sum] = "866a94c1c38d923ae18e74b683d7a8a79b674ebdfe7f40f1a3be9a27d39fe354" -S = "linux-${PV}" - KERNEL_DEFCONFIG_qemuamd64 = "x86_64_defconfig" diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 3c3a484..3845d8c 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -2,8 +2,8 @@ # Copyright (C) 2017 Siemens AG do_adjust_git() { - if [ -f ${WORKDIR}/${S}/.git/objects/info/alternates ]; then - sed -i ${WORKDIR}/${S}/.git/objects/info/alternates \ + if [ -f ${S}/.git/objects/info/alternates ]; then + sed -i ${S}/.git/objects/info/alternates \ -e 's|${DL_DIR}|/downloads|' fi } @@ -21,9 +21,18 @@ do_build[depends] = "buildchroot:do_build" DEPENDS ?= "" do_build[deptask] = "do_deploy_deb" +def get_package_srcdir(d): + s = d.getVar("S", True) + workdir = d.getVar("WORKDIR", True) + if s.startswith(workdir): + return s[len(workdir)+1:] + bb.warn('S does not start with WORKDIR') + return s + # Each package should have its own unique build folder, so use # recipe name as identifier PP = "/home/builder/${PN}" +PPS ?= "${@get_package_srcdir(d)}" BUILDROOT = "${BUILDCHROOT_DIR}/${PP}" do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass index 06f0579..c8d4ac5 100644 --- a/meta/classes/dpkg.bbclass +++ b/meta/classes/dpkg.bbclass @@ -6,5 +6,5 @@ inherit dpkg-base # Build package from sources using build script dpkg_runbuild() { E="${@ bb.utils.export_proxies(d)}" - sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${S} + sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${PPS} } diff --git a/meta/classes/patch.bbclass b/meta/classes/patch.bbclass index 26a0c81..0bc449f 100644 --- a/meta/classes/patch.bbclass +++ b/meta/classes/patch.bbclass @@ -5,7 +5,7 @@ python do_patch() { import subprocess workdir = d.getVar("WORKDIR", True) + "/" - src_dir = workdir + (d.getVar("S", True) or "") + src_dir = d.getVar("S", True) for src_uri in (d.getVar("SRC_URI", True) or "").split(): try: diff --git a/meta/recipes-kernel/linux-module/module.inc b/meta/recipes-kernel/linux-module/module.inc index ec1c4b0..3075f44 100644 --- a/meta/recipes-kernel/linux-module/module.inc +++ b/meta/recipes-kernel/linux-module/module.inc @@ -18,14 +18,14 @@ AUTOLOAD ?= "0" inherit dpkg dpkg_runbuild_prepend() { - cp -r ${WORKDIR}/debian ${WORKDIR}/${S}/ + cp -r ${WORKDIR}/debian ${S}/ sed -i -e 's/@PN@/${PN}/g' -e 's/@PV@/${PV}/g' \ -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \ -e 's/@DESCRIPTION@/${DESCRIPTION}/g' \ - ${WORKDIR}/${S}/debian/changelog ${WORKDIR}/${S}/debian/control + ${S}/debian/changelog ${S}/debian/control if [ ${AUTOLOAD} = "1" ]; then - echo "echo ${PN} >> /etc/modules" >> ${WORKDIR}/${S}/debian/postinst - chmod +x ${WORKDIR}/${S}/debian/postinst + echo "echo ${PN} >> /etc/modules" >> ${S}/debian/postinst + chmod +x ${S}/debian/postinst fi } diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc index 0498dfa..2643fec 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc +++ b/meta/recipes-kernel/linux/linux-custom.inc @@ -32,7 +32,7 @@ dpkg_runbuild() { # Install package builder script sudo install -m 755 ${WORKDIR}/build-kernel.sh ${BUILDCHROOT_DIR} - sudo cp ${WORKDIR}/${KERNEL_DEFCONFIG} ${WORKDIR}/${S}/.config + sudo cp ${WORKDIR}/${KERNEL_DEFCONFIG} ${S}/.config E="${@ bb.utils.export_proxies(d)}" -- 2.16.1