From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6549073309689970688 X-Received: by 10.28.114.19 with SMTP id n19mr107463wmc.5.1524824954868; Fri, 27 Apr 2018 03:29:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.112.25 with SMTP id l25ls202695wmc.10.gmail; Fri, 27 Apr 2018 03:29:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqBMq36YHG9xsBrRmhW6yVm9Svt7l5TGKnm+wr6JgWqPVKU7ETOIULm/TobkiqvfAA5MRmB X-Received: by 10.28.12.18 with SMTP id 18mr91410wmm.17.1524824954272; Fri, 27 Apr 2018 03:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524824954; cv=none; d=google.com; s=arc-20160816; b=CO15bpAhhUl66PbYgpQtD76HqmfaZowcRzVk1MjPpcq9vZd0u4nQ/W0lJGoCYJWOWa n+bhQ3/VJMBjcbXZrGfW2t1oowZ7k4YIH8h/eGC/PfLXJudPxb8CHlSGvsz7YCUfoOpz cYX+/qk/NNhktJT/PNHLgow27rmX+rJBkAQbW0FGIGDd/pX9jkZYfinUk7YOjWHVhU6k sRtyAIhZ5tYNemd/OiP6QswRKIVDmNI2Ma5u8IKmJy/hyFuc9NiRuIPlBPOIHBBVpVMW iCbg2++WkMbyoYPebMJoQKY8gGK/XgBqiG9YLZ9xIDKyfLHHU4WrnN5DKoN+jNOSq2yW UXCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=zRzQJKuKYiu2DUCC//ZREHlkdJ+Zz/tBvncfdeQNSYw=; b=niMO1/mDnl1ZW6tE6IkX89rhcx8K9yfzIVWgKukeB0D/pNwA+ydEobOuCzwszvzMJo fxJw4ywzaAK1bsIhH8qrxCa2uKruY+KYUDIkmRRP1+1ak8F8uWsUEPg4Ijeu5bCnYTVq mPjVs7ktoVoFclOPMd8FMZRE/VchnJ9tT2RsoRtN/kevO2RM82pUKyNrbr5Bf/2fCkC6 iGzltxHV/dWtTRGflgvHV90JsVg5QQUTf1cMbvX+ZMFv+U3pf19SxH33bnrjmCqTLgjp gLHrBEgCCCnJCO4EbSkCOcZ3/AGI7evVUry75ICvdoQvmUJThDB/q2rpb5PAmWjzmmrg fFow== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id v3si32989wmh.0.2018.04.27.03.29.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 03:29:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from localhost.localdomain ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w3RAT0J9030986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Apr 2018 12:29:06 +0200 From: Alexander Smirnov To: isar-users@googlegroups.com Cc: Alexander Smirnov Subject: [PATCH 1/2] start_vm: Fix quotes usage Date: Fri, 27 Apr 2018 13:28:52 +0300 Message-Id: <20180427102853.5454-2-asmirnov@ilbers.de> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20180427102853.5454-1-asmirnov@ilbers.de> References: <20180427102853.5454-1-asmirnov@ilbers.de> X-TUID: Ta0VxaQUt5g1 According to the following chapter: http://wiki.bash-hackers.org/syntax/quoting#quotes_and_escaping MYARG="\"my multiword argument\"" somecommand $MYARG is NOT the same as: command "my multiword argument" So this patch splits kernel params to separate variable for correct interpretation. Tested with bash and dash in Debian jessie. Signed-off-by: Alexander Smirnov --- scripts/start_vm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/start_vm b/scripts/start_vm index cfb2bea..7eb633e 100755 --- a/scripts/start_vm +++ b/scripts/start_vm @@ -28,6 +28,7 @@ start_qemu() { $QCPU \ -nographic \ $EXTRA_ARGS \ + "$KARGS" \ $root [ $had_x -eq 0 ] && set +x } @@ -123,7 +124,8 @@ case "$IMAGE_TYPE" in EXTRA_ARGS="$EXTRA_ARGS \ -kernel $QKERNEL \ -initrd $QINITRD \ - -append \"console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw\"" + -append " + KARGS="console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw" ;; wic-img) readonly ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.wic.img -- 2.9.5