From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6549073309689970688
X-Received: by 10.28.153.211 with SMTP id b202mr128306wme.21.1524827210808;
        Fri, 27 Apr 2018 04:06:50 -0700 (PDT)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:adf:b872:: with SMTP id u47-v6ls380746wrf.6.gmail; Fri, 27
 Apr 2018 04:06:50 -0700 (PDT)
X-Google-Smtp-Source: AB8JxZrLw72jCJLKtxsxs1A95ucbr+4jjGHTPcCsRc+t0WRc2kLBVsUDN1jfVwGTLiXX3OK7Mmqk
X-Received: by 2002:adf:e7c7:: with SMTP id e7-v6mr127495wrn.25.1524827210436;
        Fri, 27 Apr 2018 04:06:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1524827210; cv=none;
        d=google.com; s=arc-20160816;
        b=spjvhij0/1DhWrC8GWm8ROMmtgRk3dyvquRcPJDYLIWcmX2cCeW3qXeMLrtSshaDVe
         He+l9BKO+wqwOKKida1YxHvn3O3ZftMyBtNKdVQTGtXOUknjECzUurlUxNSALvHI5ZYG
         vFgOxH0NW46gPObsUZEmihEA0THQuC/hy1HnBGw/NjwlXdzrJZVrZ/QYKgYTbQkqbhkv
         4n4lHo4XLTNpwrWZRFVslMeBaZbN9sImXJ7M2iavsksl0rbXDIXwV0U1CFBYDHtx4Ob+
         Tdh+dgxoFdbO7Eepu5IQ84kpUqnEiiwP0znB4dCmf3sej9RoOD319oqboiu8daAGsDeT
         brNw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:subject:cc:to:from:date:arc-authentication-results;
        bh=3rdZmobBHoZguKCe4SEKa2swie6bM9Xqe+O7oeDAY6g=;
        b=dJ7ysyFCMhnJ+HJNXSFoaxnYvLWPXogFOokJYQPM3Y5fDJjNN1oZ+CYwU3J3YDPL9I
         o8RgEeBEE5QloNlQSFYHJg9/Rx1p92YBk560ss4mpvQxGXLEXq12pcH7zhDmUiY10dQE
         b6LQoKCnKlEyXqs6h5IQHlpWdLbvScK1+bYVnq4uzmFfi5+eJCTQ0/9i/iLR3rwUqWjY
         LY+HYOxdRppmAlFaMN9CfjQep8EHYQ3+5WuqOD0rqfQcSPnKgVfiqtbNXfzYnF7mImJZ
         iCxulZ03Cd+2I3cENL+eMNv3OGo6NpWmcFl9W+YexgOdzqYpS7sEe8n1MrFZJrnIQ1Ct
         c7fw==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com
Return-Path: <henning.schild@siemens.com>
Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])
        by gmr-mx.google.com with ESMTPS id k9-v6si17693wri.5.2018.04.27.04.06.50
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Fri, 27 Apr 2018 04:06:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com
Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14])
	by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w3RB6n5u024770
	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
	Fri, 27 Apr 2018 13:06:50 +0200
Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40])
	by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w3RB6nIa019586;
	Fri, 27 Apr 2018 13:06:49 +0200
Date: Fri, 27 Apr 2018 13:06:49 +0200
From: Henning Schild <henning.schild@siemens.com>
To: Alexander Smirnov <asmirnov@ilbers.de>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/2] start_vm: Fix quotes usage
Message-ID: <20180427130649.5ce34aa1@md1pvb1c.ad001.siemens.net>
In-Reply-To: <20180427102853.5454-2-asmirnov@ilbers.de>
References: <20180427102853.5454-1-asmirnov@ilbers.de>
	<20180427102853.5454-2-asmirnov@ilbers.de>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-TUID: gGIHVUSX3z+n

Am Fri, 27 Apr 2018 13:28:52 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> According to the following chapter:
> 
> http://wiki.bash-hackers.org/syntax/quoting#quotes_and_escaping
> 
>   MYARG="\"my multiword argument\""
>   somecommand $MYARG
> 
> is NOT the same as:
> 
>   command "my multiword argument"
> 
> So this patch splits kernel params to separate variable for correct
> interpretation.
> 
> Tested with bash and dash in Debian jessie.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  scripts/start_vm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/start_vm b/scripts/start_vm
> index cfb2bea..7eb633e 100755
> --- a/scripts/start_vm
> +++ b/scripts/start_vm
> @@ -28,6 +28,7 @@ start_qemu() {
>  	$QCPU \
>  	-nographic \
>  	$EXTRA_ARGS \
> +        "$KARGS" \

How about?
 -append "$KARGS"

>  	$root
>      [ $had_x -eq 0 ] && set +x
>  }
> @@ -123,7 +124,8 @@ case "$IMAGE_TYPE" in
>      EXTRA_ARGS="$EXTRA_ARGS \
>  	-kernel $QKERNEL \
>  	-initrd $QINITRD \
> -	-append \"console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw\""
> +	-append "

Where are the closing quotes?

Henning

> +    KARGS="console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw"
>      ;;
>      wic-img)
>      readonly
> ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.wic.img