From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6549073309689970688 X-Received: by 2002:a19:914b:: with SMTP id y11-v6mr132527lfj.15.1524839895404; Fri, 27 Apr 2018 07:38:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:635a:: with SMTP id x87-v6ls211765ljb.6.gmail; Fri, 27 Apr 2018 07:38:14 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpp/w6MAuKig+pg4G0dLqU1B82l95Rf/NEiSWaJxTnUqC+3GwnsoGFMBiYnayPf2nfpe/dw X-Received: by 2002:a2e:9d08:: with SMTP id t8-v6mr137066lji.13.1524839894677; Fri, 27 Apr 2018 07:38:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1524839894; cv=none; d=google.com; s=arc-20160816; b=KBEthngnKJc+e2GdLvttHrWeXK5O4KWHLR7j08Spox4rrKVfXmxRvCueObUllpFONF kLbVV0PIuw2kdkkiw/f2qupnFRfKV2BSQc2tk59X9hTrJysXahhqoUcafrc6LYLBDHL+ FqPNumTx/XVbdQfrf3jiiuBSLky4Oz/I+pgPlo8CsyJSLRRmQCyLzjq1BGWUBCjVARHO bDevYnnBfib69uqCsKHiXIaycviVBFEzLyYqJnJMV/Qz5iw9PjxqNbpfLXv+1IzQsp1L zUBl903KKjQkeajGMXFZtOXrUmieB/N2WwcTnxhOyacbmY+j7OVW1JjLOPM8I4os/4fS 1EqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=BiaJ6bc9slu0MV2YMebk1Wrxdia+0j8/OD0Tag4H8l8=; b=dcFyGfNxZ1/xp7BAK4bkROcxXC2wbx767JKuO4Vjw2D44GbrKLTSgi25/SC1G4K8n7 v+utkTtfaqHONeHIvSnLHoClM/oiBNH/0TSK3T1b8ipiNkwxPm7mXvrW5Y8YVUZrTVsw oBYYzq/mK3lEsdYu/P1zBTzKEHcaDEcmT+oBOOBryLQIRzp34QpolErWygmqJIXPZj7y qPpNyaGz5HQ7O/yj9Gm78LFxtB0RQJ5xZ+z1UD1qCn28T7NAQwtkXhtG1ygPMy2M7EV4 SznHIEHPzvYgWWDHsJUbqBMd13DMgxulm60YtR2+4aCbcL1M6z3d/qZdfPWXq74fO5eF fH/A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id h12-v6si57894ljg.2.2018.04.27.07.38.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Apr 2018 07:38:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from localhost.localdomain ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w3REc0d7031913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Apr 2018 16:38:06 +0200 From: Alexander Smirnov To: isar-users@googlegroups.com Cc: Alexander Smirnov Subject: [PATCH v2 1/2] start_vm: Fix quotes usage Date: Fri, 27 Apr 2018 17:37:52 +0300 Message-Id: <20180427143752.7032-1-asmirnov@ilbers.de> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20180427102853.5454-2-asmirnov@ilbers.de> References: <20180427102853.5454-2-asmirnov@ilbers.de> X-TUID: pwlGjatAUPrR According to the following chapter: http://wiki.bash-hackers.org/syntax/quoting#quotes_and_escaping MYARG="\"my multiword argument\"" somecommand $MYARG is NOT the same as: command "my multiword argument" So this patch splits kernel params to separate variable for correct interpretation. Tested with bash and dash in Debian jessie. Signed-off-by: Alexander Smirnov --- scripts/start_vm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/start_vm b/scripts/start_vm index cfb2bea..19b6b20 100755 --- a/scripts/start_vm +++ b/scripts/start_vm @@ -28,6 +28,7 @@ start_qemu() { $QCPU \ -nographic \ $EXTRA_ARGS \ + -append "$KARGS" \ $root [ $had_x -eq 0 ] && set +x } @@ -122,8 +123,8 @@ case "$IMAGE_TYPE" in [ -n "$INITRD_IMAGE" ] && QINITRD=$IMAGE_DIR/${INITRD_IMAGE} EXTRA_ARGS="$EXTRA_ARGS \ -kernel $QKERNEL \ - -initrd $QINITRD \ - -append \"console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw\"" + -initrd $QINITRD" + KARGS="console=$MACHINE_SERIAL root=/dev/$ROOTFS_DEV rw" ;; wic-img) readonly ROOTFS_IMAGE=isar-image-base-debian-$DISTRO-qemu$ARCH.wic.img -- 2.9.5