Re: [PATCH 2/3] scripts/vm_smoke_test: Check if QEMU didn't start

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 1 May 2018 20:55:10 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Add check for QEMU start and display error message if it didn't start.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  scripts/vm_smoke_test | 31 +++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 10 deletions(-)
> 
> diff --git a/scripts/vm_smoke_test b/scripts/vm_smoke_test
> index 92fda2d..006ab53 100755
> --- a/scripts/vm_smoke_test
> +++ b/scripts/vm_smoke_test
> @@ -57,21 +57,32 @@ run_test () {
>  
>      # Start QEMU with Isar image
>      start_vm -a $ARCH -d $DISTRO -o $CONSOLE_OUTPUT -p $PID_FILE
> > /dev/null 2>&1 &
> -    sleep 60
> -    kill `cat $PID_FILE`
> +    sleep 5
>  
> -    FAIL=0
> +    if [ -z `ps -p $! -o pid=` ]; then

[ -d /proc/$! ]

> +        echo "QEMU start: FAILED"
> +        RET=$ES_FAIL
> +        echo "Command output:\n8<--"
> +        start_vm -a $ARCH -d $DISTRO -o $CONSOLE_OUTPUT -p $PID_FILE
> +        echo "\n8<--"
> +    else
> +        sleep 60
> +        kill `cat $PID_FILE`
> +
> +        FAIL=0
>  
> -    # Check login prompt
> -    check_login_prompt
> +        # Check login prompt
> +        check_login_prompt

i think the function name says all there is to say
 
> -    # Check kernel module
> -    check_example_module
> +        # Check kernel module
> +        check_example_module

same here

Henning

> -    [ $VERBOSE -eq 1 -o $FAIL -eq 1 ] && dump_boot_log
> +        [ $VERBOSE -eq 1 -o $FAIL -eq 1 ] && dump_boot_log
> +
> +        # Clean up test artifacts
> +        rm $CONSOLE_OUTPUT
> +    fi
>  
> -    # Clean up test artifacts
> -    rm $CONSOLE_OUTPUT
>      rm $PID_FILE
>  }
>