From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6550672688539500544 X-Received: by 2002:a2e:94c7:: with SMTP id r7-v6mr684770ljh.11.1525250217083; Wed, 02 May 2018 01:36:57 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:8781:: with SMTP id n1-v6ls1216109lji.0.gmail; Wed, 02 May 2018 01:36:56 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp0VaX2EEvcyFNJq+WQe9QmpC0BN1n7s80TG0HDHY0JIJzt0jVATEZ3JlBqLthRHAPbgt3G X-Received: by 2002:a2e:9355:: with SMTP id m21-v6mr522041ljh.28.1525250216625; Wed, 02 May 2018 01:36:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525250216; cv=none; d=google.com; s=arc-20160816; b=z8A1RGbTq0nO2TwB2FWQv/u3lFIe/9kFr5lh9xcMQztoeGa3A3/G8ozspcn/U5buL8 QsdH3/9XCFmOUFjCYThvPK1zDq5YEWUCK9ceUQDksLgcxIaUsW6bSss9t1bZHNoicAvI zGh2cMUDVVYQPR65TqmjBe+3h7nhxeGP/OFG2mbcBMKmUUag6PeZukwjw/e5YTWG2DO6 mqwYNdFAwqF9Dlb7uFB+k7zdKXKekUxyMXNSZokLPIC4z3Xqrw3PccgWN+M0H3j7e7p/ eHWJ06thudvWRTb3rpY6mx5u9Xga3Nt/zEFrrTbklqnmJUbitdWX+n1HHPtA2MY8dnHq mNgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=mdaFYCfFJVe3gwF6pMY52t02L7xkjtdpoain/v1m+Lw=; b=NoixbwG8vbQao+c3RabN6n1H6NYBNl7YdsxJbvINy0rBoItYV5fihskQG5SVxhVoCz qfQH8lk0Jw3y33jEF+NARBklvFVkc53epVmJK+5HKW6KYNp4YCbpjaPRInZikVBpMcbd ZvDURjiH+YnV/lHwpNiORxdRs3hFjBipV36+weXE521wm2MlXFPU/KgW3C9fsgvjQGXb Y+XN3g39WS89G5Y2VteuyOpWUHHWhCH3vAq1bZVrSDFWj/fGjPz3Iqrp6Fj9qGKDGBrS mHNppO8UZ2X/wmf8vNTLWxBKbEdoZiqlcng81GV1euSe4v3mdhltMWSXP1qtjKW4IhTg bnQA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id e1-v6si379612ljk.0.2018.05.02.01.36.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 May 2018 01:36:56 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w428ate7016891 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 May 2018 10:36:55 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w428atNS001648; Wed, 2 May 2018 10:36:55 +0200 Date: Wed, 2 May 2018 10:36:55 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH 2/3] scripts/vm_smoke_test: Check if QEMU didn't start Message-ID: <20180502103655.7eca8bf2@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180501175511.26145-3-asmirnov@ilbers.de> References: <20180501175511.26145-1-asmirnov@ilbers.de> <20180501175511.26145-3-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: od0y+JpLbJ7p Am Tue, 1 May 2018 20:55:10 +0300 schrieb Alexander Smirnov : > Add check for QEMU start and display error message if it didn't start. > > Signed-off-by: Alexander Smirnov > --- > scripts/vm_smoke_test | 31 +++++++++++++++++++++---------- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/scripts/vm_smoke_test b/scripts/vm_smoke_test > index 92fda2d..006ab53 100755 > --- a/scripts/vm_smoke_test > +++ b/scripts/vm_smoke_test > @@ -57,21 +57,32 @@ run_test () { > > # Start QEMU with Isar image > start_vm -a $ARCH -d $DISTRO -o $CONSOLE_OUTPUT -p $PID_FILE > > /dev/null 2>&1 & > - sleep 60 > - kill `cat $PID_FILE` > + sleep 5 > > - FAIL=0 > + if [ -z `ps -p $! -o pid=` ]; then [ -d /proc/$! ] > + echo "QEMU start: FAILED" > + RET=$ES_FAIL > + echo "Command output:\n8<--" > + start_vm -a $ARCH -d $DISTRO -o $CONSOLE_OUTPUT -p $PID_FILE > + echo "\n8<--" > + else > + sleep 60 > + kill `cat $PID_FILE` > + > + FAIL=0 > > - # Check login prompt > - check_login_prompt > + # Check login prompt > + check_login_prompt i think the function name says all there is to say > - # Check kernel module > - check_example_module > + # Check kernel module > + check_example_module same here Henning > - [ $VERBOSE -eq 1 -o $FAIL -eq 1 ] && dump_boot_log > + [ $VERBOSE -eq 1 -o $FAIL -eq 1 ] && dump_boot_log > + > + # Clean up test artifacts > + rm $CONSOLE_OUTPUT > + fi > > - # Clean up test artifacts > - rm $CONSOLE_OUTPUT > rm $PID_FILE > } >