From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543570718688280576 X-Received: by 2002:a2e:2419:: with SMTP id k25-v6mr1424845ljk.40.1525364832980; Thu, 03 May 2018 09:27:12 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:5712:: with SMTP id l18-v6ls1471138lfb.11.gmail; Thu, 03 May 2018 09:27:12 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpHZTEPQcA7fzJ+9RKTAwL0894PIA/DUfmdM8F2ek8sWWnrKEq9Ttwmt/AqWs6FiZ+72c+r X-Received: by 2002:a19:d7cc:: with SMTP id q73-v6mr1329393lfi.8.1525364832292; Thu, 03 May 2018 09:27:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525364832; cv=none; d=google.com; s=arc-20160816; b=gQUzoA4JCqckpTpsI9RBiAcrEs/1conVTsipww8EuU0T14I6H5mR+tkxyqf9fgvHdh O6oYAMgTMNyA/ph4GoUl1pXG4ZWpQUbNORfZK14GJX4RyOgClbHuTow/pJmpZ7CG/Qvp Vtv0lRtisZxsNoSL09BVTSjqp4mSeTHGyFV386BjzaoqL8jCCB5L90Wd9BYj1/6ar4Qn VG0PhUkSvrKs2sRt56QPUv7Eqp6Y+/I9JOU9waRt8j3Gk1GSdl4lUZQWamoM//l41Qpq rREzK6ZpFYo0KcTQXe9IdPm98xK6X49BZY65sTF3OOrVubHlB6bffAjG714lcxjj+s0T WVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=mmfmW7PNoJSJ7+fhot4OnA/M69zyQ5CLmcX7VcBnlYQ=; b=ZxZ6a0S97OPzkO4Vy2OL2dWwiLkWBggyDWuGGjASNdXA8VBIpbGr3p35+TzwyoGOZY WenfocrNzj8z/OYtwE8eNERlpYhspCPk0ylVgvpbYhBlN1gz0SlwkRVHNRyMPV2JTfEM w35O4o6ubj7TLWiz15F6AKVuPeNTR7sLzorhobVbGAJ2Qzp2Ch4xwE31OgVUQcjV26Kx F7Cd8uI1Y3xy+SEOGf1LSOsD2HT64Lol3NpHo9UydjrYVkIpLSNmx+vLWBQ85fM2N4qe DxFWl7QjJKs68+fIbbfJhNZ7nnCwzUbvh27Zjmg13/bNEKYi7xENltEGoE5/7AmDRI86 hlGA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i130-v6si384383lfi.5.2018.05.03.09.27.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 09:27:12 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w43GRAn7008172 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 May 2018 18:27:11 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w43GRASX032078; Thu, 3 May 2018 18:27:10 +0200 Date: Thu, 3 May 2018 18:27:09 +0200 From: Henning Schild To: Alexander Smirnov Cc: , Baurzhan Ismagulov , Claudius Heine Subject: Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional Message-ID: <20180503182709.44044eeb@md1pvb1c.ad001.siemens.net> In-Reply-To: <41086dec-f797-faa1-8b8b-6fdeaf83f211@ilbers.de> References: <20180412143614.31202-1-claudius.heine.ext@siemens.com> <20180412143614.31202-2-claudius.heine.ext@siemens.com> <20180413103820.GC6488@yssyq.radix50.net> <20180503175819.15695d54@md1pvb1c.ad001.siemens.net> <41086dec-f797-faa1-8b8b-6fdeaf83f211@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: EU0uSwoxqVLf Am Thu, 3 May 2018 19:18:42 +0300 schrieb Alexander Smirnov : > On 05/03/2018 06:58 PM, Henning Schild wrote: > > Am Fri, 13 Apr 2018 12:38:20 +0200 > > schrieb Baurzhan Ismagulov : > > > >> On Thu, Apr 12, 2018 at 04:36:14PM +0200, > >> claudius.heine.ext@siemens.com wrote: > >>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb > >>> b/meta-isar/recipes-core/images/isar-image-base.bb index > >>> 6b0030b..d39a25e 100644 --- > >>> a/meta-isar/recipes-core/images/isar-image-base.bb +++ > >>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7 > >>> @@ PV = "1.0" inherit image > >>> inherit isar-bootstrap-helper > >>> > >>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}" > >>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", > >>> True)) if d.getVar("KERNEL_NAME", True) else ""}" > >> > >> If I want to generate an NFS rootfs w/o the kernel and an SD image > >> with one, how would I proceed? Do I understand correctly, the > >> latter recipe would list this line, and the former would not? > > > > I think the answer would be with two image recipes that > > inherit/override each other. So the main one that is probably > > derived from isar-image-base and would be called product-nfs.bb and > > product-wic.bb would overwrite some variables from the -nfs version. > > > > That patch should be merged, i already heard from someone else who > > now cherry-picked that into their fork. > > Started test build, will apply afterwards. > > But, I've looked at this patch again, and I think that this line > should go to image class instead of recipe, it's already generic > enough. Otherwise you have to copy this magic expression to every new > image recipe (if you not inherit isar-image-base). Ok, i just wanted to vote for the cause, not the implementation. Henning > Alex >