From: Henning Schild <henning.schild@siemens.com>
To: <isar-users@googlegroups.com>
Cc: Claudius Heine <claudius.heine.ext@siemens.com>,
Alexander Smirnov <asmirnov@ilbers.de>
Subject: Re: [PATCH] meta: wic-img: correct variable IMAGE_BASENAME
Date: Thu, 3 May 2018 19:00:17 +0200 [thread overview]
Message-ID: <20180503190017.5eefd7fc@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <20180503165920.3130-1-henning.schild@siemens.com>
This is the fixup on top of the wic-series, as requested by Alex.
Henning
Am Thu, 3 May 2018 18:59:20 +0200
schrieb Henning Schild <henning.schild@siemens.com>:
> As discovered during review, the variable is set incorrectly. It
> contained too much information and used an unusual format. This commit
> corrects that.
>
> Reported-by: Claudius Heine <claudius.heine.ext@siemens.com>
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
> meta/classes/wic-img.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/wic-img.bbclass
> b/meta/classes/wic-img.bbclass index d1deff3..d2ba36c 100644
> --- a/meta/classes/wic-img.bbclass
> +++ b/meta/classes/wic-img.bbclass
> @@ -10,7 +10,7 @@ ROOTFS_TYPE ?= "ext4"
> STAGING_DATADIR ?= "/usr/lib/"
> STAGING_LIBDIR ?= "/usr/lib/"
> STAGING_DIR ?= "${TMPDIR}"
> -IMAGE_BASENAME ?= "multiconfig:${MACHINE}-${DISTRO}:${PN}"
> +IMAGE_BASENAME ?= "${PN}-${DISTRO}"
> FAKEROOTCMD ?= "${ISARROOT}/scripts/wic_fakeroot"
> RECIPE_SYSROOT_NATIVE ?= "/"
>
next prev parent reply other threads:[~2018-05-03 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 16:59 Henning Schild
2018-05-03 17:00 ` Henning Schild [this message]
2018-05-03 18:50 ` Alexander Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503190017.5eefd7fc@md1pvb1c.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=asmirnov@ilbers.de \
--cc=claudius.heine.ext@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox