From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6551400364229263360 X-Received: by 10.28.13.141 with SMTP id 135mr1846224wmn.10.1525366819831; Thu, 03 May 2018 10:00:19 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:d60b:: with SMTP id n11-v6ls442896wmg.5.canary-gmail; Thu, 03 May 2018 10:00:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZrZ5xe6ujjnUZPYzU+mKAcpIURv7L6d82yk7nZK2Hu3e+0+mPDvPtQZKtNwpqGZXgDzbzA/ X-Received: by 10.28.249.13 with SMTP id x13mr2065525wmh.24.1525366819393; Thu, 03 May 2018 10:00:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525366819; cv=none; d=google.com; s=arc-20160816; b=Y74VwXkx3wBtCD+ypfj9qEok/vqSKgZsxj2X4i9uSh02cVpO5N8DIaFMio2KG9C6R6 dkcfWaWRnzpLTxdcg3z8wUBeG1yTdRWhJdjcWFRMo+HnSN6wGUuu4Efkz8EsQszkV2gk JZz8LISju9GRL6SmFnIiiSO2lQElxQZw/lYU2sG4u4EhwRIoDP7STPyNTHsNecAVlJ0e k7yqnexhOuwx+SPhI+HGu9GgAuOhDz3Mz9rl1Lszij2yNdhVMiqYU/jYuNhFQDJshqeM mH7mz2pCDpEKQFQaBMz/S0rbCsZ9RXQ4ub6LeSIKK8Jepy4yN2Ho2NAizGtUAVfjQnUw qy6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=PA3l69zrjDDD4fMpx+KIHPNgUpYujA+zd8nPewsi7iU=; b=fxjr6i63WsNb3/14TsbuAtz9npY0Hhnnj+MJ9A7/QRa6n1i52FSYibPA+TyvoMij+h 2oqBut9fGcsFKGY62rv8rbimRmKBivqFb4P7yq7uqUiCA/9FJamGpZD5d2sK5yJHxwoC a8FHAujjvOzqa41IIGcBQWz1XIkIDaua0qfaLr1QXeVdn9TUQbPc84kKi59YHN7fUro9 cBIE+qbg2pCP0zFDTsvvwdhaDzDP2Nk6dLsghGhPnktpKBcK+clQvTto4eH9WHP2gkPu EdTgK7g/MDZOIeh99Bmr5ND/Z9uxYK/1hE97EB12uh/aSZDI/s9+J9G/uR3pTRRkWPCB vVfg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id i18-v6si178445wrh.0.2018.05.03.10.00.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 10:00:19 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.siemens.de (mail1.siemens.de [139.23.33.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w43H0IVe019719 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 3 May 2018 19:00:19 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail1.siemens.de (8.15.2/8.15.2) with ESMTP id w43H0I8a032456; Thu, 3 May 2018 19:00:18 +0200 Date: Thu, 3 May 2018 19:00:17 +0200 From: Henning Schild To: Cc: Claudius Heine , Alexander Smirnov Subject: Re: [PATCH] meta: wic-img: correct variable IMAGE_BASENAME Message-ID: <20180503190017.5eefd7fc@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180503165920.3130-1-henning.schild@siemens.com> References: <20180503165920.3130-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: aSwzdBQOXeCK This is the fixup on top of the wic-series, as requested by Alex. Henning Am Thu, 3 May 2018 18:59:20 +0200 schrieb Henning Schild : > As discovered during review, the variable is set incorrectly. It > contained too much information and used an unusual format. This commit > corrects that. > > Reported-by: Claudius Heine > Signed-off-by: Henning Schild > --- > meta/classes/wic-img.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/wic-img.bbclass > b/meta/classes/wic-img.bbclass index d1deff3..d2ba36c 100644 > --- a/meta/classes/wic-img.bbclass > +++ b/meta/classes/wic-img.bbclass > @@ -10,7 +10,7 @@ ROOTFS_TYPE ?= "ext4" > STAGING_DATADIR ?= "/usr/lib/" > STAGING_LIBDIR ?= "/usr/lib/" > STAGING_DIR ?= "${TMPDIR}" > -IMAGE_BASENAME ?= "multiconfig:${MACHINE}-${DISTRO}:${PN}" > +IMAGE_BASENAME ?= "${PN}-${DISTRO}" > FAKEROOTCMD ?= "${ISARROOT}/scripts/wic_fakeroot" > RECIPE_SYSROOT_NATIVE ?= "/" >