From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543937367387930624 X-Received: by 2002:a50:8e14:: with SMTP id 20-v6mr8424269edw.3.1525421793611; Fri, 04 May 2018 01:16:33 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:cb49:: with SMTP id h9-v6ls9787618edi.4.gmail; Fri, 04 May 2018 01:16:33 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr6Prcp6DywmmlLz76L5rlsyLXfXC06RkvOW79zEn2WmNo/kKUQWQvw0Smb0uld9elW5i0R X-Received: by 2002:aa7:c516:: with SMTP id o22-v6mr5416663edq.6.1525421793181; Fri, 04 May 2018 01:16:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525421793; cv=none; d=google.com; s=arc-20160816; b=isRpZrUjO/tqpyRCmvoiU9wLosffnh6tMVDM5fxd74VyuUzA5NsRwx785T+QOg6Vun nqRA50RizlzYjRodBpauWvaAM9p5/ikiX9D1FAp2axV1QMCKjzF3689MIh/D6tfyTD6r 5HsVcRsUWriVI/iWvcx0hzktG30aqswBI2222xEVGy7H15rGcPd9Sm1warMSuZRr+/xO wb+O8g0x3agry1curI1Ia+OWwABZHjmnpuCcLf4Ascf75gtMqSMejZmIEaZRNGUnWHZ2 pOMtkU/rEpIFzQPV8z7DxN4xKrVPLwR/FkvtTOPJaQSwjzYyGKcmnwggrURVpfiQtckw JztQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=VfJNbGWk4SCwfG/LNg1UdAEhnwIN8iMTSZ4ruwTkm2A=; b=C866EpCIkoAGSc2DAedgVNqNm1FBCJI6UDox3OAfP25WmJ1BEUSMGMDeaLaYfbOR4Z iCF49yE9PDbOI550sfJO36u49MPcWdaSVblRPovcdlQpna+I+dDcRjJBAVGxGmRmvi/A JzL2DTafjSgTT0QlGARwoNtha0Lbnn6oYnYII2DLReFJJQVSVxsSa66sjfC8gWKDpDVh cWSWkiz5EQ1BkVaum4U1yqzoGOjnOk8FZimEnA6S48QXsZ9mmKDRVdqXcYvTHtREOWA4 SnW3dI5+vgn2Xss9EsZTmiwOp1lwq23/8d9D3TSkuj+5sQfpPZ1d+7vFeHLf5fAnOpcK 5s1Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id u9-v6si659165edp.3.2018.05.04.01.16.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 01:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w448GWNO011366 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 May 2018 10:16:32 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w448GWYZ013858; Fri, 4 May 2018 10:16:32 +0200 Date: Fri, 4 May 2018 10:16:31 +0200 From: Henning Schild To: Alexander Smirnov Cc: , Claudius Heine Subject: Re: [PATCH v2 00/16] wic integration Message-ID: <20180504101631.2d373e08@md1pvb1c.ad001.siemens.net> In-Reply-To: References: <87bf460d-034c-d3ec-3027-2698f728ca17@ilbers.de> <20180503183244.68403f81@md1pvb1c.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: eY/tvh6k06Tz Am Thu, 3 May 2018 19:39:39 +0300 schrieb Alexander Smirnov : > On 05/03/2018 07:32 PM, Henning Schild wrote: > > Am Tue, 1 May 2018 22:23:01 +0300 > > schrieb Alexander Smirnov : > > > >> On 04/13/2018 05:18 PM, Henning Schild wrote: > >>> This series does the follow things: > >>> > >>> 1. revert all changes that where made to wic so Isar uses an > >>> unmodified version of it > >>> 2. Introdcue an image-class that will create wic images > >>> automatically 3. enable testing that in CI > >>> 4. update docs > >>> > >>> Patches 1 to 7 just deal with getting back to an unmodified > >>> version of wic. > >>> Patch 11 - the big one - provides the real functionality. > >>> > >>> I will provide some more information on what is going on here by > >>> replying to p11. > >>> > >>> Major changes to the first series: > >>> - rebase on recent Isar > >>> - wic is now running in buildchroot, as root > >>> - calling wic manually not supported any longer > >>> - distros before stretch are not supported either (see p11 > >>> discussion for why) > >>> - CI can now test wic for the first time > >> > >> Applied to next, thanks! > > > > Thank you. I have one outstanding change i wanted to squash with > > p11, originated from a review from Claudius. Should that get > > squashed or go on top? > > https://github.com/henning-schild-work/isar/commit/75bbea59fe2e4174f4eaf0f782792d208672fad6 > > > > I'd prefer on top, could you please send this patch on the list? And now i remember another "open" point. Claudius suggested to split the forking of the plugins into two steps. One that just copies them, and a second to apply the Isar-specific changes. That would make it easier to see what needed to change to make them work under Isar, which could become increasingly interesting when we version-bump our wic some day. I could do that on top as well, sort of two no-op patches. But in this case a rebase would probably be the better option. Or we do not do that at all. How would you like to proceed? Henning > Alex