From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543937367387930624 X-Received: by 2002:a2e:320d:: with SMTP id y13-v6mr1418481ljy.42.1525427496159; Fri, 04 May 2018 02:51:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:f608:: with SMTP id x8-v6ls1653029lfe.15.gmail; Fri, 04 May 2018 02:51:35 -0700 (PDT) X-Google-Smtp-Source: AB8JxZr8TNRugD+9nNfYVqm+IdXi+8lwVJmRI99BQUcSLBuIytImjC30QVpL8XrYNB3qpA0jCzXB X-Received: by 2002:a19:1a51:: with SMTP id a78-v6mr1567815lfa.17.1525427495823; Fri, 04 May 2018 02:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525427495; cv=none; d=google.com; s=arc-20160816; b=vYD04Zb/tPeCnYEgunSrKRgV+BWwLOrBxqOLZKrjFEcJ4dFStRAyGlLuVlmSNqUTDl +udJm1yMkGAnFUeSz85Xx5vNl/6gXZbZ/gG2Edg+fqfPD8kTTXlmwl0mfomcQkQ3JRq7 Gv92nmwyCmrzaXo0F5WJ6f98Wwb9GIsQNzEQppdpsYNJmDgn/0YuLf9uhnkno4ByUpMQ QYoTFXkBjHxoKyAggoqcMKuLa04dmIUnUjVZh3h7S+4b9/PrEQW1+RoeDZC+7ojuZwFj xlBHXTR9BRnjjR+Szewl0xsDo1+tFbv2sHww0nJpYt1Pj3lKpFMlltjSG4xkEalETsMS DCYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=S8HP7NKL29p4Mt6hqMas3gi2G7gs/onA9q/LGW+dfUo=; b=jbks8cJI9HvYXS6T39lF+lwPMKAThO61kuA2paWxgkuCNfe/jpjd+qX362JrV0nFpK E3LpGfHJYnxrMWhkBxpfFVMEQRZvNxy/bwrfvq5Ke6bhAtKJLaq7MbOVOfkAir9L19G9 xO2mkdcoT0OEAhoE7W6ZDhEFtH6KQWFbHgfKkUK8U6jjXsVtMlCF15L7KvLUChhdjJZ5 TVUVxUqg+n/JiDJu97CZh3WCDZaWc5GIXObMiEARIRA2UZ1jkJ25E9BYJkpf1OdEXuCV HKum700iDbEtoA/DTkBI+b+8p/QDS2f2rYWbjbX3vMYw2NyvLvRUptPFauBCxC4CNbs7 SA1w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id e1-v6si522415ljk.0.2018.05.04.02.51.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 02:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w449pBcf020579 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 4 May 2018 11:51:35 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w449UkUg002585; Fri, 4 May 2018 11:30:46 +0200 Date: Fri, 4 May 2018 11:30:46 +0200 From: Henning Schild To: Alexander Smirnov Cc: , Claudius Heine Subject: Re: [PATCH v2 00/16] wic integration Message-ID: <20180504113046.613854d0@md1pvb1c.ad001.siemens.net> In-Reply-To: References: <87bf460d-034c-d3ec-3027-2698f728ca17@ilbers.de> <20180503183244.68403f81@md1pvb1c.ad001.siemens.net> <20180504101631.2d373e08@md1pvb1c.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: vm8jJmajZ22O Am Fri, 4 May 2018 11:32:20 +0300 schrieb Alexander Smirnov : > Hi, > > On 05/04/2018 11:16 AM, Henning Schild wrote: > > Am Thu, 3 May 2018 19:39:39 +0300 > > schrieb Alexander Smirnov : > > > >> On 05/03/2018 07:32 PM, Henning Schild wrote: > >>> Am Tue, 1 May 2018 22:23:01 +0300 > >>> schrieb Alexander Smirnov : > >>> > >>>> On 04/13/2018 05:18 PM, Henning Schild wrote: > >>>>> This series does the follow things: > >>>>> > >>>>> 1. revert all changes that where made to wic so Isar uses an > >>>>> unmodified version of it > >>>>> 2. Introdcue an image-class that will create wic images > >>>>> automatically 3. enable testing that in CI > >>>>> 4. update docs > >>>>> > >>>>> Patches 1 to 7 just deal with getting back to an unmodified > >>>>> version of wic. > >>>>> Patch 11 - the big one - provides the real functionality. > >>>>> > >>>>> I will provide some more information on what is going on here by > >>>>> replying to p11. > >>>>> > >>>>> Major changes to the first series: > >>>>> - rebase on recent Isar > >>>>> - wic is now running in buildchroot, as root > >>>>> - calling wic manually not supported any longer > >>>>> - distros before stretch are not supported either (see p11 > >>>>> discussion for why) > >>>>> - CI can now test wic for the first time > >>>> > >>>> Applied to next, thanks! > >>> > >>> Thank you. I have one outstanding change i wanted to squash with > >>> p11, originated from a review from Claudius. Should that get > >>> squashed or go on top? > >>> https://github.com/henning-schild-work/isar/commit/75bbea59fe2e4174f4eaf0f782792d208672fad6 > >>> > >> > >> I'd prefer on top, could you please send this patch on the list? > > > > And now i remember another "open" point. Claudius suggested to split > > the forking of the plugins into two steps. One that just copies > > them, and a second to apply the Isar-specific changes. > > That would make it easier to see what needed to change to make them > > work under Isar, which could become increasingly interesting when we > > version-bump our wic some day. > > > > I could do that on top as well, sort of two no-op patches. But in > > this case a rebase would probably be the better option. Or we do > > not do that at all. How would you like to proceed? > > > > If you specify the commit to drop and provide two patches, I could > force the history. > > But in general I'd prefer updates-on-top, because this way has lower > probability of mistake. I know that current head is fully functional > and incrementally tested. If something is updated in the middle of > history - I have to check that this doesn't corrupt patches above. I just sent two patches on top. Applying both is a no-op and they might help understand what is Isar-specific in the forked files. Henning > Alex