Re: [PATCH] wic-img.bbclass: Do not reset WICVARS

[Henning Schild <henning.schild@siemens.com>]

Looks good!

Am Tue, 15 May 2018 15:44:02 +0200
schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:

> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> In case WICVARS are extended in local.conf, wic-img.bbclass must
> not use ?= operator, but += operator to set WICVARS, otherwise a
> user can never add variables in local.conf.
> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> ---
>  meta/classes/wic-img.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/wic-img.bbclass
> b/meta/classes/wic-img.bbclass index d2ba36c..07c2a9e 100644
> --- a/meta/classes/wic-img.bbclass
> +++ b/meta/classes/wic-img.bbclass
> @@ -18,7 +18,7 @@ do_wic_image[stamp-extra-info] =
> "${DISTRO}-${MACHINE}" 
>  WIC_CREATE_EXTRA_ARGS ?= ""
>  
> -WICVARS ?= "\
> +WICVARS += "\
>             BBLAYERS IMGDEPLOYDIR DEPLOY_DIR_IMAGE FAKEROOTCMD
> IMAGE_BASENAME IMAGE_BOOT_FILES \ IMAGE_LINK_NAME IMAGE_ROOTFS
> INITRAMFS_FSTYPES INITRD INITRD_LIVE ISODIR RECIPE_SYSROOT_NATIVE \
> ROOTFS_SIZE STAGING_DATADIR STAGING_DIR STAGING_LIBDIR TARGET_SYS
> TRANSLATED_TARGET_ARCH"