From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6555804189874716672 X-Received: by 2002:a50:f291:: with SMTP id f17-v6mr6329241edm.11.1526394216457; Tue, 15 May 2018 07:23:36 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:aa7:d281:: with SMTP id w1-v6ls378336edq.5.gmail; Tue, 15 May 2018 07:23:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqEywvS2PB4KNV3LD7UiXhwx2Z1Rxm+N3xq5ZvV6XxZ0bvAySCySz/48jGPG5fnOc9w03kS X-Received: by 2002:aa7:c516:: with SMTP id o22-v6mr6333262edq.6.1526394216069; Tue, 15 May 2018 07:23:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526394216; cv=none; d=google.com; s=arc-20160816; b=sWlO+KTmSgJDBHkqR3vWPcLnzjJOb/43fE/6lZcd3F0/W2qFDnfJl6fEOka0rFgOAZ CADy9CaT03tbwY3cJrz4/vOn4b68LhXYCV8WNdkUJlynTtgTn8MJ/3ty1ZKG/sYT8Z0S J8z9K1de5liOzc6ICMQDuu7W4xTXLR7TzBrhkdiqvPeweaaIqZZDPh6ne5eFaAG7/ewV +cZvABx0WfDYon98Irff+Uc4HECjnnmqGKEpSPjQvPM91CXcA+ttYIWiS6nS9hrQ5shD mljWPAGqCUOdyom17MRIa8pqeEAjnyBiJbzo+mfXASgYdcL+jnY1C9bLEwJ6R2zmRLUm SCRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=hBC+gyKWa4AN7bCEnQdMB5lktfbJL5HlGhcjwgm1eyo=; b=AmI9Y44zCCmQEO7iUBPvPCfS6PfEVrCvNAe6tJUe2i4m1AvOwK7zEwhbulTJxV3xHZ Nq+eQ3rBeVncjXIk4OpvUne/B2w4Maj9Aet7zR/rozmopL0Ay80b8QRr2Xtw6LuOgZMq 1VcPSTQi853RcI7L/fPLI7u8vATuIa1wnDg/G/VJBVdR+4pmMekz8gVTjGzM02NSlJAb GmmbKKma02Ntowqd75fh+sg1PYI545b5klRF8EaIX+mnrijLTlp6EZghNd5iizQpBcs4 OIkFU2wZM818N48oadvfiS7rUScmzppcAf3HPJdnmF0v8eaK2nka+8lUiRVz//oyyMnv D4Hg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id z2-v6si22238edq.2.2018.05.15.07.23.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 May 2018 07:23:36 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w4FENZRo003530 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 May 2018 16:23:35 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w4FENZYa030139; Tue, 15 May 2018 16:23:35 +0200 Date: Tue, 15 May 2018 16:23:34 +0200 From: Henning Schild To: "[ext] Andreas J. Reichel" Cc: Subject: Re: [PATCH] wic-img.bbclass: Do not reset WICVARS Message-ID: <20180515162334.2dfce51f@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180515134402.14299-1-andreas.reichel.ext@siemens.com> References: <20180515134402.14299-1-andreas.reichel.ext@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: nIO1w1NAniQr Looks good! Am Tue, 15 May 2018 15:44:02 +0200 schrieb "[ext] Andreas J. Reichel" : > From: Andreas Reichel > > In case WICVARS are extended in local.conf, wic-img.bbclass must > not use ?= operator, but += operator to set WICVARS, otherwise a > user can never add variables in local.conf. > > Signed-off-by: Andreas Reichel > --- > meta/classes/wic-img.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/wic-img.bbclass > b/meta/classes/wic-img.bbclass index d2ba36c..07c2a9e 100644 > --- a/meta/classes/wic-img.bbclass > +++ b/meta/classes/wic-img.bbclass > @@ -18,7 +18,7 @@ do_wic_image[stamp-extra-info] = > "${DISTRO}-${MACHINE}" > WIC_CREATE_EXTRA_ARGS ?= "" > > -WICVARS ?= "\ > +WICVARS += "\ > BBLAYERS IMGDEPLOYDIR DEPLOY_DIR_IMAGE FAKEROOTCMD > IMAGE_BASENAME IMAGE_BOOT_FILES \ IMAGE_LINK_NAME IMAGE_ROOTFS > INITRAMFS_FSTYPES INITRD INITRD_LIVE ISODIR RECIPE_SYSROOT_NATIVE \ > ROOTFS_SIZE STAGING_DATADIR STAGING_DIR STAGING_LIBDIR TARGET_SYS > TRANSLATED_TARGET_ARCH"