[PATCH 1/2] vm_smoke_test: Drop wheezy from test

[PATCH 1/2] vm_smoke_test: Drop wheezy from test

[Alexander Smirnov]

Wheezy requires old e2fsprogs (1.42-) installed on the host, otherwise
wheezy kernel won't be able to mount root partition. After each build
host upgrade this becomes more complicated to maintain outdated tool.
So it's time for wheezy to slightly go...

Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
---
 scripts/vm_smoke_test | 1 -
 1 file changed, 1 deletion(-)

diff --git a/scripts/vm_smoke_test b/scripts/vm_smoke_test
index 442b259..1524603 100755
--- a/scripts/vm_smoke_test
+++ b/scripts/vm_smoke_test
@@ -123,7 +123,6 @@ do
 done
 
 # ARM machine
-run_test arm wheezy
 run_test arm jessie
 run_test arm stretch
 
-- 
2.1.4

[PATCH 2/2] vm_smoke_test: Add parameters

[Alexander Smirnov]

Drop hardcoded settings from smoke test script. This provides possibility
to tune it and run on various hosts without script modification.

Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
---
 scripts/vm_smoke_test | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/scripts/vm_smoke_test b/scripts/vm_smoke_test
index 1524603..a88d127 100755
--- a/scripts/vm_smoke_test
+++ b/scripts/vm_smoke_test
@@ -6,6 +6,7 @@
 CONSOLE_OUTPUT=/tmp/isar_console
 PID_FILE=/tmp/qemu.pid
 VERBOSE=1
+TIMEOUT=60
 
 # Error codes:
 ES_OK=0
@@ -65,7 +66,7 @@ run_test () {
         start_vm -a $ARCH -d $DISTRO -o $CONSOLE_OUTPUT -p $PID_FILE
         echo "\n8<--"
     else
-        sleep 60
+        sleep $TIMEOUT
         kill `cat $PID_FILE`
 
         FAIL=0
@@ -89,9 +90,15 @@ show_help() {
     echo "    $0 [params]"
     echo
     echo "Parameters:"
+    echo "    -o,--output FILE      specify file to store console output."
+    echo "                          The default is: /tmp/isar_console"
+    echo "    -p,--pid-file FILE    specify file to store QEMU process PID."
+    echo "                          The default is: /tmp/qemu.pid"
     echo "    -q, --quite           do not display boot logs for all the targets."
     echo "                          If test failed for the specific configuration,"
     echo "                          the respective boot log will be printed anyway."
+    echo "    -t,--timeout SEC      specify time in seconds to wait before stop QEMU."
+    echo "                          The default is: 60"
     echo "    -h, --help            display this message and exit."
     echo
     echo "Exit status:"
@@ -110,9 +117,21 @@ do
         show_help
         exit 0
         ;;
+    -o|--output)
+        CONSOLE_OUTPUT=$2
+        shift
+        ;;
+    -p|--pid-file)
+        PID_FILE=$2
+        shift
+        ;;
     -q|--quite)
         VERBOSE=0
         ;;
+    -t|--timeout)
+        TIMEOUT=$2
+        shift
+        ;;
     *)
         echo "error: invalid parameter '$key', please try '--help' to get list of supported parameters"
         exit $ES_BUG
-- 
2.1.4

Re: [PATCH 1/2] vm_smoke_test: Drop wheezy from test

[Alexander Smirnov]

On 05/11/2018 08:54 PM, Alexander Smirnov wrote:
> Wheezy requires old e2fsprogs (1.42-) installed on the host, otherwise
> wheezy kernel won't be able to mount root partition. After each build
> host upgrade this becomes more complicated to maintain outdated tool.
> So it's time for wheezy to slightly go...
> 

If there are no objections, I'd like to apply this to have CI build 
green. Then I'll be able to eventually release master :-)

Alex

Re: [PATCH 1/2] vm_smoke_test: Drop wheezy from test

[Henning Schild]

Am Mon, 14 May 2018 16:49:14 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 05/11/2018 08:54 PM, Alexander Smirnov wrote:
> > Wheezy requires old e2fsprogs (1.42-) installed on the host,
> > otherwise wheezy kernel won't be able to mount root partition.
> > After each build host upgrade this becomes more complicated to
> > maintain outdated tool. So it's time for wheezy to slightly go...
> >   
> 
> If there are no objections, I'd like to apply this to have CI build 
> green. Then I'll be able to eventually release master :-)

I have no objections to dropping wheezy support. But if doing so the
real change is not removing it from the CI scripts and keeping it
around.
There are configs that need to be removed, docs that need to be updated.
Just "git grep wheezy" and you will find many more referrence than just
CI. We do not have a support matrix, but as long as we have code
hanging around, that suggests that a certain distro is supported ... it
should be working.

Dropping wheezy is a topic that probably deserves its own thread.

Henning

> Alex
> 

Re: [PATCH 1/2] vm_smoke_test: Drop wheezy from test

[Alexander Smirnov]

On 05/14/2018 07:01 PM, Henning Schild wrote:
> Am Mon, 14 May 2018 16:49:14 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> On 05/11/2018 08:54 PM, Alexander Smirnov wrote:
>>> Wheezy requires old e2fsprogs (1.42-) installed on the host,
>>> otherwise wheezy kernel won't be able to mount root partition.
>>> After each build host upgrade this becomes more complicated to
>>> maintain outdated tool. So it's time for wheezy to slightly go...
>>>    
>>
>> If there are no objections, I'd like to apply this to have CI build
>> green. Then I'll be able to eventually release master :-)
> 
> I have no objections to dropping wheezy support. But if doing so the
> real change is not removing it from the CI scripts and keeping it
> around.
> There are configs that need to be removed, docs that need to be updated.
> Just "git grep wheezy" and you will find many more referrence than just
> CI. We do not have a support matrix, but as long as we have code
> hanging around, that suggests that a certain distro is supported ... it
> should be working.
> 

For sure, I understand, that there is multiconfig for wheezy that should 
also go.

> Dropping wheezy is a topic that probably deserves its own thread.

I already planned to discuss wheezy's value after the release (this 
week). But there are two points:

1. There is an issue with ext4 image creation after switching to wic, 
dmesg in QEMU sometimes shows the following error:

8<--
   EXT4-fs (mmcblk0): bad geometry: block count 247892 exceeds size of 
device (247808 blocks)
8<--

This problem is reproduced on wheezy image only. So I want to debug it 
first before completely dropping wheezy, to prevent possible error leaking.

2. I want to have green CI to perform release.

So I propose drop wheezy from CI as the first step to unblock the process.

Alex

Re: [PATCH 1/2] vm_smoke_test: Drop wheezy from test

[Henning Schild]

Am Mon, 14 May 2018 19:15:45 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> On 05/14/2018 07:01 PM, Henning Schild wrote:
> > Am Mon, 14 May 2018 16:49:14 +0300
> > schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> >   
> >> On 05/11/2018 08:54 PM, Alexander Smirnov wrote:  
> >>> Wheezy requires old e2fsprogs (1.42-) installed on the host,
> >>> otherwise wheezy kernel won't be able to mount root partition.
> >>> After each build host upgrade this becomes more complicated to
> >>> maintain outdated tool. So it's time for wheezy to slightly go...
> >>>      
> >>
> >> If there are no objections, I'd like to apply this to have CI build
> >> green. Then I'll be able to eventually release master :-)  
> > 
> > I have no objections to dropping wheezy support. But if doing so the
> > real change is not removing it from the CI scripts and keeping it
> > around.
> > There are configs that need to be removed, docs that need to be
> > updated. Just "git grep wheezy" and you will find many more
> > referrence than just CI. We do not have a support matrix, but as
> > long as we have code hanging around, that suggests that a certain
> > distro is supported ... it should be working.
> >   
> 
> For sure, I understand, that there is multiconfig for wheezy that
> should also go.
> 
> > Dropping wheezy is a topic that probably deserves its own thread.  
> 
> I already planned to discuss wheezy's value after the release (this 
> week). But there are two points:
> 
> 1. There is an issue with ext4 image creation after switching to wic, 
> dmesg in QEMU sometimes shows the following error:
> 
> 8<--
>    EXT4-fs (mmcblk0): bad geometry: block count 247892 exceeds size
> of device (247808 blocks)
> 8<--
> 
> This problem is reproduced on wheezy image only. So I want to debug
> it first before completely dropping wheezy, to prevent possible error
> leaking.

The wic series does not even support building weezy images so i fail to
see the connection. One thing that comes to mind is that the builder
used to need e2fsprogs/jessie-backports, if you removed that you might
have your explanation.

> 2. I want to have green CI to perform release.
> 
> So I propose drop wheezy from CI as the first step to unblock the
> process.

Sounds like the VW approach ;). if under_test then pretend
But if you are planning to phase out weezie that might be an OK way to
do it.

Henning
 
> Alex