Re: [PATCH v2 2/2] image: Add ISAR SDK package to create SDK from any rootfs image.

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 16 May 2018 17:56:53 +0200
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> ---
>  meta-isar/recipes-core/images/isar-image-sdk.bb |  9 ++++++
>  meta/recipes-devtools/isar-sdk/files/README     |  2 ++
>  meta/recipes-devtools/isar-sdk/files/postinst   | 21 +++++++++++++
>  meta/recipes-devtools/isar-sdk/isar-sdk.bb      | 42
> +++++++++++++++++++++++++ 4 files changed, 74 insertions(+)
>  create mode 100644 meta-isar/recipes-core/images/isar-image-sdk.bb
>  create mode 100644 meta/recipes-devtools/isar-sdk/files/README
>  create mode 100644 meta/recipes-devtools/isar-sdk/files/postinst
>  create mode 100644 meta/recipes-devtools/isar-sdk/isar-sdk.bb
> 
> diff --git a/meta-isar/recipes-core/images/isar-image-sdk.bb
> b/meta-isar/recipes-core/images/isar-image-sdk.bb new file mode 100644
> index 0000000..5128a03
> --- /dev/null
> +++ b/meta-isar/recipes-core/images/isar-image-sdk.bb
> @@ -0,0 +1,9 @@
> +# ISAR SDK based on isar-image-base
> +#
> +# This software is a part of ISAR.
> +# Copyright (C) 2018 ilbers GmbH
> +
> +include recipes-core/images/isar-image-base.bb
> +
> +IMAGE_INSTALL += "isar-sdk"
> +
> diff --git a/meta/recipes-devtools/isar-sdk/files/README
> b/meta/recipes-devtools/isar-sdk/files/README new file mode 100644
> index 0000000..3b80848
> --- /dev/null
> +++ b/meta/recipes-devtools/isar-sdk/files/README
> @@ -0,0 +1,2 @@
> +Include isar-sdk into IMAGE_INSTALL of image recipe to create ISAR
> SDK +based on this image.
> diff --git a/meta/recipes-devtools/isar-sdk/files/postinst
> b/meta/recipes-devtools/isar-sdk/files/postinst new file mode 100644
> index 0000000..2c6e6e0
> --- /dev/null
> +++ b/meta/recipes-devtools/isar-sdk/files/postinst
> @@ -0,0 +1,21 @@
> +#!/bin/sh
> +
> +set -e
> +
> +readonly USER=builder
> +
> +adduser --disabled-password --gecos "ISAR Builder" $USER
> +# Empty user password
> +passwd -d $USER
> +
> +echo "export LC_ALL=C.UTF-8" >> /home/$USER/.profile
> +
> +cat >> /etc/sudoers << EOF
> +$USER	ALL=NOPASSWD: ALL
> +%$USER	ALL=NOPASSWD: ALL
> +EOF

Use /etc/sudoers.d/ instead.

> +#Check for errors
> +visudo -c
> +
> +chown -R $USER:$USER /home/$USER/isar /home/$USER/build
> diff --git a/meta/recipes-devtools/isar-sdk/isar-sdk.bb
> b/meta/recipes-devtools/isar-sdk/isar-sdk.bb new file mode 100644
> index 0000000..4a3176a
> --- /dev/null
> +++ b/meta/recipes-devtools/isar-sdk/isar-sdk.bb
> @@ -0,0 +1,42 @@
> +# This software is a part of ISAR.
> +# Copyright (C) 2018 ilbers GmbH
> +
> +DESCRIPTION = "Package to be installed to create ISAR SDK target
> filesystem" +MAINTAINER = ""
> +DEBIAN_DEPENDS = "apt (>= 0.4.2), \
> +                  passwd, \
> +                  patch, \
> +                  ca-certificates, \
> +                  dbus, \
> +                  dosfstools, \
> +                  git,\
> +                  debootstrap, \
> +                  localepurge, \
> +                  parted, \
> +                  python3, \
> +                  rxvt-unicode, \
> +                  qemu, \
> +                  qemu-user-static, \
> +                  binfmt-support, \
> +                  sudo, \
> +                  reprepro"
> +
> +SRC_URI = "git://github.com/ilbers/isar.git;protocol=https"
> +SRCREV = "${AUTOREV}"
> +
> +SRC_URI += "file://README \
> +	   file://postinst"
> +
> +inherit dpkg-raw
> +
> +do_install() {
> +
> +	bbnote "Installing ISAR tree"
> +	install -v -d ${D}/home/builder/isar
> +	git clone http://github.com/ilbers/isar.git
> ${D}/home/builder/isar +
> +	install -v -d ${D}/home/builder/build
> +
> +	bbnote "Copying ${DL_DIR} directory"
> +	cp -a ${DL_DIR} ${D}/home/builder/build/
> +}

Why do we need Isar in there? And if we need it you should get it via
SRC_URI and not fetch again. What you do here will potentially not work
behind a proxy.

Henning