From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6558749580291211264 X-Received: by 2002:adf:f8c7:: with SMTP id f7-v6mr300828wrq.28.1527084970738; Wed, 23 May 2018 07:16:10 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:39c1:: with SMTP id g184-v6ls3017572wma.9.canary-gmail; Wed, 23 May 2018 07:16:10 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp9OL2iVKNR2mKPYgpPZWhiB39l7fpE8HI0JdUX+1zSRcehYaopjEjqq/e3wiC1WLLVNtNR X-Received: by 2002:a1c:ca0f:: with SMTP id a15-v6mr558292wmg.18.1527084970171; Wed, 23 May 2018 07:16:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527084970; cv=none; d=google.com; s=arc-20160816; b=nMcKPlWhLOQmAhWffyENoFJu+yVOOLqmhFWDwHQrazn2VIJPswO7vrxzBw7Q2nQYzg KTvt2xOK8ovOeqxdQowNTwBQwCc2PpLzGhZPg7b8vHCM9GOvIuUZxoNPhvsmUS5AnZFB w0n1rW/e2Ydzg8Np9/xkNZvDZVupnQSIkpTj97vBxIiGGzIenW8lAJmNlgUkffVcWlRW PJP8YvqdlDLMFNZlD4uiztYU/xqBRrl/4fr6tj/8Vv5y1LTkyU9m1qCuDhw5wIzZ3CA7 sfAZSioy6tlG3ieTDoh5AdwEdjQflYE9KvDnUjfpNdijfBc20FeCSCv3vo0pxdNJOkrd /GqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=J5606+rQ70aP9yHGWwrpzZ0rvwQRlDkrRUDt5GgG4AI=; b=XUEqk7G5djdmp+fc0HSz1tU92CYmiJBxt7KgP1aIa4gPdyhjTm7HV2IVrzovritDFb AAosrgGfvnwKwDIYQQa6HL/CsiG7o5E1fQWUqVTW4UgTjy6vElNnRYwrSd4QhnzboLdd QgSejxtDxStO0w/XrBWs+/T37COh65H5Pw42hip3KTAx15TpMHeE3VdW4HzLcPnB+yzh CYGSwZrOUb1+A3bOv9nFAXRqJWlE5O2/Pece/y53Wsnjd0OeDvqaN0DyUx8+4ieklg3g 1QgwqhYP1GaYjvWVm9l/j5GRbv4pt3CTeqIafroEX+zM6ILgKhtkHxAY9r2xOnsaxq27 uQRg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m11-v6si764606wrn.3.2018.05.23.07.16.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 07:16:10 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w4NEG9ai011950 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 23 May 2018 16:16:09 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w4NEG9Rr024359; Wed, 23 May 2018 16:16:09 +0200 Date: Wed, 23 May 2018 16:16:08 +0200 From: Henning Schild To: "[ext] claudius.heine.ext@siemens.com" Cc: , Claudius Heine Subject: Re: [PATCH v2 2/3] meta/isar-cfg-localepurge: added locale purge recipe Message-ID: <20180523161608.710986c0@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180523131248.31907-3-claudius.heine.ext@siemens.com> References: <20180523131248.31907-1-claudius.heine.ext@siemens.com> <20180523131248.31907-3-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: LeWu/kOjuJl9 Am Wed, 23 May 2018 15:12:47 +0200 schrieb "[ext] claudius.heine.ext@siemens.com" : > From: Claudius Heine > > The package 'isar-cfg-localepurge' is used to set the locales of the > root file system and purge all not required locales. > > Signed-off-by: Claudius Heine > --- > .../isar-cfg-localepurge/files/locale.debconf | 12 ++++++++ > .../isar-cfg-localepurge/files/locale.gen | 1 + > .../isar-cfg-localepurge/files/postinst | 30 > +++++++++++++++++++ .../isar-cfg-localepurge.bb | > 19 ++++++++++++ 4 files changed, 62 insertions(+) > create mode 100644 > meta/recipes-support/isar-cfg-localepurge/files/locale.debconf create > mode 100644 > meta/recipes-support/isar-cfg-localepurge/files/locale.gen create > mode 100644 meta/recipes-support/isar-cfg-localepurge/files/postinst > create mode 100644 > meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb > > diff --git > a/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf > b/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf new > file mode 100644 index 0000000..169c071 --- /dev/null > +++ b/meta/recipes-support/isar-cfg-localepurge/files/locale.debconf > @@ -0,0 +1,12 @@ > +locales locales/locales_to_be_generated > multiselect en_US.UTF-8 UTF-8 +locales > locales/default_environment_locale select en_US.UTF-8 + > +localepurge localepurge/dontbothernew boolean > true +localepurge localepurge/nopurge > multiselect en, en_US, en_US.UTF-8 +localepurge > localepurge/use-dpkg-feature boolean false > +localepurge localepurge/verbose boolean false > +localepurge localepurge/showfreedspace boolean > false +localepurge localepurge/none_selected > boolean false +localepurge localepurge/mandelete > boolean true +localepurge > localepurge/quickndirtycalc boolean false > +localepurge localepurge/remove_no note diff --git > a/meta/recipes-support/isar-cfg-localepurge/files/locale.gen > b/meta/recipes-support/isar-cfg-localepurge/files/locale.gen new file > mode 100644 index 0000000..a66d814 --- /dev/null +++ > b/meta/recipes-support/isar-cfg-localepurge/files/locale.gen @@ -0,0 > +1 @@ +en_US.UTF-8 UTF-8 > diff --git a/meta/recipes-support/isar-cfg-localepurge/files/postinst > b/meta/recipes-support/isar-cfg-localepurge/files/postinst new file > mode 100644 index 0000000..3ef93cd > --- /dev/null > +++ b/meta/recipes-support/isar-cfg-localepurge/files/postinst > @@ -0,0 +1,30 @@ > +#!/bin/sh > +set -e > + > +cat /usr/local/etc/isar-cfg-localepurge/locale.gen \ > + >> /etc/locale.gen All of this is pretty evil. This package is installed last, so if i had any package before it dealing with locales ... Would i need to remember to clear IMAGE_CFG_PACKAGE? I guess some checking should be done before proceeding here. And thinking about it, do we not need to set the locales very early? I remember all the perl warning in buildchroot. > +debconf-set-selections /usr/local/etc/isar-cfg-localepurge/locale.debconf > + > +# locale.nopurge needs to be removed before localepurge is > reconfigured. +# Otherwise it would set the debconf to the values > from the locale.nopurge +# file again. > +rm -rf /etc/locale.nopurge > +dpkg-reconfigure -f noninteractive locales localepurge > + > +# When /etc/locale.nopurge was removed before dpkg-reconfigure, it > writes +# the new configuration with the '.ucf-dist' postfix > +mv /etc/locale.nopurge.ucf-dist /etc/locale.nopurge > + > +# Now reconfigure it localpurge again, because otherwise it would > complain: +# Some new locales have appeared on your system: > +# > +# bal be@latin en@boldquot en@quot sr@latin > +# > +# They will not be touched until you reconfigure localepurge > +# with the following command: > +# > +# dpkg-reconfigure localepurge > +dpkg-reconfigure -f noninteractive localepurge > + > +localepurge > diff --git > a/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb > b/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb > new file mode 100644 index 0000000..b68a6d0 --- /dev/null > +++ > b/meta/recipes-support/isar-cfg-localepurge/isar-cfg-localepurge.bb > @@ -0,0 +1,19 @@ +# This software is a part of ISAR. > + > +DESCRIPTION = "Isar configuration package for locale and localepurge" > +MAINTAINER = "isar-users " > +DEBIAN_DEPENDS = "localepurge" > + > +SRC_URI = "file://locale.debconf \ > + file://locale.gen \ > + file://postinst" > + > +inherit dpkg-raw > + > +do_install() { > + install -v -d ${D}/usr/local/etc/${PN} > + install -v -m 644 ${WORKDIR}/locale.debconf \ > + ${D}/usr/local/etc/${PN}/locale.debconf /usr/local/ suggests that we are not under package manager regime here, i googled it for a similar need and came to the conclusion that /usr/lib/${PN} would be the right place for such files. Or pack them into postinst as self extracting tar to gain a "staging area". In your case the package gets removed so you do not have to worry about potential copies. Still the location should not be /usr/local/... Henning > + install -v -m 644 ${WORKDIR}/locale.gen \ > + ${D}/usr/local/etc/${PN}/locale.gen > +}