Re: [PATCH v5 1/1] meta-isar/isar-image-base: added removal of qemu-*-static binaries

[Henning Schild <henning.schild@siemens.com>]

LGTM

Am Thu, 24 May 2018 16:21:12 +0200
schrieb "[ext] claudius.heine.ext@siemens.com"
<claudius.heine.ext@siemens.com>:

> From: Claudius Heine <ch@denx.de>
> 
> After the image has finished building, the qemu-*-static binaries that
> are installed by quemu-debootstrap can be removed because they are no
> longer needed.
> 
> If this binary is overwritten by installing qemu-user-static into the
> image, then this binary is not removed. (This is possible if the
> binfmt_misc entry for this architecture has the 'F' flag. In that case
> qemu-*-static shouldn't even be deployed by qemu-debootstrap.)
> 
> Reported-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>  meta-isar/recipes-core/images/isar-image-base.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb
> b/meta-isar/recipes-core/images/isar-image-base.bb index
> 5ad6df3..1239f72 100644 ---
> a/meta-isar/recipes-core/images/isar-image-base.bb +++
> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -41,6 +41,9 @@
> do_rootfs() { # Cleanup
>      sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}"
>      sudo rm "${IMAGE_ROOTFS}/etc/apt/sources.list.d/isar-apt.list"
> +    test ! -e "${IMAGE_ROOTFS}/usr/share/doc/qemu-user-static" && \
> +         sudo find "${IMAGE_ROOTFS}/usr/bin" \
> +              -maxdepth 1 -name 'qemu-*-static' -type f -delete
>      sudo umount -l ${IMAGE_ROOTFS}/isar-apt
>      sudo rmdir ${IMAGE_ROOTFS}/isar-apt
>      sudo umount -l ${IMAGE_ROOTFS}/dev