From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6562126013157867520 X-Gmail-Labels: Topic type: DISCUSSION X-Received: by 2002:a2e:9253:: with SMTP id v19-v6mr797454ljg.29.1528100836274; Mon, 04 Jun 2018 01:27:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:cf0e:: with SMTP id f14-v6ls4909095lfg.5.gmail; Mon, 04 Jun 2018 01:27:15 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI+2FKTV8UWHWZCmvtDtQdV6df91sZX7WSrbnCm7POsx0KrMx8u+f1Jxt+WK/ahinXsHHB8 X-Received: by 2002:a19:5cc4:: with SMTP id u65-v6mr356954lfi.29.1528100835783; Mon, 04 Jun 2018 01:27:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528100835; cv=none; d=google.com; s=arc-20160816; b=AKsdUZ2bxfu0Ux4vp5sz+MP7Pg+UDXhUVmhMJPMkv3Fsy44nIZo0d3ksqEdt10Jeri Va2XgZtovNDE1DYHHLZ83AhbWfMfS7IqqSp/x7Y24Tm9hfFB+6nS8dXueUXTNFUEvPlM K1JTx/ALQb9qs9RPYoYEhcsB8i03rDklQt4qtJ5DoY09MWnvg1Qg87l1DTjuzmBXtOcK GjO3piYyatrAhj4h8rfixbriM1fJXWX5oTJeez0bOEbjEh2RpXRa0MfLmVbQ2wpFw6mT oWTt3D2FzSuyCGFcO2oL48iAhS25uSQ9QF/2z0RtozaRzLC/koSw/SOxx5vPfXSbK01Z 0TEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=O3X3azcWgrGqZ35OIZtzGgfpP6JkZ+b66uiOUiAiwwo=; b=LtABRxC5W41cSuGmdUXIMhvDYYAuUEp1/wON6cQCzG1pqHQ1SWbJsSev/h+RdFWkV9 a+FgGoVAloXV+kiEcq7bqOJDD+gz/1ej/sCbhK22KTdQC2EFKOwT46BPTBJNNqDPqpej 1rOb13nBgcfv2wvC+6EhEiIeoPDP5cR3fZa1LCBltqHb6a2zFMTlRD/4YZj34XP/xAUP s5U04YhswmF1gFj0U+okXPexyaqwZsg8LNWOxcC3fzAG+9FXjefcUK+NQVNuTbIxHgR8 N5nFqmRLJMa1cbIdwQXQB1Rbpx/dVMvAUrKof20y6aRpKqUQM/VtZ6wvYMfLPPyNsuj4 ba7A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id z203-v6si565437lff.3.2018.06.04.01.27.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 01:27:15 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w548REXR030297 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Jun 2018 10:27:15 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w548REfE031692; Mon, 4 Jun 2018 10:27:14 +0200 Date: Mon, 4 Jun 2018 10:27:14 +0200 From: Henning Schild To: "[ext] Jan Kiszka" Cc: , isar-users Subject: Re: IMAGE_TYPE vs IMAGE_TYPE(S) Message-ID: <20180604102714.7a768704@md1pvb1c.ad001.siemens.net> In-Reply-To: References: <45b87a65-2efb-4652-8790-6b5726e1caef@googlegroups.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: RzQtqYRVl0ps Am Mon, 4 Jun 2018 09:16:46 +0200 schrieb "[ext] Jan Kiszka" : > On 2018-06-01 16:40, cedric_hombourger@mentor.com wrote: > > Hello! > >=20 > > The documentation suggests that IMAGE_TYPE may be a list of images > > to be built: > >=20 > > =C2=A0 =C2=A0|=C2=A0The `IMAGE_TYPE` variable contains the list of imag= e types to > > generate. > >=20 > > (ref:=C2=A0https://github.com/ilbers/isar/blob/master/doc/user_manual.m= d#image-type-selection) > >=20 > > It appears that one could set this to e.g. "ext4-img wic-img" to get > > Isar to generate both an EXT4 image and a WIC image. > > Alright. > >=20 > > But then how about this code: > >=20 > > =C2=A0 =C2=A0| if d.getVar('IMAGE_TYPE', True) =3D=3D 'wic-img': > > =C2=A0 =C2=A0| =C2=A0 =C2=A0 d.appendVar('BUILDCHROOT_PREINSTALL', > > =C2=A0 =C2=A0| =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = d.getVar('BUILDCHROOT_PREINSTALL_WIC', True)) > >=20 > > (ref:=C2=A0https://github.com/ilbers/isar/blob/master/meta/recipes-devt= ools/buildchroot/buildchroot.bb#L45) > >=20 > > The condition would be False for the example provided above and our > > buildchroot missing vital tools such mkdosfs > >=20 > > We probably need to fix one or the other. What are your thoughts? =20 >=20 > While the above would be easy to adjust, it doesn't look to me like as > if the rest of Isar is ready to support true IMAGE_TYPES semantic. I > would suggest to adjust the doc for now so that it stops suggesting > IMAGE_TYPE is like OE's IMAGE_TYPES. Patch welcome. I agree. If you want another type just derive an image from your existing one and override the IMAGE_TYPE. IMHO that is cleaner anyways but would share less temporary results. Henning > Thanks for reporting! > Jan >=20