public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] claudius.heine.ext@siemens.com" <claudius.heine.ext@siemens.com>
Cc: <isar-users@googlegroups.com>, Claudius Heine <ch@denx.de>
Subject: Re: [PATCH 0/1] Disable daemon activation
Date: Mon, 4 Jun 2018 19:36:46 +0200	[thread overview]
Message-ID: <20180604193646.769f01ca@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <20180604112159.18605-1-claudius.heine.ext@siemens.com>

Hi,

this looks pretty nasty, and this is the "old" way of doing something
like that. I would prefer adding some cgroup support to Isar to deal
with that and other things. But if it works and did so in Debian for
years ... why not.

We could cgreate a temporary cgroup where we cgexec "sudo chroot", when
that returns we destroy the cgroup and autokill everything running in
there. This might also work for the umounts that we now still do
explicit.

I guess cgroups are a feature we can expect from a modern Linux build
host, question is can we rely on the tools or should we create them
manually.

If you are building in docker you get what i described for "free". It
takes care of cgroups and cleaning up after a finished build, but only
once you end the container.

Henning

Am Mon, 4 Jun 2018 13:21:58 +0200
schrieb "[ext] claudius.heine.ext@siemens.com"
<claudius.heine.ext@siemens.com>:

> From: Claudius Heine <ch@denx.de>
> 
> Hi,
> 
> this patch disables the daemon activation in the chroot environment.
> 
> Since I could not reproduce the problem this patch handles, please
> test if this fixes it, if the code looks fine.
> 
> Cheers,
> Claudius
> 
> Claudius Heine (1):
>   meta/isar-bootstrap: deactivate daemon activation in chroot
>     environment
> 
>  meta/classes/isar-bootstrap-helper.bbclass    |   2 +
>  .../isar-bootstrap/files/chroot-setup.sh      | 133
> ++++++++++++++++++ .../isar-bootstrap/isar-bootstrap.bb          |
> 11 +- 3 files changed, 144 insertions(+), 2 deletions(-)
>  create mode 100644
> meta/recipes-core/isar-bootstrap/files/chroot-setup.sh
> 


  parent reply	other threads:[~2018-06-04 17:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 11:21 claudius.heine.ext
2018-06-04 11:21 ` [PATCH 1/1] meta/isar-bootstrap: deactivate daemon activation in chroot environment claudius.heine.ext
2018-06-05 11:05   ` Jan Kiszka
2018-06-04 17:36 ` Henning Schild [this message]
2018-06-04 17:48   ` [PATCH 0/1] Disable daemon activation Claudius Heine
2018-06-04 18:02     ` Henning Schild
2018-06-05  8:42 ` Maxim Yu. Osipov
2018-06-05 11:52   ` Claudius Heine
2018-06-05 12:38     ` Maxim Yu. Osipov
2018-06-05 12:45       ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180604193646.769f01ca@md1pvb1c.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=ch@denx.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox