From: Alexander Smirnov <asmirnov@ilbers.de>
To: isar-users@googlegroups.com
Cc: Alexander Smirnov <asmirnov@ilbers.de>
Subject: [PATCH 7/9] classes/dpkg*: Drop hardcoded buildchroot blobs
Date: Wed, 13 Jun 2018 15:08:05 +0200 [thread overview]
Message-ID: <20180613130807.2461-8-asmirnov@ilbers.de> (raw)
In-Reply-To: <20180613130807.2461-1-asmirnov@ilbers.de>
This patch makes possible to parametrize the chroot will be actually
used by dpkg-base class.
Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
---
meta/classes/dpkg-base.bbclass | 14 +++++++-------
meta/classes/dpkg-raw.bbclass | 4 +++-
meta/classes/dpkg.bbclass | 4 +++-
3 files changed, 13 insertions(+), 9 deletions(-)
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 24fe2ca..0668e25 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -31,7 +31,7 @@ def get_package_srcdir(d):
PP = "/home/builder/${PN}"
PPS ?= "${@get_package_srcdir(d)}"
-BUILDROOT = "${BUILDCHROOT_DIR}/${PP}"
+BUILDROOT = "${ROOTFS_DIR}/${PP}"
do_build[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
# default to "emtpy" implementation
@@ -39,7 +39,7 @@ dpkg_runbuild() {
die "This should never be called, overwrite it in your derived class"
}
-MOUNT_LOCKFILE = "${BUILDCHROOT_DIR}/mount.lock"
+MOUNT_LOCKFILE = "${ROOTFS_DIR}/mount.lock"
# Wrap the function dpkg_runbuild with the bind mount for buildroot
do_build() {
@@ -47,11 +47,11 @@ do_build() {
sudo mount --bind ${WORKDIR} ${BUILDROOT}
sudo flock ${MOUNT_LOCKFILE} -c ' \
- if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then \
- mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt; \
- mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads; \
- mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev; \
- mount -t proc none ${BUILDCHROOT_DIR}/proc; \
+ if ! grep -q ${ROOTFS_DIR}/isar-apt /proc/mounts; then \
+ mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${ROOTFS_DIR}/isar-apt; \
+ mount --bind ${DL_DIR} ${ROOTFS_DIR}/downloads; \
+ mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${ROOTFS_DIR}/dev; \
+ mount -t proc none ${ROOTFS_DIR}/proc; \
fi'
dpkg_runbuild
diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass
index 5c7be6b..1b661a7 100644
--- a/meta/classes/dpkg-raw.bbclass
+++ b/meta/classes/dpkg-raw.bbclass
@@ -9,6 +9,8 @@ MAINTAINER ?= "FIXME Unknown maintainer"
# Add dependency from buildchroot creation
do_build[depends] = "buildchroot:do_build"
+ROOTFS_DIR = "${BUILDCHROOT_DIR}"
+
D = "${WORKDIR}/image/"
# Populate folder that will be picked up as package
@@ -59,5 +61,5 @@ addtask deb_package_conffiles after do_deb_package_prepare before do_build
dpkg_runbuild() {
sudo chown -R root:root ${D}/DEBIAN/
- sudo chroot ${BUILDCHROOT_DIR} dpkg-deb --build ${PP}/image ${PP}
+ sudo chroot ${ROOTFS_DIR} dpkg-deb --build ${PP}/image ${PP}
}
diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass
index c483fe2..195174a 100644
--- a/meta/classes/dpkg.bbclass
+++ b/meta/classes/dpkg.bbclass
@@ -6,8 +6,10 @@ inherit dpkg-base
# Add dependency from buildchroot creation
do_build[depends] = "buildchroot:do_build"
+ROOTFS_DIR = "${BUILDCHROOT_DIR}"
+
# Build package from sources using build script
dpkg_runbuild() {
E="${@ bb.utils.export_proxies(d)}"
- sudo -E chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${PPS}
+ sudo -E chroot ${ROOTFS_DIR} /build.sh ${PP}/${PPS}
}
--
2.1.4
next prev parent reply other threads:[~2018-06-13 13:08 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 13:07 [RFC] [PATCH 0/9] Initial cross-compilation support Alexander Smirnov
2018-06-13 13:07 ` [PATCH 1/9] isar-bootstrap: Add routin to determine host arch Alexander Smirnov
2018-06-14 11:23 ` Henning Schild
2018-06-15 11:11 ` Alexander Smirnov
2018-06-15 11:15 ` Jan Kiszka
2018-06-13 13:08 ` [PATCH 2/9] isar-bootstrap: Move common part to include Alexander Smirnov
2018-06-13 13:08 ` [PATCH 3/9] isar-bootstrap: Add host architecture support Alexander Smirnov
2018-06-14 11:27 ` Henning Schild
2018-06-15 11:09 ` Alexander Smirnov
2018-06-13 13:08 ` [PATCH 4/9] isar-bootstrap-helper: Add parameter to set arch Alexander Smirnov
2018-06-13 13:08 ` [PATCH 5/9] buildchroot-cross: Initial implementation Alexander Smirnov
2018-06-14 11:36 ` Henning Schild
2018-06-15 11:16 ` Alexander Smirnov
2018-06-14 15:55 ` Jan Kiszka
2018-06-15 10:56 ` Alexander Smirnov
2018-06-15 11:12 ` Jan Kiszka
2018-06-17 19:28 ` Alexander Smirnov
2018-06-13 13:08 ` [PATCH 6/9] classes/dpkg*: Relocate dependency from buildchroot Alexander Smirnov
2018-06-14 6:44 ` Jan Kiszka
2018-06-15 10:52 ` Alexander Smirnov
2018-06-13 13:08 ` Alexander Smirnov [this message]
2018-06-13 13:08 ` [PATCH 8/9] classes/dpkg-cross: Initial implementation Alexander Smirnov
2018-06-13 13:08 ` [PATCH 9/9] [FOR TESTING] libhello: Switch to cross compilation Alexander Smirnov
2018-06-13 13:57 ` [RFC] [PATCH 0/9] Initial cross-compilation support Jan Kiszka
2018-06-14 11:20 ` Henning Schild
2018-06-17 19:41 ` Alexander Smirnov
2018-06-18 7:04 ` Henning Schild
2018-06-14 12:01 ` Henning Schild
2018-06-14 12:04 ` Claudius Heine
2018-06-14 12:24 ` Henning Schild
2018-06-14 12:36 ` Claudius Heine
2018-06-14 12:30 ` Jan Kiszka
2018-06-14 12:42 ` Claudius Heine
2018-06-14 12:55 ` Claudius Heine
2018-06-15 10:50 ` Alexander Smirnov
2018-06-15 13:17 ` Claudius Heine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180613130807.2461-8-asmirnov@ilbers.de \
--to=asmirnov@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox