Re: [RFC PATCH 1/6] isar-bootstrap-helper: Add option --copyrepo to setup_root_file_system()

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 13 Jun 2018 15:58:24 +0200
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> Add the option of copying isar-apt repo to rootfs instead of mounting
> it.
> 
> Signed-off-by: Maxim Osipov <mosipov@ilbers.de>
> ---
>  meta/classes/isar-bootstrap-helper.bbclass | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass
> b/meta/classes/isar-bootstrap-helper.bbclass index 3c10fc7..7a63914
> 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -16,10 +16,12 @@ def reverse_bb_array(d, varname):
>  
>  setup_root_file_system() {
>      CLEAN=""
> +    COPYREPO=""

Maybe call that COPYISARAPT --copyisarapt. With the reproducable build
feature still to come we might end up copying many "repos" and the name
could become confusing.

Henning

>      FSTAB=""
>      while true; do
>          case "$1" in
>          --clean) CLEAN=1 ;;
> +        --copyrepo) COPYREPO=1 ;;
>          --fstab) FSTAB=$2; shift ;;
>          -*) bbfatal "$0: invalid option specified: $1" ;;
>          *) break ;;
> @@ -43,7 +45,11 @@ setup_root_file_system() {
>      echo "Package: *\nPin: release n=${DEBDISTRONAME}\nPin-Priority:
> 1000" | \ sudo tee "$ROOTFSDIR/etc/apt/preferences.d/isar" >/dev/null
>  
> -    sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} $ROOTFSDIR/isar-apt
> +    if [ ${COPYREPO} ]; then
> +        sudo cp -Trpfx ${DEPLOY_DIR_APT}/${DISTRO}
> $ROOTFSDIR/isar-apt
> +    else
> +        sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO}
> $ROOTFSDIR/isar-apt
> +    fi
>      sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs
> $ROOTFSDIR/dev sudo mount -t proc none $ROOTFSDIR/proc
>