Re: [RFC PATCH 5/6] scripts: Add helper scripts to mount/umount chroot directory.

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 13 Jun 2018 15:58:28 +0200
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> Mount/umount the required directories in chroot by passing path to
> rootfs directory as an argument.
> 
> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> ---
>  scripts/mount_chroot.sh  | 7 +++++++
>  scripts/umount_chroot.sh | 7 +++++++
>  2 files changed, 14 insertions(+)
>  create mode 100755 scripts/mount_chroot.sh
>  create mode 100755 scripts/umount_chroot.sh
> 
> diff --git a/scripts/mount_chroot.sh b/scripts/mount_chroot.sh
> new file mode 100755
> index 0000000..8390edb
> --- /dev/null
> +++ b/scripts/mount_chroot.sh
> @@ -0,0 +1,7 @@
> +#!/bin/bash
> +sudo mount /tmp     $1/tmp                 -o bind
> +sudo mount proc     $1/proc    -t proc     -o nosuid,noexec,nodev
> +sudo mount sysfs    $1/sys     -t sysfs    -o nosuid,noexec,nodev
> +sudo mount devtmpfs $1/dev     -t devtmpfs -o mode=0755,nosuid
> +sudo mount devpts   $1/dev/pts -t devpts   -o gid=5,mode=620
> +sudo mount tmpfs    $1/dev/shm -t tmpfs    -o
> rw,seclabel,nosuid,nodev diff --git a/scripts/umount_chroot.sh
> b/scripts/umount_chroot.sh new file mode 100755
> index 0000000..a4abde0
> --- /dev/null
> +++ b/scripts/umount_chroot.sh
> @@ -0,0 +1,7 @@
> +#!/bin/bash
> +sudo umount $1/tmp
> +sudo umount $1/proc
> +sudo umount $1/sys
> +sudo umount $1/dev
> +sudo umount $1/dev/pts
> +sudo umount $1/dev/shm

I already mentioned those "sudos" should go, from both scripts. It
might be a good idea to invent something like an fstab that both
scripts access, and "set -e". For umount you could also check whether
"--recursive" can be used, that way you would not have to mention all
directories twice and the fstab idea would not be needed.

Henning