From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6566568349648551936 X-Received: by 2002:a2e:9056:: with SMTP id n22-v6mr74815ljg.41.1528968528663; Thu, 14 Jun 2018 02:28:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9893:: with SMTP id b19-v6ls773164ljj.3.gmail; Thu, 14 Jun 2018 02:28:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIMB9nGd+uQCV8hQ1TkIq1/7BhNpACLEjI/u9uBYZ2NneJ37p+ou7EEVULV2EoIrZCcINVT X-Received: by 2002:a2e:7c18:: with SMTP id x24-v6mr72181ljc.4.1528968527750; Thu, 14 Jun 2018 02:28:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528968527; cv=none; d=google.com; s=arc-20160816; b=l1B7U1OdMfteqfXiWBZX4g+gCGYbWdvHSdSVMAnDHgG0W1MazvNulqVN9S4tvVzkSA BC+tqWL/1pm0PyTyGqqK4BC/gQSGp2Viv6AOe+50+46OEBpv37nlv72tydFhr6B1gZjn GpQTxXYsAHZzElo8DlNTjDdMFfbcTs5UWu1yC30ym1ldxSX5jezquEVm32sHFOunp3wK 9Niy+VfpmXIgChCw064nqlpS5N8lGE711NL/or8cyqh2l1qfE6V9dxBbWfBNgRm8/G66 Ll8yLlJT32KGGeDjE6vN4ckGYv5IfCTftO+cciMixyqO4Gy5GJHdTlAbzH0LMHF2IQVt b2sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=fIbOKZzELOGMQi3uVOmKCukD+B6TWAXi0ikGe4uK5IA=; b=MUfwngmBw9ZXQ09mbLW+yMpWR7+4CegAJtpcWamhKH1ZiuRO6EWCOCVxMAxiM9X+6A vvBTZxnd24ifTZpcUMWO4qCy3ITRgqujd0UYOi969e+oqGMcKUrj0xt+9Tn6arokqyr6 oYZqxZ7qTxqJPuKWq2dEhyv1ORIIh4Y7L9OP4Iu8z1vEvEyEjeWKuK+oG+bSvzqT51LJ jx61uN8s7kDuE5eg0Cuc7PxTvwVuq1XORfUXF7sByZPSgsh9Y+bytfXI94X9pvJtjO02 cgImfNv85lwjYCF1nk7ljgBxdlWEQD/mla+QgtdQLLmc3SKWApA3MCvUhdd8G8dQA8ef IEVA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y20-v6si125688ljh.2.2018.06.14.02.28.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jun 2018 02:28:47 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w5E9Ski0017408 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Jun 2018 11:28:47 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w5E9SkTR030750; Thu, 14 Jun 2018 11:28:46 +0200 Date: Thu, 14 Jun 2018 11:28:45 +0200 From: Henning Schild To: "Maxim Yu. Osipov" Cc: Subject: Re: [RFC PATCH 5/6] scripts: Add helper scripts to mount/umount chroot directory. Message-ID: <20180614112845.13d7e15d@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180613135829.3151-6-mosipov@ilbers.de> References: <20180613135829.3151-1-mosipov@ilbers.de> <20180613135829.3151-6-mosipov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: YmA5we0jMGPJ Am Wed, 13 Jun 2018 15:58:28 +0200 schrieb "Maxim Yu. Osipov" : > Mount/umount the required directories in chroot by passing path to > rootfs directory as an argument. > > Signed-off-by: Maxim Yu. Osipov > --- > scripts/mount_chroot.sh | 7 +++++++ > scripts/umount_chroot.sh | 7 +++++++ > 2 files changed, 14 insertions(+) > create mode 100755 scripts/mount_chroot.sh > create mode 100755 scripts/umount_chroot.sh > > diff --git a/scripts/mount_chroot.sh b/scripts/mount_chroot.sh > new file mode 100755 > index 0000000..8390edb > --- /dev/null > +++ b/scripts/mount_chroot.sh > @@ -0,0 +1,7 @@ > +#!/bin/bash > +sudo mount /tmp $1/tmp -o bind > +sudo mount proc $1/proc -t proc -o nosuid,noexec,nodev > +sudo mount sysfs $1/sys -t sysfs -o nosuid,noexec,nodev > +sudo mount devtmpfs $1/dev -t devtmpfs -o mode=0755,nosuid > +sudo mount devpts $1/dev/pts -t devpts -o gid=5,mode=620 > +sudo mount tmpfs $1/dev/shm -t tmpfs -o > rw,seclabel,nosuid,nodev diff --git a/scripts/umount_chroot.sh > b/scripts/umount_chroot.sh new file mode 100755 > index 0000000..a4abde0 > --- /dev/null > +++ b/scripts/umount_chroot.sh > @@ -0,0 +1,7 @@ > +#!/bin/bash > +sudo umount $1/tmp > +sudo umount $1/proc > +sudo umount $1/sys > +sudo umount $1/dev > +sudo umount $1/dev/pts > +sudo umount $1/dev/shm I already mentioned those "sudos" should go, from both scripts. It might be a good idea to invent something like an fstab that both scripts access, and "set -e". For umount you could also check whether "--recursive" can be used, that way you would not have to mention all directories twice and the fstab idea would not be needed. Henning