From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6566555412143800320 X-Received: by 2002:a1c:eb07:: with SMTP id j7-v6mr89378wmh.19.1529059957085; Fri, 15 Jun 2018 03:52:37 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:99d5:: with SMTP id b204-v6ls372662wme.6.canary-gmail; Fri, 15 Jun 2018 03:52:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLo0w1i1qtbAok++1iD/aqSkWzkI8WY/NEzQ0R0pNBsrJZcaPulIFMjWT/E8g2LsKhcRA+1 X-Received: by 2002:a1c:7302:: with SMTP id d2-v6mr84658wmb.16.1529059956670; Fri, 15 Jun 2018 03:52:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1529059956; cv=none; d=google.com; s=arc-20160816; b=bnBGWR3j8SyopziwNZKkxEW75NYrhjRW/CRRNnQaiXGrdsROjCO1yxb3+sn7AgWhxt gjHnLt90CNsNXvbOW9h95RXux02d6Y2ShD8mGb8EosHoAhPkZBMljRQvJkeNrbF5EFeW pxQGpJvDqNPvley/Ue1tCa0hdLcmJee8CyD2dOV/mptnDaWzPwSTCwWxzjFeJcJ25azI r3DvlefC1/iIJPMtRj3KffLi2ERbvR+xRiBWDHlDwakOtCC+nfTiycUIEkMLqmxw6cX+ 73ZCVRU4KTZ5Lb2oooBy83CI3v15w4OiBFy/KHLAHw9nyqCopfZn6bRKIZptf6hm/GCX HdLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:arc-authentication-results; bh=u80mzAhhsdscFknxwhvfAK/0dHVmUMI7hJcU7HYA2uU=; b=jVq5gpyyNHJJhVXJfDJi0D+RGYxR4jaT/alzJEbMjrugFY/ezQtIAh3xv7ax1PqktP t5f+vWbX3TMdYlpI9YDCPV7OlU7g77paHpXqwOtjUIcjVHxhbpp3l7qXwMWM9+Jg0lkk Hc3P5Uw/mLWVfT4HJS1vdRe5/ghp0VdNFO68OgENrPPLNu1Q8xcQ1sEGF7xypk9hCSOJ X9kco92MCcMr4FoDqVWjYffcvtY4xi3iS8pJCmLoS5742fFcBh5+jxZ4wNABJFby4hB3 CG39QVJo9K0ihz2B/MQZLJ/2nkkN+OkH9erC9aWqj0+qPI85OhfWhCwlk/BX6pzNAOfj UE+g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id r7-v6si168707wmc.0.2018.06.15.03.52.36 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jun 2018 03:52:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from azat.radix50.net (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w5FAqXVc005031 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 15 Jun 2018 12:52:35 +0200 Date: Fri, 15 Jun 2018 12:52:33 +0200 From: Alexander Smirnov To: Jan Kiszka Cc: isar-users@googlegroups.com Subject: Re: [PATCH 6/9] classes/dpkg*: Relocate dependency from buildchroot Message-ID: <20180615105233.GB24273@azat.radix50.net> References: <20180613130807.2461-1-asmirnov@ilbers.de> <20180613130807.2461-7-asmirnov@ilbers.de> <52e8023e-b6b2-d4a0-4d92-36f9f6d03568@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52e8023e-b6b2-d4a0-4d92-36f9f6d03568@siemens.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TUID: h2qdldF5A9qx Hi Jan, > On 2018-06-13 15:08, Alexander Smirnov wrote: > > Move dependency from buildchroot to the classes that actually require > > buildchroot. This will make possible to re-use dpkg-base class for > > buildchroot-cross. > > > > Signed-off-by: Alexander Smirnov > > --- > > meta/classes/dpkg-base.bbclass | 3 --- > > meta/classes/dpkg-raw.bbclass | 3 +++ > > meta/classes/dpkg.bbclass | 3 +++ > > 3 files changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > > index 75b45a7..24fe2ca 100644 > > --- a/meta/classes/dpkg-base.bbclass > > +++ b/meta/classes/dpkg-base.bbclass > > @@ -14,9 +14,6 @@ do_adjust_git[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > inherit patch > > addtask patch after do_adjust_git before do_build > > > > -# Add dependency from buildchroot creation > > -do_build[depends] = "buildchroot:do_build" > > - > > # Add dependency between Isar recipes > > DEPENDS ?= "" > > do_build[deptask] = "do_deploy_deb" > > diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass > > index 28233ac..5c7be6b 100644 > > --- a/meta/classes/dpkg-raw.bbclass > > +++ b/meta/classes/dpkg-raw.bbclass > > @@ -6,6 +6,9 @@ inherit dpkg-base > > DEBIAN_DEPENDS ?= "" > > MAINTAINER ?= "FIXME Unknown maintainer" > > > > +# Add dependency from buildchroot creation > > +do_build[depends] = "buildchroot:do_build" > > + > > D = "${WORKDIR}/image/" > > > > # Populate folder that will be picked up as package > > diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass > > index c8d4ac5..c483fe2 100644 > > --- a/meta/classes/dpkg.bbclass > > +++ b/meta/classes/dpkg.bbclass > > @@ -3,6 +3,9 @@ > > > > inherit dpkg-base > > > > +# Add dependency from buildchroot creation > > +do_build[depends] = "buildchroot:do_build" > > + > > # Build package from sources using build script > > dpkg_runbuild() { > > E="${@ bb.utils.export_proxies(d)}" > > > > You also need to update meta/recipes-kernel/linux/linux-custom.inc. It > inherits dpkg-base as well and, thus, now also needs this explicit > dependency. > > Same is true for patch 7 regarding ROOTFS_DIR variable. > Aah, totally missed this. Thank you for the hint! Alex > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux