Re: [PATCH 3/9] isar-bootstrap: Add host architecture support

[Alexander Smirnov <asmirnov@ilbers.de>]

On Thu, Jun 14, 2018 at 01:27:37PM +0200, Henning Schild wrote:
Hi Henning,

> This + 2/9 looks very much like what Maxim posted. Again i would like
> to understand why we need a copy of the debootstrap code. Maybe the
> differences can be addressed with introducing variables.
> 

For sure, that's the first idea came to my mind. But after an attempts
to implement this I've faced with the following issues:

 - buildchroot/buildchroot-cross are optional. They should be added to
   pipeline if some recipe requires them, i.e. ihnerits dpkg-* class.
 - Each buildchroot should have its own set of stamps to avoid
   duplications. For example each multiconfig has its own instance of
   target rootfs, but host rootfs should be singletone.

Current Isar implementation contains very comfortable way to chose the way how to build the package - inherit respective class.
Re-use of this approach to implement cross-building looks for me very comfortable way:
 - We should not invent the wheel and introduce new user-interface how
   to implement recipes. For example dpkg.bbclass depends on
buildchroot:do_build, so I simply implement dpkg-cross.bbclass which
depends on buildchroot-cross:do_build.
 - The Isar will stay flexible and builds the only really needed parts

Regarding the duplication - I've tried to reduce it as much as possible.
The shareble part is moved to .inc file, so the recipe payload contains
the only arch-specific stuff.

Alex

> Henning
> 
> Am Wed, 13 Jun 2018 15:08:01 +0200
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
> > Add recipe to generate bootstrap with the host architecture.
> > 
> > Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> > ---
> >  .../isar-bootstrap/isar-bootstrap-host.bb          | 44
> > ++++++++++++++++++++++ 1 file changed, 44 insertions(+)
> >  create mode 100644
> > meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > 
> > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb new file
> > mode 100644 index 0000000..c61c665
> > --- /dev/null
> > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap-host.bb
> > @@ -0,0 +1,44 @@
> > +# Minimal host Debian root file system
> > +#
> > +# This software is a part of ISAR.
> > +# Copyright (c) Siemens AG, 2018
> > +#
> > +# SPDX-License-Identifier: MIT
> > +
> > +Description = "Minimal host Debian root file system"
> > +
> > +include isar-bootstrap.inc
> > +inherit isar-bootstrap-helper
> > +
> > +do_bootstrap[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}"
> > +do_bootstrap[vardeps] += "DISTRO_APT_SOURCES"
> > +do_bootstrap[vardeps] += "DISTRO_APT_PREMIRRORS"
> > +do_bootstrap() {
> > +    if [ -e "${ROOTFSDIR}" ]; then
> > +       sudo umount -l "${ROOTFSDIR}/dev" || true
> > +       sudo umount -l "${ROOTFSDIR}/proc" || true
> > +       sudo rm -rf "${ROOTFSDIR}"
> > +    fi
> > +    E="${@bb.utils.export_proxies(d)}"
> > +    sudo -E "${DEBOOTSTRAP}" --verbose \
> > +                             --variant=minbase \
> > +                             --include=locales \
> > +                             ${@get_distro_components_argument(d)} \
> > +                             ${DEBOOTSTRAP_KEYRING} \
> > +                             "${@get_distro_suite(d)}" \
> > +                             "${ROOTFSDIR}" \
> > +                             "${@get_distro_source(d)}"
> > +}
> > +addtask bootstrap before do_build after do_generate_keyring
> > +
> > +do_deploy[stamp-extra-info] = "${DISTRO}-${HOST_ARCH}"
> > +do_deploy[dirs] = "${DEPLOY_DIR_IMAGE}"
> > +do_deploy() {
> > +    ln -Tfsr "${ROOTFSDIR}"
> > "${DEPLOY_DIR_IMAGE}/isar-bootstrap-${DISTRO}-${HOST_ARCH}" +}
> > +addtask deploy before do_build after do_apt_update
> > +
> > +CLEANFUNCS = "clean_deploy"
> > +clean_deploy() {
> > +     rm -f "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${HOST_ARCH}"
> > +}
>