public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Alexander Smirnov <asmirnov@ilbers.de>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH 1/9] isar-bootstrap: Add routin to determine host arch
Date: Fri, 15 Jun 2018 13:11:54 +0200	[thread overview]
Message-ID: <20180615111154.GE24273@azat.radix50.net> (raw)
In-Reply-To: <20180614132318.5f3ce768@md1pvb1c.ad001.siemens.net>

Hi Henning,

> Am Wed, 13 Jun 2018 15:07:59 +0200
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
> > This method will be used to distinguish host and target bootstraps.
> > The standard python platform module is not robust here, because it
> > provides the architecture label from kernel. For example running
> > platfotm.machine() on Fedora kernel will return 'x86_64', what is
> > invalid specificator for Debian systems.
> > 
> > Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> > ---
> >  meta/classes/isar-bootstrap-helper.bbclass | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/meta/classes/isar-bootstrap-helper.bbclass
> > b/meta/classes/isar-bootstrap-helper.bbclass index 3c10fc7..2598ea3
> > 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
> > +++ b/meta/classes/isar-bootstrap-helper.bbclass
> > @@ -14,6 +14,15 @@ def reverse_bb_array(d, varname):
> >      array = reversed(array.split())
> >      return " ".join(i for i in array)
> >  
> > +python () {
> > +    import subprocess
> > +    host_arch = subprocess.Popen("/usr/bin/dpkg
> > --print-architecture",
> > +                                 shell=True,
> > +                                 stdout=subprocess.PIPE
> > +                                ).stdout.read().decode('utf-8').strip()
> > +    d.setVar("HOST_ARCH", host_arch);
> > +}
> 
> Consider not using an absolute path. That defeats the magic of PATH.

I agree with you here, but btw, do you (or probably somebody else) know how to workaround this in
python subprocess? An attempt to run just 'dpkg' fails with the error:
command not found.

Alex

> Henning
> 
> > +
> >  setup_root_file_system() {
> >      CLEAN=""
> >      FSTAB=""
> 

  reply	other threads:[~2018-06-15 11:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 13:07 [RFC] [PATCH 0/9] Initial cross-compilation support Alexander Smirnov
2018-06-13 13:07 ` [PATCH 1/9] isar-bootstrap: Add routin to determine host arch Alexander Smirnov
2018-06-14 11:23   ` Henning Schild
2018-06-15 11:11     ` Alexander Smirnov [this message]
2018-06-15 11:15       ` Jan Kiszka
2018-06-13 13:08 ` [PATCH 2/9] isar-bootstrap: Move common part to include Alexander Smirnov
2018-06-13 13:08 ` [PATCH 3/9] isar-bootstrap: Add host architecture support Alexander Smirnov
2018-06-14 11:27   ` Henning Schild
2018-06-15 11:09     ` Alexander Smirnov
2018-06-13 13:08 ` [PATCH 4/9] isar-bootstrap-helper: Add parameter to set arch Alexander Smirnov
2018-06-13 13:08 ` [PATCH 5/9] buildchroot-cross: Initial implementation Alexander Smirnov
2018-06-14 11:36   ` Henning Schild
2018-06-15 11:16     ` Alexander Smirnov
2018-06-14 15:55   ` Jan Kiszka
2018-06-15 10:56     ` Alexander Smirnov
2018-06-15 11:12       ` Jan Kiszka
2018-06-17 19:28         ` Alexander Smirnov
2018-06-13 13:08 ` [PATCH 6/9] classes/dpkg*: Relocate dependency from buildchroot Alexander Smirnov
2018-06-14  6:44   ` Jan Kiszka
2018-06-15 10:52     ` Alexander Smirnov
2018-06-13 13:08 ` [PATCH 7/9] classes/dpkg*: Drop hardcoded buildchroot blobs Alexander Smirnov
2018-06-13 13:08 ` [PATCH 8/9] classes/dpkg-cross: Initial implementation Alexander Smirnov
2018-06-13 13:08 ` [PATCH 9/9] [FOR TESTING] libhello: Switch to cross compilation Alexander Smirnov
2018-06-13 13:57 ` [RFC] [PATCH 0/9] Initial cross-compilation support Jan Kiszka
2018-06-14 11:20 ` Henning Schild
2018-06-17 19:41   ` Alexander Smirnov
2018-06-18  7:04     ` Henning Schild
2018-06-14 12:01 ` Henning Schild
2018-06-14 12:04 ` Claudius Heine
2018-06-14 12:24   ` Henning Schild
2018-06-14 12:36     ` Claudius Heine
2018-06-14 12:30   ` Jan Kiszka
2018-06-14 12:42     ` Claudius Heine
2018-06-14 12:55       ` Claudius Heine
2018-06-15 10:50   ` Alexander Smirnov
2018-06-15 13:17     ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615111154.GE24273@azat.radix50.net \
    --to=asmirnov@ilbers.de \
    --cc=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox