From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6581862148598661120 X-Received: by 2002:aa7:d301:: with SMTP id p1-v6mr2328363edq.2.1532506463054; Wed, 25 Jul 2018 01:14:23 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:9b0c:: with SMTP id o12-v6ls2525297edi.3.gmail; Wed, 25 Jul 2018 01:14:22 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcjamV8B1dgStT7c/eJF34tbx9xr33JIaCvQmcmBzJI+2L9s3idPR7T9KW8sLXZVkDdQens X-Received: by 2002:aa7:c4d0:: with SMTP id p16-v6mr892218edr.10.1532506462704; Wed, 25 Jul 2018 01:14:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1532506462; cv=none; d=google.com; s=arc-20160816; b=Tqaxz2stJsezWT82UA2BF2FeI3CVD02bq3ejGzz1VS7ZIzRoRI5/121ODNDrhbRic7 A17+rGMQP37esG1V9tSePD1ICakZmxv4NFoi6tACaEqePHOA4dHXU8AnVibn0i5PRVCv 4qPrFX8SOwzVTzFnCOyG2q6aePEm8GurNTJVrFqwLzk++WsKkn5kTphjEm7BfNg4dY87 zYFr+Bd6kXX4WGemxGv8Thlk7mxtFdrKOtvKwwTTynI+WdPG8fkZ/Ivb526XfqIF703b +x2YKuKCqqZHCIvjnC3mhXiL4g9sMdgmo7Dxw46qcOVifMk8hzm4pJjBrFcBmZL412tQ Uf9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:arc-authentication-results; bh=OsM026OTAexeiY9HUBmCIA/fqOXFQXd4jYeNSA+bD/o=; b=q/l2cL0FEVTVJMJ+m1hZa/sEuhyH9oIXZmKXAvrWcNSqeSVL9L8Su0W3P+hu6rkyZz lWvvz7PUuwvw2yjtFjwdVjfuB0SL4kCjCWPW7lefc7qHz1Uc70tIxC9J32iFmt+ljFW7 mIcFh39Iaq1NmcBG6mlMvKJRk1y6pzGEFNogMsa8Sbw44V/Dr5FkEqgaiNd1BbiRZ2lf r5DJZmGeqn7xMFIjrLxh7Vw8rP6RoBKKPuVKTouaCSbSE7IQj7Pz3VEQLbTHBzzoqv7R mAmFRL0feBB8l7KlNUbWnQgcDvtsPTBEUsurEU8m+Qpbqc7hcUFBJLqrZzIJdt8dtl4h C6PA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id k9-v6si33511edh.1.2018.07.25.01.14.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jul 2018 01:14:22 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id w6P8EM4x025170 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Jul 2018 10:14:22 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id w6P8EL0k027874; Wed, 25 Jul 2018 10:14:21 +0200 Date: Wed, 25 Jul 2018 10:14:21 +0200 From: Henning Schild To: Alexander Smirnov Cc: Subject: Re: [PATCH v4 03/10] build.sh: Add additional parameter Message-ID: <20180725101421.14883b06@md1pvb1c.ad001.siemens.net> In-Reply-To: <20180724190618.19155-4-asmirnov@ilbers.de> References: <20180724190618.19155-1-asmirnov@ilbers.de> <20180724190618.19155-4-asmirnov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: sbTs7mbnBvKm Am Tue, 24 Jul 2018 22:06:11 +0300 schrieb Alexander Smirnov : > Pass target architecture as a parameter for build. > > Signed-off-by: Alexander Smirnov > --- > meta/recipes-devtools/buildchroot/files/build.sh | 17 > +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-devtools/buildchroot/files/build.sh > b/meta/recipes-devtools/buildchroot/files/build.sh index > 73c0889..40ba410 100644 --- > a/meta/recipes-devtools/buildchroot/files/build.sh +++ > b/meta/recipes-devtools/buildchroot/files/build.sh @@ -6,6 +6,19 @@ > > set -e > > +# Create human-readable names > +target_arch=$2 > + > +# Notes: > +# mk-build-deps for jessie and jtretch has different parameter > name to specify +# host architecture. > +debian_version=$(cat /etc/debian_version | cut -c 1) > +if [ $(($debian_version)) -ge 9 ]; then > + set_arch="--host-arch $target_arch" > +else > + set_arch="-a $target_arch" > +fi The way i understand this patch, all callers will have to be updated as well. Otherwise this patch (applied without the following) breaks the build. Henning > # Go to build directory > cd $1 > > @@ -36,7 +49,7 @@ install_cmd="apt-get -o > Debug::pkgProblemResolver=yes --no-install-recommends -y -o > APT::Get::List-Cleanup="0" > # Install all build deps > - mk-build-deps -t "${install_cmd}" -i -r debian/control > + mk-build-deps $set_arch -t "${install_cmd}" -i -r debian/control > ) 42>/dpkg.lock > > # If autotools files have been created, update their timestamp to > @@ -48,4 +61,4 @@ for i in configure aclocal.m4 Makefile.am > Makefile.in; do done > > # Build the package > -dpkg-buildpackage > +dpkg-buildpackage -a$target_arch