public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Maxim Yu. Osipov" <mosipov@ilbers.de>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH 1/2] isar-bootstrap: Fix gpg error file name too long
Date: Mon, 13 Aug 2018 10:16:42 +0200	[thread overview]
Message-ID: <20180813101642.2e3cd581@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <20180810103150.28342-2-mosipov@ilbers.de>

Am Fri, 10 Aug 2018 12:31:49 +0200
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> Change homedir to DL_DIR to workaround gpg failure "File name too
> long".
> 
> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index
> 8afd470..5c90713 100644 ---
> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -138,13
> +138,13 @@ def get_distro_components_argument(d, is_host): else:
>          return ""
>  
> -do_generate_keyring[dirs] = "${WORKDIR}"
> +do_generate_keyring[dirs] = "${DL_DIR}"
>  do_generate_keyring[vardeps] += "DISTRO_APT_KEYS"
>  do_generate_keyring() {
>      if [ -n "${@d.getVar("APTKEYFILES", True) or ""}" ]; then
>          for keyfile in ${@d.getVar("APTKEYFILES", True)}; do
>             gpg --no-default-keyring --keyring "${APTKEYRING}" \
> -               --homedir "${WORKDIR}" --import "$keyfile"
> +               --homedir "${DL_DIR}"  --import "$keyfile"
>          done
>      fi
>  }

I would suggest "${TMPDIR}/gnupg" instead. Files that we keep in there
are not downloaded, so DL_DIR seems incorrect.

Henning

  reply	other threads:[~2018-08-13  8:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 10:31 [PATCH 0/2] Various bug fixes Maxim Yu. Osipov
2018-08-10 10:31 ` [PATCH 1/2] isar-bootstrap: Fix gpg error file name too long Maxim Yu. Osipov
2018-08-13  8:16   ` Henning Schild [this message]
2018-08-27 22:07   ` Maxim Yu. Osipov
2018-08-10 10:31 ` [PATCH 2/2] isar-bootstrap: exit if command fails under flock Maxim Yu. Osipov
2018-08-11 15:52   ` Jan Kiszka
2018-08-12  8:46     ` Maxim Yu. Osipov
2018-08-13  8:34       ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813101642.2e3cd581@md1pvb1c.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox