From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 3/4] linux-custom: Use uncompressed kernel image on arm64
Date: Mon, 27 Aug 2018 10:29:14 +0200 [thread overview]
Message-ID: <20180827102914.236a4db0@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <2eade0f587dfb3c7b7771722bfc345058dc68776.1535354395.git.jan.kiszka@siemens.com>
Am Mon, 27 Aug 2018 09:19:54 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> U-Boot does not directly support decompression on bootloader side like
> Image.gz would require. We would have to enable the unzip command and
> write special scripts that perform the decompression prior to calling
> booti. As the Debian kernel also comes uncompressed, choose that path
> instead.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh
> b/meta/recipes-kernel/linux/files/build-kernel.sh index
> 8b58e93..ef30aea 100644 ---
> a/meta/recipes-kernel/linux/files/build-kernel.sh +++
> b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -95,6 +95,13 @@
> if [ \"\$1\" != upgrade ] && command -v linux-update-symlinks
> >/dev/null; then\\ linux-update-symlinks remove
> >${PV} /boot/vmlinuz-${PV}\\ fi"
>
> +# Make sure arm64 kernels are decompressed
> +if [ "$target_arch" = "arm64" ]; then
> + vmlinuz=${REPACK_LINUX_IMAGE_DIR}/boot/vmlinuz-${PV}
> + mv $vmlinuz $vmlinuz.gz
> + gunzip $vmlinuz
> +fi
That looks weird. The gunzip should not work after the mv. And would is
the filename after the intended patch? If it still contains a "z", that
would be misleading.
Henning
> dpkg-gencontrol -crepack/debian/control \
> -lrepack/debian/changelog \
> -frepack/debian/files \
next prev parent reply other threads:[~2018-08-27 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 7:19 [PATCH 0/4] arm64-related fixes & more Jan Kiszka
2018-08-27 7:19 ` [PATCH 1/4] u-boot-script: Fix bashism Jan Kiszka
2018-08-27 7:19 ` [PATCH 2/4] u-boot-script: Fix root partition detection Jan Kiszka
2018-08-27 7:19 ` [PATCH 3/4] linux-custom: Use uncompressed kernel image on arm64 Jan Kiszka
2018-08-27 8:29 ` Henning Schild [this message]
2018-08-27 8:31 ` Jan Kiszka
2018-08-27 13:37 ` Jan Kiszka
2018-08-27 13:45 ` [PATCH v2 " Jan Kiszka
2018-08-27 7:19 ` [PATCH 4/4] buildchroot: Pass -I down to dpkg-source Jan Kiszka
2018-08-28 12:15 ` [PATCH 0/4] arm64-related fixes & more Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827102914.236a4db0@md1pvb1c.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox