* [PATCH] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals
@ 2018-09-05 7:18 claudius.heine.ext
2018-09-05 9:13 ` [PATCH v2] " claudius.heine.ext
0 siblings, 1 reply; 3+ messages in thread
From: claudius.heine.ext @ 2018-09-05 7:18 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/classes/image.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 6a5f0e9..e62b834 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -75,7 +75,7 @@ do_rootfs[deptask] = "do_deploy_deb"
do_mark_rootfs() {
update_etc_os_release \
- --build-id $(get_build_id) --variant "${DESCRIPTION}" \
+ --build-id "$(get_build_id)" --variant "${DESCRIPTION}" \
"${IMAGE_ROOTFS}"
}
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals
2018-09-05 7:18 [PATCH] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals claudius.heine.ext
@ 2018-09-05 9:13 ` claudius.heine.ext
2018-09-06 20:47 ` Maxim Yu. Osipov
0 siblings, 1 reply; 3+ messages in thread
From: claudius.heine.ext @ 2018-09-05 9:13 UTC (permalink / raw)
To: isar-users; +Cc: Claudius Heine
From: Claudius Heine <ch@denx.de>
Directly using `get_build_id` inside quotes resulted in an empty string,
so we take the detour via a variable.
Signed-off-by: Claudius Heine <ch@denx.de>
---
meta/classes/image.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 6a5f0e9..ad78347 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -74,8 +74,9 @@ addtask rootfs before do_build after do_unpack
do_rootfs[deptask] = "do_deploy_deb"
do_mark_rootfs() {
+ BUILD_ID=$(get_build_id)
update_etc_os_release \
- --build-id $(get_build_id) --variant "${DESCRIPTION}" \
+ --build-id "${BUILD_ID}" --variant "${DESCRIPTION}" \
"${IMAGE_ROOTFS}"
}
--
2.18.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals
2018-09-05 9:13 ` [PATCH v2] " claudius.heine.ext
@ 2018-09-06 20:47 ` Maxim Yu. Osipov
0 siblings, 0 replies; 3+ messages in thread
From: Maxim Yu. Osipov @ 2018-09-06 20:47 UTC (permalink / raw)
To: claudius.heine.ext, isar-users; +Cc: Claudius Heine
On 09/05/2018 11:13 AM, claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
>
> Directly using `get_build_id` inside quotes resulted in an empty string,
> so we take the detour via a variable.
Applied to the 'next',
Thanks,
Maxim.
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
> meta/classes/image.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 6a5f0e9..ad78347 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -74,8 +74,9 @@ addtask rootfs before do_build after do_unpack
> do_rootfs[deptask] = "do_deploy_deb"
>
> do_mark_rootfs() {
> + BUILD_ID=$(get_build_id)
> update_etc_os_release \
> - --build-id $(get_build_id) --variant "${DESCRIPTION}" \
> + --build-id "${BUILD_ID}" --variant "${DESCRIPTION}" \
> "${IMAGE_ROOTFS}"
> }
>
>
--
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-06 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 7:18 [PATCH] image.bbclass: allow ISAR_RELEASE_CMD that produce space seperated vals claudius.heine.ext
2018-09-05 9:13 ` [PATCH v2] " claudius.heine.ext
2018-09-06 20:47 ` Maxim Yu. Osipov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox