public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>,
	Andreas Reichel <Andreas.Reichel@tngtech.com>
Subject: Re: [PATCH] meta-isar: Fix sdimage-efi wic script
Date: Fri, 7 Sep 2018 19:52:22 +0200	[thread overview]
Message-ID: <20180907195222.33e1b7a4@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <3b047a67-7b34-49db-aeca-4cbbe0259ecc@siemens.com>

Am Fri, 7 Sep 2018 15:02:52 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> In order to have the EFI partition reliably detected as such, we need
> to set the right type.
> 
> And as we are using GPT, the legacy boot flag plays no role anymore.

Could you check how the most recent wic in OE deals with that? I would
like to keep the local diffs in the forked files as small as possible.

So if they have the same or a similar fix, we should just bump wic and
merge our forked files.

Henning
 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks
> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks index
> 580ad21..7aba8e3 100644 ---
> a/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks +++
> b/meta-isar/scripts/lib/wic/canned-wks/sdimage-efi.wks @@ -2,7 +2,7 @@
>  # long-description: Creates a partitioned EFI disk image without any
> swap that # the user can directly dd to boot media.
>  
> -part /boot --source bootimg-efi-isar
> --sourceparams="loader=grub-efi" --ondisk sda --label msdos --active
> --align 1024 +part /boot --source bootimg-efi-isar
> --sourceparams="loader=grub-efi" --ondisk sda --label efi
> --part-type=EF00 --align 1024 part / --source rootfs --ondisk sda
> --fstype=ext4 --label platform --align 1024 --use-uuid 


  reply	other threads:[~2018-09-07 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 13:02 Jan Kiszka
2018-09-07 17:52 ` Henning Schild [this message]
2018-09-07 17:58   ` Jan Kiszka
2018-09-11  8:34 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180907195222.33e1b7a4@md1pvb1c.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=Andreas.Reichel@tngtech.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox