From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 03/16] meta-isar: Fix bananapi root disk specification
Date: Wed, 12 Sep 2018 10:59:56 +0200 [thread overview]
Message-ID: <20180912105956.3feacdaa@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <20180912105724.756697e5@md1pvb1c.ad001.siemens.net>
Am Wed, 12 Sep 2018 10:57:24 +0200
schrieb "[ext] Henning Schild" <henning.schild@siemens.com>:
> Am Tue, 11 Sep 2018 14:05:43 +0200
> schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
>
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > ...and remove the unneeded --ondisk parameter from the bootloader
> > section.
> >
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > meta-isar/scripts/lib/wic/canned-wks/bananapi.wks | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks
> > b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks index
> > d60868a..10cb7ae 100644 ---
> > a/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks +++
> > b/meta-isar/scripts/lib/wic/canned-wks/bananapi.wks @@ -1,5 +1,5 @@
> > -part u-boot --source rawcopy
> > --sourceparams="file=/usr/lib/u-boot/Bananapi/u-boot-sunxi-with-spl.bin"
> > --ondisk mmcblk --no-table --align 8 +part u-boot --source rawcopy
> > --sourceparams="file=/usr/lib/u-boot/Bananapi/u-boot-sunxi-with-spl.bin"
> > --no-table --align 8 -part / --source rootfs --ondisk mmcblk
> > --fstype=ext4 --label platform --align 1024 +part / --source rootfs
> > --ondisk mmcblk0 --fstype=ext4 --label platform --align 1024
> > bootloader --append="rootwait"
>
> You might want to drop the "=" for consistency, also with the previous
> patch.
Ok, i did not read the whole series ... The next commit does exactly
that.
Henning
> Henning
>
next prev parent reply other threads:[~2018-09-12 8:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 12:05 [PATCH 00/16] Cleanups, linux-custom fix, auto-expansion helper Jan Kiszka
2018-09-11 12:05 ` [PATCH 01/16] meta-isar: Adjust kernel params in sdimage-efi.wks Jan Kiszka
2018-09-11 12:05 ` [PATCH 02/16] meta-isar: Reduce grub timeout to 3 seconds Jan Kiszka
2018-09-11 12:05 ` [PATCH 03/16] meta-isar: Fix bananapi root disk specification Jan Kiszka
2018-09-12 8:57 ` Henning Schild
2018-09-12 8:59 ` Henning Schild [this message]
2018-09-11 12:05 ` [PATCH 04/16] meta-isar: Remove "=" after wic parameters Jan Kiszka
2018-09-11 12:05 ` [PATCH 05/16] u-boot-script: Become independent of target /etc/fstab Jan Kiszka
2018-09-11 12:05 ` [PATCH 06/16] isar-image-base: Disable rootfs check by default Jan Kiszka
2018-09-11 12:05 ` [PATCH 07/16] isar-image-base: Use generic parameters for rootfs entry in fstab Jan Kiszka
2018-09-11 12:05 ` [PATCH 08/16] meta: Remove ROOTFS_TYPE Jan Kiszka
2018-09-11 12:05 ` [PATCH 09/16] start_vm: Rename QEMU_ROOTFS_DEV to QEMU_DISK_ARGS Jan Kiszka
2018-09-11 12:05 ` [PATCH 10/16] start_vm: Rename ROOTFS_DEV to QEMU_ROOTFS_DEV Jan Kiszka
2018-09-11 12:05 ` [PATCH 11/16] RECIPE-API-CHANGELOG: Add ROOTFS_DEV/TYPE removal Jan Kiszka
2018-09-11 12:05 ` [PATCH 12/16] meta: Add expand-on-first-boot support package Jan Kiszka
2018-09-12 13:46 ` Henning Schild
2018-09-13 8:33 ` Jan Kiszka
2018-09-13 9:30 ` Henning Schild
2018-09-13 13:17 ` Jan Kiszka
2018-09-11 12:05 ` [PATCH 13/16] image: Limit ROOTFS_EXTRA to non-wic image type Jan Kiszka
2018-09-11 12:05 ` [PATCH 14/16] linux-custom: Simplify and clarify KERNEL_NAME-to-recipe matching Jan Kiszka
2018-09-11 12:05 ` [PATCH 15/16] meta-isar: Move init preinstallation into distro conf Jan Kiszka
2018-09-11 12:05 ` [PATCH 16/16] meta: Add enable-fsck helper recipe Jan Kiszka
2018-09-25 11:27 ` [PATCH 00/16] Cleanups, linux-custom fix, auto-expansion helper Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912105956.3feacdaa@md1pvb1c.ad001.siemens.net \
--to=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
--cc=jan.kiszka@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox