Re: [PATCH v3 1/4] kernel/module: Add AUTOLOAD option

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 7 Mar 2018 13:46:55 +0300
schrieb Alexander Smirnov <asmirnov@ilbers.de>:

> Add possibility to set kernel module to be autoloaded.
> File '/etc/modules' is created by kmod package, which is dependency of
> kernel image, so there is no need to add explicit deps to kernel
> module.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  meta/recipes-kernel/linux-module/files/debian/control | 2 +-
>  meta/recipes-kernel/linux-module/module.inc           | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux-module/files/debian/control
> b/meta/recipes-kernel/linux-module/files/debian/control index
> 707f857..1ee634c 100644 ---
> a/meta/recipes-kernel/linux-module/files/debian/control +++
> b/meta/recipes-kernel/linux-module/files/debian/control @@ -7,5 +7,5
> @@ Maintainer: ISAR project <isar-users@googlegroups.com> 
>  Package: @PN@
>  Architecture: any
> -Depends: linux-image-@KERNEL_NAME@
> +Depends: linux-image-@KERNEL_NAME@, kmod
>  Description: @DESCRIPTION@
> diff --git a/meta/recipes-kernel/linux-module/module.inc
> b/meta/recipes-kernel/linux-module/module.inc index aa232f7..ec1c4b0
> 100644 --- a/meta/recipes-kernel/linux-module/module.inc
> +++ b/meta/recipes-kernel/linux-module/module.inc
> @@ -13,6 +13,8 @@ DEPENDS += "linux-headers-${KERNEL_NAME}"
>  
>  SRC_URI += "file://debian/"
>  
> +AUTOLOAD ?= "0"
> +
>  inherit dpkg
>  
>  dpkg_runbuild_prepend() {
> @@ -21,4 +23,9 @@ dpkg_runbuild_prepend() {
>             -e 's/@KERNEL_NAME@/${KERNEL_NAME}/g' \
>             -e 's/@DESCRIPTION@/${DESCRIPTION}/g' \
>          ${WORKDIR}/${S}/debian/changelog
> ${WORKDIR}/${S}/debian/control +
> +    if [ ${AUTOLOAD} = "1" ]; then
> +        echo "echo ${PN} >> /etc/modules" >>
> ${WORKDIR}/${S}/debian/postinst
> +        chmod +x ${WORKDIR}/${S}/debian/postinst
> +    fi
>  }

The current approach is broken because the script is not idempotent.
Uninstalling the package will not unpatch /etc/modules. And installing
a second time will result in a second entry.

So we do need an extra postrm to make the package idempotent. And if we
are on systemd, we should create /etc/modules-load.d/ instead. (detect
systemd at post(rm|inst) runtime).

Henning 

Henning