public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] linux-custom: Add kmod to build dependencies
Date: Thu, 27 Sep 2018 09:36:05 +0200	[thread overview]
Message-ID: <20180927093605.578a2e80@md1pvb1c.ad001.siemens.net> (raw)
In-Reply-To: <8955f5c1-5ad5-4221-6309-1e088affa036@siemens.com>

Am Wed, 26 Sep 2018 19:04:03 +0200
schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:

> On 26.09.18 18:53, [ext] Jan Kiszka wrote:
> > Recent kernels check if depmod is available and fail if not.
> >   
> 
> Just found out that it should be just "certain recent kernels": Our
> current CIP kernel 4.4.154-cip28 carries the commit that introduced
> that behavior while a later commit (part of 4.4.156) changes that
> into a warning again. We could live without this patch from that POV,
> but it should also cause no harm. The for us relevant depmod run
> continues to happen during installation of the generated package.

I think we should add that, given there are releases that do need it.
It could be added in a separate += line, together with a comment.

And how about bumping the cip kernel in Isar along with this patch?

Henning

> Jan
> 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> >   meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> > b/meta/recipes-kernel/linux/linux-custom.inc index 10a50c3..d7595e4
> > 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc
> > +++ b/meta/recipes-kernel/linux/linux-custom.inc
> > @@ -22,7 +22,7 @@ inherit dpkg-base
> >   
> >   SRC_URI += "file://build-kernel.sh"
> >   
> > -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git"
> > +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git kmod"
> >   KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool,
> > kmod, linux-base (>= 4.3~)" KERNEL_HEADERS_DEBIAN_DEPENDS ?=
> > "libc6, libssl1.1" 
> >   
> 


  reply	other threads:[~2018-09-27  7:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-26 16:53 Jan Kiszka
2018-09-26 17:04 ` Jan Kiszka
2018-09-27  7:36   ` Henning Schild [this message]
2018-09-27  7:39     ` Jan Kiszka
2018-09-27  8:13       ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180927093605.578a2e80@md1pvb1c.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox