Re: [PATCH] linux-custom: Add kmod to build dependencies

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 27 Sep 2018 09:39:23 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 27.09.18 09:36, Henning Schild wrote:
> > Am Wed, 26 Sep 2018 19:04:03 +0200
> > schrieb "[ext] Jan Kiszka" <jan.kiszka@siemens.com>:
> >   
> >> On 26.09.18 18:53, [ext] Jan Kiszka wrote:  
> >>> Recent kernels check if depmod is available and fail if not.
> >>>      
> >>
> >> Just found out that it should be just "certain recent kernels": Our
> >> current CIP kernel 4.4.154-cip28 carries the commit that introduced
> >> that behavior while a later commit (part of 4.4.156) changes that
> >> into a warning again. We could live without this patch from that
> >> POV, but it should also cause no harm. The for us relevant depmod
> >> run continues to happen during installation of the generated
> >> package.  
> > 
> > I think we should add that, given there are releases that do need
> > it. It could be added in a separate += line, together with a
> > comment.  
> 
> I don't think there is a need for a separate line. I can tune the
> commit log to explain that only some kernels are affected.
> 
> Maxim, this is a candidate for the upcoming release.
> 
> > 
> > And how about bumping the cip kernel in Isar along with this
> > patch?  
> 
> That would be a separate patch. Simple to write, give me a minute.

I know, just wanted someone to invest that minute. The new recipe
should maybe have the PV in its filename and not contain the SRCREV
anymore (the PV should be a tag/SRCREV in the git we clone ... for
releases). Doing that, the next bump will become a "git mv".

Henning

> Jan
> 
> > 
> > Henning
> >   
> >> Jan
> >>  
> >>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >>> ---
> >>>    meta/recipes-kernel/linux/linux-custom.inc | 2 +-
> >>>    1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc
> >>> b/meta/recipes-kernel/linux/linux-custom.inc index
> >>> 10a50c3..d7595e4 100644 ---
> >>> a/meta/recipes-kernel/linux/linux-custom.inc +++
> >>> b/meta/recipes-kernel/linux/linux-custom.inc @@ -22,7 +22,7 @@
> >>> inherit dpkg-base 
> >>>    SRC_URI += "file://build-kernel.sh"
> >>>    
> >>> -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git"
> >>> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git kmod"
> >>>    KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools |
> >>> linux-initramfs-tool, kmod, linux-base (>= 4.3~)"
> >>> KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1"
> >>>      
> >>  
> >   
>