From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6605577273814810624 X-Received: by 2002:a1c:4b04:: with SMTP id y4-v6mr1096426wma.7.1538036028994; Thu, 27 Sep 2018 01:13:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fd4f:: with SMTP id h15-v6ls1784284wrs.11.gmail; Thu, 27 Sep 2018 01:13:48 -0700 (PDT) X-Google-Smtp-Source: ACcGV624zOWqE9uh7Z9tzlsvaAq229YvZAv09jT666pGEbsUvgKhrp+pq7tTUToxoB+EqZ7yzzZd X-Received: by 2002:adf:a647:: with SMTP id k65-v6mr975492wrc.29.1538036028754; Thu, 27 Sep 2018 01:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538036028; cv=none; d=google.com; s=arc-20160816; b=fPNYNZ4Rz9Eu9fVJHNEBFtB481U5qz8Uy42atSL37fTtxgi4e9DGQ2Faddm6b3wPMQ HHIL/eECv4e6tq5b9qMrSVbPUk7TATGT925aTdRG3vV6qKgXOVUDDxgTGIrWypRUdJq1 9PiVvGMR9vHbDaKxv4O58i7HioQJivO38tA2ShzZOXM4tLDMfta4N5tpgHrihXlFyuIy h4bzfp6fNNWDizZdleRAYWS79anGS6lZ3PtIEGiZO4q3VVfkra5PMu58i/9ZMjL2fFZC nlxNW4U4bNuKfXznxbGnYk+t8qkw8vu7NYLH+4+zAKqDO5eEKcE1NlaYLspuuHD79dZ3 uW1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=OJoDGfh1s2XY2bnKhQPVuGOnqqxnhCUtspmzi+HkYJE=; b=iVWNV7ZvBOUrLOrhOAqrHyXuvAKRsXnLzKPap2TFXknZ2QY8VZA9KQ4oRAb8fansb9 6t0zK9narqM5QC3s9/4Q2UjE/5OlWWAvJEAeYpHi/A27gHDOPFBaANLtrQu19VjFc/CH +WgANtcXcrVVGIbKQMsm56lsuFkOTh12DQQT+P7A7n5VJyI7GDjT/45BgCNChGyiGubN a3DelIUh0OBv40SLv7stdslBq01ZyG1tKoTlKbKLyTmOEjN7VBVyIglo/kFsHLWOR+zR v0IgcIyd1WgDpRFPbMoQ3x6BLZS0PsWhSD3CdNVznAQ61uJLGYdxmOGJ9UMOGf5xvlcn 6PIA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id q21-v6si249537wmf.3.2018.09.27.01.13.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Sep 2018 01:13:48 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w8R8Dm6J022668 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Sep 2018 10:13:48 +0200 Received: from md1pvb1c.ad001.siemens.net ([139.22.116.87]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTPS id w8R8DlGS031480 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 27 Sep 2018 10:13:47 +0200 Date: Thu, 27 Sep 2018 10:13:45 +0200 From: Henning Schild To: Jan Kiszka Cc: Maksim Osipov , isar-users Subject: Re: [PATCH] linux-custom: Add kmod to build dependencies Message-ID: <20180927101345.62a28b23@md1pvb1c.ad001.siemens.net> In-Reply-To: References: <2a829727-34c0-4207-9d26-7489eb977b6e@siemens.com> <8955f5c1-5ad5-4221-6309-1e088affa036@siemens.com> <20180927093605.578a2e80@md1pvb1c.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: KCZXcpRJY5ob Am Thu, 27 Sep 2018 09:39:23 +0200 schrieb Jan Kiszka : > On 27.09.18 09:36, Henning Schild wrote: > > Am Wed, 26 Sep 2018 19:04:03 +0200 > > schrieb "[ext] Jan Kiszka" : > > > >> On 26.09.18 18:53, [ext] Jan Kiszka wrote: > >>> Recent kernels check if depmod is available and fail if not. > >>> > >> > >> Just found out that it should be just "certain recent kernels": Our > >> current CIP kernel 4.4.154-cip28 carries the commit that introduced > >> that behavior while a later commit (part of 4.4.156) changes that > >> into a warning again. We could live without this patch from that > >> POV, but it should also cause no harm. The for us relevant depmod > >> run continues to happen during installation of the generated > >> package. > > > > I think we should add that, given there are releases that do need > > it. It could be added in a separate += line, together with a > > comment. > > I don't think there is a need for a separate line. I can tune the > commit log to explain that only some kernels are affected. > > Maxim, this is a candidate for the upcoming release. > > > > > And how about bumping the cip kernel in Isar along with this > > patch? > > That would be a separate patch. Simple to write, give me a minute. I know, just wanted someone to invest that minute. The new recipe should maybe have the PV in its filename and not contain the SRCREV anymore (the PV should be a tag/SRCREV in the git we clone ... for releases). Doing that, the next bump will become a "git mv". Henning > Jan > > > > > Henning > > > >> Jan > >> > >>> Signed-off-by: Jan Kiszka > >>> --- > >>> meta/recipes-kernel/linux/linux-custom.inc | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/meta/recipes-kernel/linux/linux-custom.inc > >>> b/meta/recipes-kernel/linux/linux-custom.inc index > >>> 10a50c3..d7595e4 100644 --- > >>> a/meta/recipes-kernel/linux/linux-custom.inc +++ > >>> b/meta/recipes-kernel/linux/linux-custom.inc @@ -22,7 +22,7 @@ > >>> inherit dpkg-base > >>> SRC_URI += "file://build-kernel.sh" > >>> > >>> -KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git" > >>> +KBUILD_DEPENDS ?= "libssl-dev libelf-dev bc git kmod" > >>> KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | > >>> linux-initramfs-tool, kmod, linux-base (>= 4.3~)" > >>> KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, libssl1.1" > >>> > >> > > >