public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Cc: Henning Schild <henning.schild@siemens.com>
Subject: [PATCH] recipes-app: rename example app and lib recipe to contain PV
Date: Tue,  2 Oct 2018 20:17:10 +0200	[thread overview]
Message-ID: <20181002181710.28456-1-henning.schild@siemens.com> (raw)

The PV of a package is best contained in its filename, that way a
version bump would be chaning the file name. Also switch to using the
git tag as SRCREV, now we can really just rename that file to update.

Following that pattern we could also have multiple versions of the
recipe in one tree.

While we do not need all of this for Isar or for this simple example, be
a good example for people reading those recipes.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../example-hello/{example-hello.bb => example-hello_0.2.bb}  | 4 +---
 .../recipes-app/libhello/{libhello.bb => libhello_0.1.bb}     | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
 rename meta-isar/recipes-app/example-hello/{example-hello.bb => example-hello_0.2.bb} (89%)
 rename meta-isar/recipes-app/libhello/{libhello.bb => libhello_0.1.bb} (83%)

diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb
similarity index 89%
rename from meta-isar/recipes-app/example-hello/example-hello.bb
rename to meta-isar/recipes-app/example-hello/example-hello_0.2.bb
index d23ee6c..c03d5e1 100644
--- a/meta-isar/recipes-app/example-hello/example-hello.bb
+++ b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb
@@ -8,8 +8,6 @@ DESCRIPTION = "Sample application for ISAR"
 LICENSE = "gpl-2.0"
 LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe"
 
-PV = "0.2-86cc719"
-
 # NOTE: the following line duplicates the content in 'debian/control', but
 #       for now it's the only way to correctly build bitbake pipeline.
 DEPENDS += "libhello"
@@ -18,6 +16,6 @@ SRC_URI = " \
     git://github.com/ilbers/hello.git;protocol=https;destsuffix=${P} \
     file://0001-Add-some-help.patch \
     file://yet-another-change.txt;apply=yes;striplevel=0"
-SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3"
+SRCREV = "v${PV}"
 
 inherit dpkg
diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello_0.1.bb
similarity index 83%
rename from meta-isar/recipes-app/libhello/libhello.bb
rename to meta-isar/recipes-app/libhello/libhello_0.1.bb
index 4e75f98..3ccd57b 100644
--- a/meta-isar/recipes-app/libhello/libhello.bb
+++ b/meta-isar/recipes-app/libhello/libhello_0.1.bb
@@ -8,9 +8,7 @@ DESCRIPTION = "Sample shared library for ISAR"
 LICENSE = "gpl-2.0"
 LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe"
 
-PV = "0.1-98f2e41"
-
 SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}"
-SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93"
+SRCREV = "v${PV}"
 
 inherit dpkg
-- 
2.19.0


             reply	other threads:[~2018-10-02 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02 18:17 Henning Schild [this message]
2018-10-02 20:35 ` Jan Kiszka
2018-10-04  8:07   ` Henning Schild

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002181710.28456-1-henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox