From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6607825373868589056 X-Received: by 2002:a2e:5ddc:: with SMTP id v89-v6mr502153lje.8.1538504234666; Tue, 02 Oct 2018 11:17:14 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9c58:: with SMTP id t24-v6ls437440ljj.8.gmail; Tue, 02 Oct 2018 11:17:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV62RQdocH6sS5znopjf7d34ceYS3BFhby+80QkV8ZvGGR3WXlmdmBckIV7Srl3d808C7RcnR X-Received: by 2002:a2e:9643:: with SMTP id z3-v6mr485271ljh.10.1538504234036; Tue, 02 Oct 2018 11:17:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538504234; cv=none; d=google.com; s=arc-20160816; b=e7xZyC+rBH8NCPjTV3919ODB0FfUEwuGvsq/6qqtsBIOYwAu33BkAMpc54YaDM+M1i onzlIyYhzXGAk1pxTkAs3Hv06f3JZkDDuMWTyDiXSt+XIeRpREzmSqOe5PD7fAdD++ke P7Q6p20k1c5FfL+VabYXzync9Xt3/Yd/8FWb1ld4dnt1mLo3m2BwIegg11U0ZU2AtKGL 3HIAqki1274wcFfC8YzxZNaybLzm/lpQUIAISxH6hoFoDnAbnAhdWmygbzIWyWBEIq3t qc7FDmJZNlwsyeYsfsbcG8tidx+Hv6fJeridYvmDSH1HSITWpg6A6L+bK9zkYJLJNGDc 0lCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=lRTaV7xN0aBzOOB04EAamNZNbLXCwDYa5AGj3syOm5A=; b=jEroFAYK1Hf2yJ3tMiF/gcQh3BxyJls8kgoI/BYx8cQMWSDrRrr61LYasYZKgNy1GW v67WoOxqpxMMULctIWxpNqq8bOpwQ+PUneYQZOBvYlUP6KaliFMAbVR/BzUjATWzbfWy x9tHSRX7vj9Anp/qqlLOH/MfHQAvpCVF34BWrztFeXjNOfZRxvpiyteJQizEk1FiR7ed RauP636YeeAf/QYfmSoY4oxmgcKShXo1C59r1T4hJ1e/yGE/admu2svSvFEa6zht9gXx byiIiD/PbPWNT5LboLAeKvvzmpayk4CNEpdl5BNBZwr8FWmwC3Ika6ltu3e5uf6xOAmy n4TA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id h192-v6si497855lfg.1.2018.10.02.11.17.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Oct 2018 11:17:13 -0700 (PDT) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w92IHCxv008228 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 2 Oct 2018 20:17:13 +0200 Received: from md1pvb1c.ad001.siemens.net (md1pvb1c.ad001.siemens.net [139.25.68.40]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id w92IHCgs023247; Tue, 2 Oct 2018 20:17:12 +0200 From: Henning Schild To: isar-users Cc: Henning Schild Subject: [PATCH] recipes-app: rename example app and lib recipe to contain PV Date: Tue, 2 Oct 2018 20:17:10 +0200 Message-Id: <20181002181710.28456-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: BYFnS+h3JwaY The PV of a package is best contained in its filename, that way a version bump would be chaning the file name. Also switch to using the git tag as SRCREV, now we can really just rename that file to update. Following that pattern we could also have multiple versions of the recipe in one tree. While we do not need all of this for Isar or for this simple example, be a good example for people reading those recipes. Signed-off-by: Henning Schild --- .../example-hello/{example-hello.bb => example-hello_0.2.bb} | 4 +--- .../recipes-app/libhello/{libhello.bb => libhello_0.1.bb} | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) rename meta-isar/recipes-app/example-hello/{example-hello.bb => example-hello_0.2.bb} (89%) rename meta-isar/recipes-app/libhello/{libhello.bb => libhello_0.1.bb} (83%) diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb similarity index 89% rename from meta-isar/recipes-app/example-hello/example-hello.bb rename to meta-isar/recipes-app/example-hello/example-hello_0.2.bb index d23ee6c..c03d5e1 100644 --- a/meta-isar/recipes-app/example-hello/example-hello.bb +++ b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb @@ -8,8 +8,6 @@ DESCRIPTION = "Sample application for ISAR" LICENSE = "gpl-2.0" LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe" -PV = "0.2-86cc719" - # NOTE: the following line duplicates the content in 'debian/control', but # for now it's the only way to correctly build bitbake pipeline. DEPENDS += "libhello" @@ -18,6 +16,6 @@ SRC_URI = " \ git://github.com/ilbers/hello.git;protocol=https;destsuffix=${P} \ file://0001-Add-some-help.patch \ file://yet-another-change.txt;apply=yes;striplevel=0" -SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3" +SRCREV = "v${PV}" inherit dpkg diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello_0.1.bb similarity index 83% rename from meta-isar/recipes-app/libhello/libhello.bb rename to meta-isar/recipes-app/libhello/libhello_0.1.bb index 4e75f98..3ccd57b 100644 --- a/meta-isar/recipes-app/libhello/libhello.bb +++ b/meta-isar/recipes-app/libhello/libhello_0.1.bb @@ -8,9 +8,7 @@ DESCRIPTION = "Sample shared library for ISAR" LICENSE = "gpl-2.0" LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe" -PV = "0.1-98f2e41" - SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}" -SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93" +SRCREV = "v${PV}" inherit dpkg -- 2.19.0