[PATCH] recipes-app: rename example app and lib recipe to contain PV

[PATCH] recipes-app: rename example app and lib recipe to contain PV

[Henning Schild]

The PV of a package is best contained in its filename, that way a
version bump would be chaning the file name. Also switch to using the
git tag as SRCREV, now we can really just rename that file to update.

Following that pattern we could also have multiple versions of the
recipe in one tree.

While we do not need all of this for Isar or for this simple example, be
a good example for people reading those recipes.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 .../example-hello/{example-hello.bb => example-hello_0.2.bb}  | 4 +---
 .../recipes-app/libhello/{libhello.bb => libhello_0.1.bb}     | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
 rename meta-isar/recipes-app/example-hello/{example-hello.bb => example-hello_0.2.bb} (89%)
 rename meta-isar/recipes-app/libhello/{libhello.bb => libhello_0.1.bb} (83%)

diff --git a/meta-isar/recipes-app/example-hello/example-hello.bb b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb
similarity index 89%
rename from meta-isar/recipes-app/example-hello/example-hello.bb
rename to meta-isar/recipes-app/example-hello/example-hello_0.2.bb
index d23ee6c..c03d5e1 100644
--- a/meta-isar/recipes-app/example-hello/example-hello.bb
+++ b/meta-isar/recipes-app/example-hello/example-hello_0.2.bb
@@ -8,8 +8,6 @@ DESCRIPTION = "Sample application for ISAR"
 LICENSE = "gpl-2.0"
 LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe"
 
-PV = "0.2-86cc719"
-
 # NOTE: the following line duplicates the content in 'debian/control', but
 #       for now it's the only way to correctly build bitbake pipeline.
 DEPENDS += "libhello"
@@ -18,6 +16,6 @@ SRC_URI = " \
     git://github.com/ilbers/hello.git;protocol=https;destsuffix=${P} \
     file://0001-Add-some-help.patch \
     file://yet-another-change.txt;apply=yes;striplevel=0"
-SRCREV = "86cc719b3359adc3c4e243387feba50360a860f3"
+SRCREV = "v${PV}"
 
 inherit dpkg
diff --git a/meta-isar/recipes-app/libhello/libhello.bb b/meta-isar/recipes-app/libhello/libhello_0.1.bb
similarity index 83%
rename from meta-isar/recipes-app/libhello/libhello.bb
rename to meta-isar/recipes-app/libhello/libhello_0.1.bb
index 4e75f98..3ccd57b 100644
--- a/meta-isar/recipes-app/libhello/libhello.bb
+++ b/meta-isar/recipes-app/libhello/libhello_0.1.bb
@@ -8,9 +8,7 @@ DESCRIPTION = "Sample shared library for ISAR"
 LICENSE = "gpl-2.0"
 LIC_FILES_CHKSUM = "file://${LAYERDIR_isar}/licenses/COPYING.GPLv2;md5=751419260aa954499f7abaabaa882bbe"
 
-PV = "0.1-98f2e41"
-
 SRC_URI = "git://github.com/ilbers/libhello.git;protocol=https;destsuffix=${P}"
-SRCREV = "98f2e41e7d05ab8d19b0c5d160b104b725c8fd93"
+SRCREV = "v${PV}"
 
 inherit dpkg
-- 
2.19.0

Re: [PATCH] recipes-app: rename example app and lib recipe to contain PV

[Jan Kiszka]

On 02.10.18 20:17, [ext] Henning Schild wrote:
> The PV of a package is best contained in its filename, that way a
> version bump would be chaning the file name. Also switch to using the
> git tag as SRCREV, now we can really just rename that file to update.
> 
> Following that pattern we could also have multiple versions of the
> recipe in one tree.
> 
> While we do not need all of this for Isar or for this simple example, be
> a good example for people reading those recipes.

NACK for the SRCREV changes.

That's an OE anti-pattern, (almost) like specifying a branch and ${AUTOREV}. You 
need some sort of checksum (md5, sha256 for files, SHA1 for git commits) to 
validate no one moved the upstream tag around.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

Re: [PATCH] recipes-app: rename example app and lib recipe to contain PV

[Henning Schild]

Am Tue, 2 Oct 2018 22:35:59 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 02.10.18 20:17, [ext] Henning Schild wrote:
> > The PV of a package is best contained in its filename, that way a
> > version bump would be chaning the file name. Also switch to using
> > the git tag as SRCREV, now we can really just rename that file to
> > update.
> > 
> > Following that pattern we could also have multiple versions of the
> > recipe in one tree.
> > 
> > While we do not need all of this for Isar or for this simple
> > example, be a good example for people reading those recipes.  
> 
> NACK for the SRCREV changes.
> 
> That's an OE anti-pattern, (almost) like specifying a branch and
> ${AUTOREV}. You need some sort of checksum (md5, sha256 for files,
> SHA1 for git commits) to validate no one moved the upstream tag
> around.

I see, if we do not trust upstream in keeping the tags intact, i guess
the whole patch can be dropped.

Henning

> Jan
>