Re: [PATCH 9/9] doc: Creation of local apt repo caching upstream Debian packages

[Baurzhan Ismagulov <ibr@radix50.net>]

On Tue, Oct 02, 2018 at 04:02:54PM +0200, Claudius Heine wrote:
> > +# Uncomment this to enable use of cached base repository
> > +#ISAR_USE_CACHED_BASE_REPO ?= "1"
> 
> No that doesn't make sense to me.
> 
> In my opinion its very important to not have such flags or commands. Caching
> and reproducible builds should be the default operation, upgrading or
> removing the cache should be an extra step.

The first step is to provide the mechanism which is usable manually or
automatically. Defining policy and setting it as default is best done when the
feature has been stabilized; I'd be reluctant to slap a new feature as default
as soon as it is introduced. I'd suggest to address that in later steps. That
said, the option doesn't take it away from you -- just set it to true in your
configuration.


> Also please avoid those binary settings like `ISAR_USE_CACHED_BASE_REPO`.
> That just bad design because it leads to every tiny setting having an own
> variable. Use FEATURE variables with entries like:
> 
> `ISAR_BUILD_FEATURE = "cross-build use-cache ..."`
> 
> Yes cross-builds should have been done like this as well IMO.

Hmm, that's an interesting idea. Conceptually, I fail to see any difference
from boolean vars: One still has boolean feature names for every tiny setting.
I personally don't like features since they are difficult to remove from
default settings.


With kind regards,
Baurzhan.