From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6607733288662466560 X-Received: by 2002:a1c:d085:: with SMTP id h127-v6mr653557wmg.24.1538643795327; Thu, 04 Oct 2018 02:03:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:138f:: with SMTP id 137-v6ls793670wmt.14.canary-gmail; Thu, 04 Oct 2018 02:03:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV60qqFqIkBWU4IhidaS6U8VNcoSowFiJ+/0WLgz8xfyiEVsR1i/Lz//cHQYYiVtSWL6A2Go4 X-Received: by 2002:a1c:b5c9:: with SMTP id e192-v6mr679258wmf.22.1538643794945; Thu, 04 Oct 2018 02:03:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538643794; cv=none; d=google.com; s=arc-20160816; b=Q6znasIJhJ6cW9iRrym5AKRjBFHeCkxqJUYhdGbWp9JuCosmcp7cHXjnBbXsOg1jtJ OnBby8hModpnwEg6PjT12+14/4N1hDSlzWzK3wpZh8KnZOQhh7oIHQ6DWgvzbOQeNQzf VLNnprnV/Z3Wkt6RRN8d9Fl2q2PZ5aQ2ldVIEr99gPVjS1Q2Kakg6I4pZibrEiSeu5dv CeM4K6A5DVENj8Oi1aXPi8riJK4K5IzOYqOgA/eArKLp2P7myP2Ay92c1H+B8m4CjhCY 0Pqsu2pcBFLUFgQdi9y2U7b8XHKo4onBNBy3z+96kuM/CQQGhw3NvqExpQ+V3yc1pYPJ NcSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date; bh=SpP++y1EFeirX6VZbpjOcHnYBLS9CINGtrRlPX01eN4=; b=JHDy1vHXHkfywaG5ch774oh+lqlCNzDOplyb/DJPJDOXQLLsMGuEkEhEG5RXd9FT7b BSFwTE2/CHkGX7fDQMZfcdKc5sLtYgF+C+9/B1YmwyTyP7bVlmTOwxYDDwj4shhbWh/Q KZOvBvLkLoGzOVxfRXexv6FiOgASM+gXGn+MZIN2oNWMDwr3Aw9yA8Bm5b0cHvguGWAf Q0AP/Ic+QKO9pLg6brXdUbkTJAwngXNVW85mr5zJSm0ThfXD439dUY6041/XxQYjC8tJ YnqdWsmAC/8/mpQQYseVjE5UJ68hOr0Moc/bI8hN3SAQsMhyDDdktaYwMJmxnMkYEVap KRcA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id h188-v6si147562wmg.2.2018.10.04.02.03.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Oct 2018 02:03:14 -0700 (PDT) Received-SPF: neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 85.214.62.211 is neither permitted nor denied by best guess record for domain of ibr@radix50.net) smtp.mailfrom=ibr@radix50.net Received: from yssyq.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w9493Cpn020560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Oct 2018 11:03:13 +0200 Received: from yssyq.m.ilbers.de (localhost [127.0.0.1]) by yssyq.m.ilbers.de (8.15.2/8.15.2/Debian-8) with ESMTPS id w9493C2s013570 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 4 Oct 2018 11:03:12 +0200 Received: (from ibr@localhost) by yssyq.m.ilbers.de (8.15.2/8.15.2/Submit) id w9493B1U013569 for isar-users@googlegroups.com; Thu, 4 Oct 2018 11:03:11 +0200 Date: Thu, 4 Oct 2018 11:03:11 +0200 From: Baurzhan Ismagulov To: isar-users@googlegroups.com Subject: Re: [PATCH 9/9] doc: Creation of local apt repo caching upstream Debian packages Message-ID: <20181004090311.GA12890@yssyq.m.ilbers.de> Mail-Followup-To: isar-users@googlegroups.com References: <20181002121907.18476-1-mosipov@ilbers.de> <20181002121907.18476-10-mosipov@ilbers.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-TUID: YXbAPIAzauBt On Tue, Oct 02, 2018 at 04:02:54PM +0200, Claudius Heine wrote: > > +# Uncomment this to enable use of cached base repository > > +#ISAR_USE_CACHED_BASE_REPO ?= "1" > > No that doesn't make sense to me. > > In my opinion its very important to not have such flags or commands. Caching > and reproducible builds should be the default operation, upgrading or > removing the cache should be an extra step. The first step is to provide the mechanism which is usable manually or automatically. Defining policy and setting it as default is best done when the feature has been stabilized; I'd be reluctant to slap a new feature as default as soon as it is introduced. I'd suggest to address that in later steps. That said, the option doesn't take it away from you -- just set it to true in your configuration. > Also please avoid those binary settings like `ISAR_USE_CACHED_BASE_REPO`. > That just bad design because it leads to every tiny setting having an own > variable. Use FEATURE variables with entries like: > > `ISAR_BUILD_FEATURE = "cross-build use-cache ..."` > > Yes cross-builds should have been done like this as well IMO. Hmm, that's an interesting idea. Conceptually, I fail to see any difference from boolean vars: One still has boolean feature names for every tiny setting. I personally don't like features since they are difficult to remove from default settings. With kind regards, Baurzhan.