Re: [PATCH] recipes-app: rename example app and lib recipe to contain PV

[Henning Schild <henning.schild@siemens.com>]

Am Tue, 2 Oct 2018 22:35:59 +0200
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 02.10.18 20:17, [ext] Henning Schild wrote:
> > The PV of a package is best contained in its filename, that way a
> > version bump would be chaning the file name. Also switch to using
> > the git tag as SRCREV, now we can really just rename that file to
> > update.
> > 
> > Following that pattern we could also have multiple versions of the
> > recipe in one tree.
> > 
> > While we do not need all of this for Isar or for this simple
> > example, be a good example for people reading those recipes.  
> 
> NACK for the SRCREV changes.
> 
> That's an OE anti-pattern, (almost) like specifying a branch and
> ${AUTOREV}. You need some sort of checksum (md5, sha256 for files,
> SHA1 for git commits) to validate no one moved the upstream tag
> around.

I see, if we do not trust upstream in keeping the tags intact, i guess
the whole patch can be dropped.

Henning

> Jan
>